From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A77F542D1C for ; Thu, 22 Jun 2023 17:07:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D354142C54; Thu, 22 Jun 2023 17:07:00 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2088.outbound.protection.outlook.com [40.107.237.88]) by mails.dpdk.org (Postfix) with ESMTP id AEC164113F; Thu, 22 Jun 2023 17:06:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RhJfSjl1HfsQaXJnOWTy/utwqwURrf82s7WZJg3DruX+q0njUW08jnZ8ve6nm/YmEDRPN7J2Qwb9B2jLDtd16pmCnM6fWK7LD4H4e8c47lblyVAAa59FPCDpTOnB3DfvpGgXXcq55aPO3HCAUDxXvpgtxXpn7KVGWNxp/DlhrkYkYUKBK80T0S1kxxNOmRfzCLWQmPTcnBJhY26VzAPdk2x+DtVsxq6rz99arL6RtGqUzvDgUlvBYC4kvNjD1NuoyJc/DzoIg1T14OZMwjlXmM64Xh2LZaalXLD9PZ98qbp6HuNzQuJQY7lm3rMuurjeS2sBudzRIct38vBFRAk7Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oQAuS0L7S1b18RGVhQ3UI2TwJUu62FMEuhAyhXjw0RM=; b=OBPK04/cCNfg5u7SOGyIxW2wp5aPXlAfohGoU8c5y0i2Ywydw4JgEK/dH16Nl+JY/KR6vEM+M485aLVst8s53iijc1/ySRK9LYuPD/cuajUzaG71lLthRgXJd+kaJSYWBRKlByjnmJt1RPDhWmF1QeNa+xLXvg2LHaw47u3BGxG513eOqoXPNelgELM0V2jVfXWGTfLBT58urLZCFWBjT9anxICj/kyKzqPFIaYeXTR7Of7wLXSE5wx+p7fqZQc7+Euddbu4xq4C2fin+WUElD6wztPeQDzvtzhQaO2Dxn9LemFDWkG9UUuayiDR4/B6QKFutRIW2hMJMokmB0ZnRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oQAuS0L7S1b18RGVhQ3UI2TwJUu62FMEuhAyhXjw0RM=; b=JUfFf9P7bqhTJQCFT7WujxFmZNwwVGE6mZCu8ATgoglKb8Od2RdIkxcaTGX4+hovBc6s3uZYk6mMraEgpg59EDym1OA2i+6dIVjBwMruMVXMx7RWsTnLF34H6Y6j5TZyMfNhDQPuMdeDjSFvN4g4ipoA5Z5iW8P6CRd/bnRW0I4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY8PR12MB7586.namprd12.prod.outlook.com (2603:10b6:930:99::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23; Thu, 22 Jun 2023 15:06:58 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6521.024; Thu, 22 Jun 2023 15:06:58 +0000 Message-ID: <0ed0aa00-d46e-37f3-251d-96195cb36218@amd.com> Date: Thu, 22 Jun 2023 16:06:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v5] common/sfc_efx/base: fix Rx queue creation without RSS hash prefix Content-Language: en-US To: Artemii Morozov , dev@dpdk.org Cc: Andrew Rybchenko , stable@dpdk.org, Andy Moreton References: <20230531070810.93131-1-artemii.morozov@arknetworks.am> <20230622123136.264482-1-artemii.morozov@arknetworks.am> From: Ferruh Yigit In-Reply-To: <20230622123136.264482-1-artemii.morozov@arknetworks.am> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0612.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:314::6) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY8PR12MB7586:EE_ X-MS-Office365-Filtering-Correlation-Id: 2af6e001-4869-439e-b157-08db733252b5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u5zjow+6chPtqqupjsvAhzndMWUcjwpj2r0PK0mr2dAxOjwsCBF60POKlubVwYLobBtqFiMYSvuOPWWo1wgxTQrbiI+amLm32ToTgFaDXQ9QNhyiyF/8M2PETjS2fQMd/FZo8EdKtI25nhbuTfrYjeSLiEUcACGkEYG3ZWUF5PECUpBqXviGxWf83WS1xCTg4V+vVhWk/D/uLX5QzPBO7tG1mRWauYjzdPSDVWgyNgt9EGNhNLuaXMupSQ2Bvgf6fKxKAHQzS5yEibqGlkgM4tWTaiKStd1kZy4MW1Ou5n1PH1T44tSlqA5m5vAUWjbqllGalZR1PqG3asTGrE1pcSZEH6hjgVAN5vo3JkO1CBnDFBkKAOFkLTg1jlz3a564KzmQNPav4B7vaj0MFJP4kuxTADk4h/Y9/Uevns5t6ym6RrMhrJPXQQwLwQBXZbr5oIhpIUbKnjDSqqU3fmpo+/TNBZeynlr9B2MAAsvEgPae3/MU8/ltp2620aPjWxjdGDg71PE5QzOdfE54iwnxErMzV+8zbmI4bUh3VHz2ps5cydcDA91jKmc+b7cu462zR6zaMlmJI/JkhuXuldPjA4GU1GCpbtokFUVdD1olQTa8of4ASRUnPFz3EYhXfT4IkRNFHAIu6cK8Qy0sKSNRJA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(346002)(136003)(376002)(39860400002)(396003)(451199021)(66946007)(66556008)(4326008)(316002)(66476007)(8676002)(8936002)(6506007)(6512007)(41300700001)(26005)(186003)(53546011)(2616005)(54906003)(6666004)(6486002)(2906002)(4744005)(5660300002)(478600001)(44832011)(38100700002)(31696002)(31686004)(83380400001)(36756003)(86362001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUZTTkYwTnJJek5OMU5DWG1FZFZVak5VOTV1L3JhNGU0L1IrMlhESDcrZTlN?= =?utf-8?B?Ty9LU1lBK3I5UGpWOUtPMFhvTDdsclJmWVlnSFhPOE02Sk1kdHk3dytLWDhh?= =?utf-8?B?cmZIbUNuNHBWVGQ5Qi9zT0JxMnhXcEFxOEU4dWw4aVpOdEp6YUg5eTZic2xh?= =?utf-8?B?VXFlTWFMb1ZzS09tZWFOM1lWdzl1b3c5eFpybm5sdTZSQlNsYlQvSS9VYU81?= =?utf-8?B?U2NHNVh5NUZTWk1LWHJXZ3FsSXR0YUdBeXh6ak1oYjBseXc3eTN6Zk55cFVL?= =?utf-8?B?Q2Zpb3pmK0gvd1FTdTU3U1hVbVlhZG9tMUNjemozanFQOWd5VVN3RWZmZGlh?= =?utf-8?B?RFlwZmdqaDg1elZBNVpWeU9jTDg5ZDdmc0I4VmRpcENKdmUwRSsrU3F2TjFn?= =?utf-8?B?d1V4VmtJQVBPSTMrM05wV3hIM0ZmbnhHS2IwL0ZYZmcrQk1PTlpYbjNnczZM?= =?utf-8?B?dTB5aGFjUk5Rd1JZMTh0L1VzQWRieVJKUGlHNGdPMzk4MGZRN3U0eEd4SlFE?= =?utf-8?B?RVhHT1VkRzVaTE5kQTVkNmNiOE4xUUJqeC93aE04dElQU3l3aDNERGRHZDh6?= =?utf-8?B?Nzl3a1ZGZFJHSm9CMlpmTFhzY0lZUHMwR2krd0FFaDZOWXEvQ09iZGVON3Rl?= =?utf-8?B?ak94YlNIb0RMNmxZZkRCVzVudEo3UVZSNEkwcFQ2KzRUdEVYU3MzK0wvanBS?= =?utf-8?B?aXZQNXd0ZkN4VnBZV3F0MU5KZDBnRTlTWmg2QTc4Ry9YQlZMSi9qaFVDTVQr?= =?utf-8?B?MER2ckU2MjNrM0JhSzVNSmV3dE52bk8rWGVJVWxpdWZYekcxZjIvbWtXRWh0?= =?utf-8?B?TDc4MUFZZ0t0ZDQrQjZkSC9lSW9zcDF2UTN6N1U3WWd5U09SSkhFWlZ4MlND?= =?utf-8?B?cmdxS2dwNmtBSldLczd3dm1WQmFNbG5EN09LMW5Ga0t4Yi9PSXpFOEdYTU1L?= =?utf-8?B?QlIyaHNWRWxCUXJBK3YrNG5ZWUd1T1J0SlpRSVoxTEJhaTdyWkYzOVdUVXY0?= =?utf-8?B?KzRDY0VzLzlHR2hERkM5ZjlyZStxRU9LaVFOT2hRcW90QXFHMGFvczh6SjQ1?= =?utf-8?B?U1YrZnBYNWxuV2M1NUpWejdSL3dnNE5Sd1pvL3B3aXZjdXF4bFQ2djFUbHJr?= =?utf-8?B?ZXZhbW8rMThMUTF0VG85aEVRYkxqRG1Qam51QU4rUVJMVkFDN3dQUkFubUF3?= =?utf-8?B?M08xYUZCN01NaU5BcEx0cXdGSndiK0NoV1lHZG40SWVBMlg3M085emZWajFx?= =?utf-8?B?akJTL2NlWHNDWGJweVp3V2xVaHBQZllvNDg1a3VaS2NvSk5FU0tYaGVRZytN?= =?utf-8?B?di9yeGlTQU5wU0FVdzFlVmErektnWGhCQUxiTkZYcjlpM00wSUppMDBFbWJh?= =?utf-8?B?VXNJR2t4R1hDckdBcUdodXdCS3hzK01vSUU5ZlFJQWU1NHo0Sm5GWWptcE9X?= =?utf-8?B?b3N5YWJkdkIzVElJeFlPQVNWUE5oUG84SnhCNG03MmdOSm1WeXUycnduUjNF?= =?utf-8?B?L1RpMmNlZG5TbjlNaGVZaEs0bWQrYksrOFEzYkZqUUIwenBWQ0dhY1Q2RVZq?= =?utf-8?B?T2VXUkxyNW1QWDF6TTRzLy9QRXNtNXEvejlHd3JScTFjZnI3VnZlSWZ4Rldt?= =?utf-8?B?YjJMeGxMd2lSc1hac3NJemF1MnQ4TFJ1T0JtR3ZsaDZldERhNVBWbUxtcU1E?= =?utf-8?B?M0R6OW9FdE15U3JYRktXMGlrV0paSk9kVlVHVENvMklQU3d4UFhHRmwybzFL?= =?utf-8?B?VUNwdVFjc0VXZFd3Um1YWjk3OGEvV0FBaldhdUlOa1h4NG5oT1FJa2FYV29W?= =?utf-8?B?Z21oMkZDbThZejh4aWhiZ2M5aHorcDNaK1MxRmtyK1NkRUt6eFpMU2RXcHRs?= =?utf-8?B?SEZGWll3TzJ3dVRFQVBneTZLelR2aVhpNks1bFhvbmYveDZMRVFBMGVGTVFv?= =?utf-8?B?bFNCQ3Bkb0w3UFlaTjlGdUpGSytwL2NpVkt4UUsvTUw3WmNrSzVZWFdoZmlw?= =?utf-8?B?NlA1MzFYRStzMXBJeFpqSXhVY0VLcGM3VXIwc0U1KytLTzNNclc5K0RGVzJC?= =?utf-8?B?UStJeHRrblFYTTEzVi9GSlQ0TDFqSU91emZUNTF6S29GVWdPME01MVUxTjlm?= =?utf-8?Q?QWoWlWr7lYrXoDBzHAeYB1qPh?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2af6e001-4869-439e-b157-08db733252b5 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2023 15:06:57.7667 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZGH1+j54BQ+NbHuefUKY0HxS7OSnQSEkWQgkbCLXHZNi/uFoDY6q1S3y0KozzkBP X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7586 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 6/22/2023 1:31 PM, Artemii Morozov wrote: > If the prefix for the RSS hash was not chosen the ENOTSUP error should > be returned. > > Before this patch success was returned for this case causing Rx queue > creation to fail. > > Fixing return value to indicate failure. > > Fixes: f784cdc5cbb1 ("common/sfc_efx/base: provide control to deliver RSS hash") > Cc: stable@dpdk.org > > Signed-off-by: Artemii Morozov > Reviewed-by: Andy Moreton > Acked-by: Andrew Rybchenko > Applied to dpdk-next-net/main, thanks.