patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Jin Yu <jin.yu@intel.com>, Tiwei Bie <tiwei.bie@intel.com>,
	Zhihong Wang <zhihong.wang@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2] vhost-blk: fix the unused return value
Date: Wed, 27 Nov 2019 13:57:49 +0100
Message-ID: <100a3288-aefe-cb07-8756-50a747db521a@redhat.com> (raw)
In-Reply-To: <20191127121659.51709-1-jin.yu@intel.com>



On 11/27/19 1:16 PM, Jin Yu wrote:
> add the assert to handle error.
> 
> Coverity issue: 350592
> Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jin Yu <jin.yu@intel.com>
> ---
> v2 - add the error hander
> ---
>  examples/vhost_blk/vhost_blk.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/examples/vhost_blk/vhost_blk.c b/examples/vhost_blk/vhost_blk.c
> index 3182a488b..e1036bf3a 100644
> --- a/examples/vhost_blk/vhost_blk.c
> +++ b/examples/vhost_blk/vhost_blk.c
> @@ -856,6 +856,7 @@ new_device(int vid)
>  				ctrlr->bdev->vid, i,
>  				&blk_vq->last_avail_idx,
>  				&blk_vq->last_used_idx);
> +			assert(ret == 0);
>  
>  			blk_vq->avail_wrap_counter = blk_vq->last_avail_idx &
>  				(1 << 15);
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  reply	other threads:[~2019-11-27 12:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26 15:37 [dpdk-stable] [PATCH] vhost-blk: delete " Jin Yu
2019-11-26 14:58 ` Maxime Coquelin
2019-11-27 12:16 ` [dpdk-stable] [PATCH v2] vhost-blk: fix " Jin Yu
2019-11-27 12:57   ` Maxime Coquelin [this message]
2020-01-09 15:51     ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=100a3288-aefe-cb07-8756-50a747db521a@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jin.yu@intel.com \
    --cc=stable@dpdk.org \
    --cc=tiwei.bie@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git