From: fengchengwen <fengchengwen@huawei.com>
To: Bruce Richardson <bruce.richardson@intel.com>, <dev@dpdk.org>
Cc: <stable@dpdk.org>, Chenbo Xia <chenbox@nvidia.com>,
Nipun Gupta <nipun.gupta@amd.com>,
Anatoly Burakov <anatoly.burakov@intel.com>,
Tetsuya Mukawa <mtetsuyah@gmail.com>
Subject: Re: [RFC PATCH v2 12/33] bus/pci: remove shadowed variables
Date: Mon, 10 Nov 2025 09:15:53 +0800 [thread overview]
Message-ID: <1056c1be-c23b-4c6d-8260-f855be5af02d@huawei.com> (raw)
In-Reply-To: <20251107155034.436809-13-bruce.richardson@intel.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
On 11/7/2025 11:50 PM, Bruce Richardson wrote:
> Remove two instances where we had duplicate shadowed local variables
> called "ret". In each case, we could just remove the inner instance,
> since the outer value was not needing to be preserved.
>
> Fixes: 03ba15ca65c1 ("vfio: allow mapping MSI-X BARs if kernel allows it")
> Fixes: c0ce0577e84d ("pci: consolidate address comparisons")
> Cc: stable@dpdk.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2025-11-10 1:15 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251106140948.2894678-1-bruce.richardson@intel.com>
2025-11-06 14:09 ` [RFC PATCH 01/19] eal: fix variable shadowing Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 02/19] ethdev: fix variable shadowing issues Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 03/19] eventdev: " Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 04/19] net: remove shadowed variable Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 05/19] graph: fix variable shadowing errors Bruce Richardson
2025-11-06 15:50 ` Stephen Hemminger
2025-11-06 16:33 ` Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 06/19] pipeline: fix variable shadowing Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 07/19] table: fix issues with " Bruce Richardson
2025-11-06 19:37 ` Stephen Hemminger
2025-11-06 19:58 ` Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 08/19] power: rename variable to eliminate shadowing Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 09/19] pcapng: rename variable to fix shadowing Bruce Richardson
2025-11-06 15:51 ` Stephen Hemminger
2025-11-06 14:09 ` [RFC PATCH 10/19] telemetry: make socket handler typedef private Bruce Richardson
2025-11-07 2:43 ` fengchengwen
2025-11-06 14:09 ` [RFC PATCH 11/19] bbdev: fix variable shadowing Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 12/19] bus/pci: remove shadowed variables Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 14/19] net/e1000: fix build with shadow warnings enabled Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 15/19] net/i40e: " Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 16/19] net/ice: " Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 17/19] net/cpfl: " Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 18/19] net/ixgbe: " Bruce Richardson
2025-11-06 14:09 ` [RFC PATCH 19/19] app/test-pmd: " Bruce Richardson
[not found] ` <20251107155034.436809-1-bruce.richardson@intel.com>
2025-11-07 15:49 ` [RFC PATCH v2 02/33] eal: fix variable shadowing Bruce Richardson
2025-11-10 0:59 ` fengchengwen
2025-11-07 15:49 ` [RFC PATCH v2 03/33] ethdev: fix variable shadowing issues Bruce Richardson
2025-11-09 14:36 ` Andrew Rybchenko
2025-11-10 1:12 ` fengchengwen
2025-11-07 15:50 ` [RFC PATCH v2 04/33] eventdev: " Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 05/33] net: remove shadowed variable Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 06/33] pipeline: fix variable shadowing Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 07/33] table: fix issues with " Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 08/33] power: rename variable to eliminate shadowing Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 09/33] pcapng: rename variable to fix shadowing Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 10/33] telemetry: make socket handler typedef private Bruce Richardson
2025-11-10 1:15 ` fengchengwen
2025-11-07 15:50 ` [RFC PATCH v2 11/33] bbdev: fix variable shadowing Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 12/33] bus/pci: remove shadowed variables Bruce Richardson
2025-11-10 1:15 ` fengchengwen [this message]
2025-11-07 15:50 ` [RFC PATCH v2 14/33] net/e1000: fix build with shadow warnings enabled Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 15/33] net/i40e: " Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 16/33] net/ice: " Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 17/33] net/cpfl: " Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 18/33] net/ixgbe: " Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 19/33] app/test-pmd: " Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 20/33] app/graph: " Bruce Richardson
2025-11-07 15:50 ` [RFC PATCH v2 21/33] app/pdump: fix warning about shadowed variable Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1056c1be-c23b-4c6d-8260-f855be5af02d@huawei.com \
--to=fengchengwen@huawei.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=chenbox@nvidia.com \
--cc=dev@dpdk.org \
--cc=mtetsuyah@gmail.com \
--cc=nipun.gupta@amd.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).