From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3ED848AC5 for ; Mon, 10 Nov 2025 02:15:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED16640608; Mon, 10 Nov 2025 02:15:58 +0100 (CET) Received: from canpmsgout11.his.huawei.com (canpmsgout11.his.huawei.com [113.46.200.226]) by mails.dpdk.org (Postfix) with ESMTP id 65B62400D6; Mon, 10 Nov 2025 02:15:56 +0100 (CET) dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=Sfw9m6o840pdmID0Fi8EaX3x2x8GNx4J9ji4EUOj4lI=; b=bYy9A6dK7lNYkeapkS6gwvYYZSJux1Hg2W7xSEzBdb849LW/VpnnR25CznWHr/05gboamLdKg Vt+NJv/aE+VxvrvNZ5PpcWDr3NS4P6r59+S47mXtHXCr2ZoR4xbMHuu6M/Igk6okuOiK7YPNS/+ Tn/a9+EuMVaA5+6QHC+PXW4= Received: from mail.maildlp.com (unknown [172.19.162.112]) by canpmsgout11.his.huawei.com (SkyGuard) with ESMTPS id 4d4WsN01WRzKm51; Mon, 10 Nov 2025 09:14:15 +0800 (CST) Received: from kwepemk500009.china.huawei.com (unknown [7.202.194.94]) by mail.maildlp.com (Postfix) with ESMTPS id A5F2F1401F3; Mon, 10 Nov 2025 09:15:54 +0800 (CST) Received: from [10.67.121.161] (10.67.121.161) by kwepemk500009.china.huawei.com (7.202.194.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Mon, 10 Nov 2025 09:15:54 +0800 Message-ID: <1056c1be-c23b-4c6d-8260-f855be5af02d@huawei.com> Date: Mon, 10 Nov 2025 09:15:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v2 12/33] bus/pci: remove shadowed variables To: Bruce Richardson , CC: , Chenbo Xia , Nipun Gupta , Anatoly Burakov , Tetsuya Mukawa References: <20251106140948.2894678-1-bruce.richardson@intel.com> <20251107155034.436809-1-bruce.richardson@intel.com> <20251107155034.436809-13-bruce.richardson@intel.com> Content-Language: en-US From: fengchengwen In-Reply-To: <20251107155034.436809-13-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.161] X-ClientProxiedBy: kwepems100001.china.huawei.com (7.221.188.238) To kwepemk500009.china.huawei.com (7.202.194.94) X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Acked-by: Chengwen Feng On 11/7/2025 11:50 PM, Bruce Richardson wrote: > Remove two instances where we had duplicate shadowed local variables > called "ret". In each case, we could just remove the inner instance, > since the outer value was not needing to be preserved. > > Fixes: 03ba15ca65c1 ("vfio: allow mapping MSI-X BARs if kernel allows it") > Fixes: c0ce0577e84d ("pci: consolidate address comparisons") > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson