From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BEAFA09E4 for ; Thu, 4 Feb 2021 14:33:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28BBC2406F4; Thu, 4 Feb 2021 14:33:31 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 6F72D2406C8; Thu, 4 Feb 2021 14:33:28 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id C65DA7F5F3; Thu, 4 Feb 2021 16:33:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru C65DA7F5F3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1612445607; bh=ziqD/D4xt365AOY6G2qZxZfzedNu9STzrQz4yCpUmlo=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=i/GWKUY23F+5NiHAFRuCx/4MD4ZzjdvMkHzz4K9rTJbYpSBK0W4nIsfwIVNkznBmY sF2B+10DvzVZnAWlMgSE4eBhL4DGR/WPKBAs73Z6X7bbA39tR93pZzThY98Mclv/Bh x1homLE999UW5kuIPH7cLo5ikKP40fR0OV120lUg= To: Olivier Matz , dev@dpdk.org Cc: stable@dpdk.org References: <20210203090101.5669-1-olivier.matz@6wind.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <10d7ba83-0646-846b-c37f-3f752441e71e@oktetlabs.ru> Date: Thu, 4 Feb 2021 16:33:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210203090101.5669-1-olivier.matz@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH] mempool: fix invalid panic on dump or audit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 2/3/21 12:01 PM, Olivier Matz wrote: > When doing a mempool dump or an audit, the application can panic because > the length of the cache is greater than the flush threshold, which is > seen as a fatal error. But this can temporarily happen when the mempool > is in use. > > Fix the panic condition to abort only when the cache length is greater > than the array. > > Fixes: ea5dd2744b90 ("mempool: cache optimisations") > Cc: stable@dpdk.org > > Signed-off-by: Olivier Matz Acked-by: Andrew Rybchenko