From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FCC248AFF for ; Thu, 13 Nov 2025 23:37:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3FF7F40DD6; Thu, 13 Nov 2025 23:37:50 +0100 (CET) Received: from fhigh-b5-smtp.messagingengine.com (fhigh-b5-smtp.messagingengine.com [202.12.124.156]) by mails.dpdk.org (Postfix) with ESMTP id 2D49240151; Thu, 13 Nov 2025 23:37:47 +0100 (CET) Received: from phl-compute-07.internal (phl-compute-07.internal [10.202.2.47]) by mailfhigh.stl.internal (Postfix) with ESMTP id 030AD7A0165; Thu, 13 Nov 2025 17:37:45 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-07.internal (MEProxy); Thu, 13 Nov 2025 17:37:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1763073465; x=1763159865; bh=yGzozPc8x8UECHf+UM28FkGg0jlzk84+eiMjzqZVxv0=; b= c5cgYv2nyJjTA0izFrEaI3DUX0FuP9NfEazDCPglq4PGRwBMfOfaRorst9gGeHF1 XAO33j/Sdy0z3WbKlk7K52kauxW9ZRTwEcTBWq3A4+tm6bKWtT17QaiTaAu7ox3H hBH5VyjL1M5B+w3neCqfjEuz2c9vujrwGZgDRQ0jd/RILWCPXwB4Df0uWt+V4xdn LHkut9ujjigW0SI0lLFaA/o6n+JQ/pLyzEijZswqGUH0dEKDok76ygayYbLpQqHB /Jy/Mqj3gFbVOycdOCYjoSr6sErmmZgUwWCuPa5r3SZn8asht+UnbwIW4T89H6mP rHImA7BxPWW92vKR/rHghA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1763073465; x= 1763159865; bh=yGzozPc8x8UECHf+UM28FkGg0jlzk84+eiMjzqZVxv0=; b=N ZPIeG7QkYkE1YRhL51wTnrFHK+ck4gFqBuXSArL+SC+L3VQCKqbxxcGkItvnat4U y+DbknVJEb5NOMvCWR2wYktrdC2w4oV2M4JLX3ijZHUyx1M2gGLztm34qkDIFfLB P8HJMecsLuTFfNtq+weTIZ/J7u/fS16DWDDLoCv0qViGo5L+/xWR/pzzMdP3fYvG 5f+GpmR8l51DdG3CUsAJIUZdiMGbc5o2Si6MhrIN6z0pZ594oqUMIarX5oMjMpqx uSNGRwR1Z134PD0ahuWzWgsDeukwKUFIuGtR6mrXx+gYnKIbjS6hD7KkSeiHorsD l/15OFBxT+Wu1xE8VleBg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvtdekudeiucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeekueevjeffjeegtdeggeekgfdv uefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhnsggprhgtphhtthhopedufedp mhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepihhshhgrrhhonhhisehnvhhiughirg drtghomhdprhgtphhtthhopeguvghvseguphgukhdrohhrghdprhgtphhtthhopehmkhgr shhhrghnihesnhhvihguihgrrdgtohhmpdhrtghpthhtoheprhgrshhlrghnugesnhhvih guihgrrdgtohhmpdhrtghpthhtohepshhtrggslhgvseguphgukhdrohhrghdprhgtphht thhopegsihhnghiisehnvhhiughirgdrtghomhdprhgtphhtthhopegushhoshhnohifsh hkihesnhhvihguihgrrdgtohhmpdhrtghpthhtohepvhhirggthhgvshhlrghvohesnhhv ihguihgrrdgtohhmpdhrtghpthhtohepohhrihhkrgesnhhvihguihgrrdgtohhm X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Nov 2025 17:37:43 -0500 (EST) From: Thomas Monjalon To: Itai Sharoni Cc: dev@dpdk.org, mkashani@nvidia.com, rasland@nvidia.com, Itai Sharoni , stable@dpdk.org, Bing Zhao , Dariusz Sosnowski , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad , Ophir Munk Subject: Re: [PATCH] net/mlx5/windows: fix match criteria in flow creation Date: Thu, 13 Nov 2025 23:37:40 +0100 Message-ID: <11095513.IZOipudI63@thomas> In-Reply-To: <20251113122642.1193-1-isharoni@nvidia.com> References: <20251113122642.1193-1-isharoni@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 13/11/2025 13:26, Itai Sharoni: > Currently the Windows implementation hardcodes match criteria to > MLX5_MATCH_OUTER_HEADERS when creating flow rules, which prevents > matching on inner headers and other criteria types like NVGRE. > > The fix uses the matcher's match_criteria_enable attribute instead > of hardcoding OUTER_HEADERS, and moves the assignment outside the > action switch block to apply to all cases. > > NVGRE item type is also added to the supported items list. Why adding only NVGRE? Should we mention which tunnels are supported on Windows in the doc?