From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4 1/8] net/ice: fix Tx function setting
Date: Fri, 22 Mar 2019 10:01:44 +0100 [thread overview]
Message-ID: <1151d47d-4a77-f192-38f6-d7231fca30c8@redhat.com> (raw)
In-Reply-To: <eb8fd186-2f6e-ad4c-6faf-0d41729a2f58@redhat.com>
On 3/22/19 9:46 AM, Maxime Coquelin wrote:
>
>
> On 3/21/19 7:26 AM, Wenzhuo Lu wrote:
>> The TX setting functions is not called.
>
> s/functions/function/
>
>>
>> Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
>> ---
>> drivers/net/ice/ice_ethdev.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
>> index a23c63a..b804be1 100644
>> --- a/drivers/net/ice/ice_ethdev.c
>> +++ b/drivers/net/ice/ice_ethdev.c
>> @@ -1741,6 +1741,7 @@ static int ice_init_rss(struct ice_pf *pf)
>> }
>> ice_set_rx_function(dev);
>> + ice_set_tx_function(dev);
>> mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK |
>> ETH_VLAN_EXTEND_MASK;
>>
>
> Other than that:
>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Sorry, just notice I didn't fetch my mailbox, so I didn't see the v5.
Anyway my comments seem to apply to v5 too.
Maxime
next prev parent reply other threads:[~2019-03-22 9:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1551340136-83843-1-git-send-email-wenzhuo.lu@intel.com>
[not found] ` <1553149569-105555-1-git-send-email-wenzhuo.lu@intel.com>
2019-03-21 6:26 ` [dpdk-stable] " Wenzhuo Lu
2019-03-22 8:46 ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin
2019-03-22 9:01 ` Maxime Coquelin [this message]
[not found] ` <1553223516-118453-1-git-send-email-wenzhuo.lu@intel.com>
2019-03-22 2:58 ` [dpdk-stable] [PATCH v5 " Wenzhuo Lu
[not found] ` <1553493995-29803-1-git-send-email-wenzhuo.lu@intel.com>
2019-03-25 6:06 ` [dpdk-stable] [PATCH v6 " Wenzhuo Lu
[not found] ` <1553581011-94181-1-git-send-email-wenzhuo.lu@intel.com>
2019-03-26 6:16 ` [dpdk-stable] [PATCH v7 " Wenzhuo Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151d47d-4a77-f192-38f6-d7231fca30c8@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).