From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 177BC4410E for ; Thu, 30 May 2024 13:14:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E58C40E6E; Thu, 30 May 2024 13:14:25 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mails.dpdk.org (Postfix) with ESMTP id 39CE040E0F; Thu, 30 May 2024 13:14:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717067660; x=1748603660; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pH5TlTdGXAg9O85La1eq6EPtkLVnpxXM+bYQy6K+eRI=; b=J1B84fdP7tWE95GcVrqQfF+BB1uLEI7Iu7mMdo4i4YB4ne/p9aROzW1R bZdbQP8u4HPikIoizM3sD9wgVRC4sbdyA5Pyxt7I34Z0hY9q/RnQHQibK cR0B2yp/l6NExnpPEIb4ADGYxmLSSsvMFCXtWHSZg7yl0n8O00AM3LW74 qTsD4wZ0KxN1WhVK/ViPpwAc4RGh/r5tBG2lVFDNrSqEdNp23+H871lAu LTwp0o0NVe5UyMHogxtQv1ldPEjbptUVRmaCTN0FR/6zLv+uHAFpQxLxl GHBEQNjP4Rg7YYUPm/CwsvWOBEBQDzXAaEbagguorEgKOtMIu55CJXA3F w==; X-CSE-ConnectionGUID: zN61GraXRLKyQuayRqU+2A== X-CSE-MsgGUID: S2cmMDX/QPulBLRK3IDiRQ== X-IronPort-AV: E=McAfee;i="6600,9927,11087"; a="36063502" X-IronPort-AV: E=Sophos;i="6.08,201,1712646000"; d="scan'208";a="36063502" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2024 04:14:19 -0700 X-CSE-ConnectionGUID: Xu5qkorlQQilIY45s8jjPw== X-CSE-MsgGUID: hxu8bBanSaeBXQSR+GLOLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,201,1712646000"; d="scan'208";a="36419282" Received: from silpixa00401119.ir.intel.com ([10.55.129.167]) by orviesa007.jf.intel.com with ESMTP; 30 May 2024 04:14:16 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Piotr Pietruszewski , vladimir.medvedkin@intel.com, bruce.richardson@intel.com, stable@dpdk.org, Skajewski@dpdk.org, PiotrX , Marek Mical , Kirsher@dpdk.org, Jeffrey T , Michael@dpdk.org, Alice Subject: [PATCH v3 01/30] net/ixgbe/base: revert remove default advertising for x550 2.5G/5G Date: Thu, 30 May 2024 12:13:34 +0100 Message-ID: <1203f6df45181bce749404419c2d9925f09b72e5.1717067519.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org From: Piotr Pietruszewski This reverts the following commit: 13de2444449e ("net/ixgbe/base: remove default advertising for x550 2.5G/5G") The commit removing advertising 2.5G and 5G speeds from ixgbe_get_copper_speeds_supported() was supposed to disable 2.5G and 5G during the autonegotiation with default settings. However, that change prevented OS-specific part of the driver from forcing these speeds at user request. This change reverts the commit and adds 2.5G and 5G as speeds supported by the X550. Cc: stable@dpdk.org Signed-off-by: Piotr Pietruszewski Reviewed-by: Skajewski, PiotrX Reviewed-by: Marek Mical Reviewed-by: Kirsher, Jeffrey T Reviewed-by: Michael, Alice --- drivers/net/ixgbe/base/ixgbe_phy.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ixgbe/base/ixgbe_phy.c b/drivers/net/ixgbe/base/ixgbe_phy.c index 74c5db16fa..3a8e603472 100644 --- a/drivers/net/ixgbe/base/ixgbe_phy.c +++ b/drivers/net/ixgbe/base/ixgbe_phy.c @@ -915,6 +915,10 @@ static s32 ixgbe_get_copper_speeds_supported(struct ixgbe_hw *hw) hw->phy.speeds_supported |= IXGBE_LINK_SPEED_100_FULL; switch (hw->mac.type) { + case ixgbe_mac_X550: + hw->phy.speeds_supported |= IXGBE_LINK_SPEED_2_5GB_FULL; + hw->phy.speeds_supported |= IXGBE_LINK_SPEED_5GB_FULL; + break; case ixgbe_mac_X550EM_x: case ixgbe_mac_X550EM_a: hw->phy.speeds_supported &= ~IXGBE_LINK_SPEED_100_FULL; -- 2.43.0