From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B526A0A0F for ; Wed, 30 Jun 2021 09:47:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1AF1B40141; Wed, 30 Jun 2021 09:47:14 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A346741248 for ; Wed, 30 Jun 2021 09:47:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625039232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kW0UrdzdSWat7o8soc26IybL67ImjfYACokbZ42ukQY=; b=G8wBTBJR4Gs7k5ct1QohKSlirYBukcqmXapQQ9v4hVnw0nDiSMkZgj7TZeXz9khiyipOb0 QM7JCDCtaM9S206MY6wLuH6vK1XWy+I2n6Aw1r/Hl4htF/n/rfvXG24oXry8NnLe4p2Ozb wA9NRSkKAisSVOL3WKosK+LM/0fy6WY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-570-cGQ7fqJ_NOW7zfjHmVvhQw-1; Wed, 30 Jun 2021 03:47:08 -0400 X-MC-Unique: cGQ7fqJ_NOW7zfjHmVvhQw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A30E5A0CB0; Wed, 30 Jun 2021 07:47:07 +0000 (UTC) Received: from [10.36.110.32] (unknown [10.36.110.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0CE5A60862; Wed, 30 Jun 2021 07:47:02 +0000 (UTC) To: David Marchand Cc: dev , "Xia, Chenbo" , dpdk stable References: <20210629161133.79472-1-maxime.coquelin@redhat.com> <20210629161133.79472-5-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <12310388-bdb4-7abf-275a-f66356e200d3@redhat.com> Date: Wed, 30 Jun 2021 09:47:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [PATCH v7 4/7] vhost: fix NUMA reallocation with multiqueue X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 6/30/21 9:24 AM, David Marchand wrote: > On Tue, Jun 29, 2021 at 6:11 PM Maxime Coquelin > wrote: >> >> Since the Vhost-user device initialization has been reworked, >> enabling the application to start using the device as soon as >> the first queue pair is ready, NUMA reallocation no more >> happened on queue pairs other than the first one since >> numa_realloc() was returning early if the device was running. >> >> This patch fixes this issue by only preventing the device >> metadata to be allocated if the device is running. For the > > Hum, I understand the meaning, but I think we could make it easier to read: > > This patch fixes this issue by reallocating the device metadata only > if the device is not running. > > WDYT? It sounds better, I can be changed while applying if only issue. >> virtqueues, a vring state change notification is sent to >> notify the application of its disablement. Since the callback >> is supposed to be blocking, it is safe to reallocate it >> afterwards. > >