From: Thomas Monjalon <thomas@monjalon.net> To: "583493798@qq.com" <583493798@qq.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "Burakov, Anatoly" <anatoly.burakov@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, aconole@redhat.com, stable@dpdk.org Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] ip_frag: fix fragmenting ipv4 packet with header option Date: Wed, 21 Apr 2021 16:50:44 +0200 Message-ID: <134920770.HdkG1kHLkd@thomas> (raw) In-Reply-To: <DM6PR11MB4491E247A32CA6A87E548D5E9A769@DM6PR11MB4491.namprd11.prod.outlook.com> > > From: Pu Xu <583493798@qq.com> > > > > When fragmenting ipv4 packet, the data offset should be calculated through > > the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr). > > > > Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper library") + Cc: stable@dpdk.org > > Signed-off-by: Pu Xu <583493798@qq.com> > > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> As asked by Aaron, an unit test would be good, but in this case (after discussion) it won't block the fix to be merged. Applied, thanks
prev parent reply other threads:[~2021-04-21 14:50 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-01 16:16 [dpdk-stable] [PATCH] " Pu Xu [not found] ` <tencent_8FA596830F4F89E9E2169503B40DF0FF0307@qq.com> [not found] ` <DM6PR11MB4491E247A32CA6A87E548D5E9A769@DM6PR11MB4491.namprd11.prod.outlook.com> 2021-04-21 14:50 ` Thomas Monjalon [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=134920770.HdkG1kHLkd@thomas \ --to=thomas@monjalon.net \ --cc=583493798@qq.com \ --cc=aconole@redhat.com \ --cc=anatoly.burakov@intel.com \ --cc=dev@dpdk.org \ --cc=konstantin.ananyev@intel.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
patches for DPDK stable branches This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \ stable@dpdk.org public-inbox-index stable Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.stable AGPL code for this site: git clone https://public-inbox.org/public-inbox.git