patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <>
To: "" <>
Cc: "" <>,
	"Burakov, Anatoly" <>,
	"Ananyev, Konstantin" <>,,
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] ip_frag: fix fragmenting ipv4 packet with header option
Date: Wed, 21 Apr 2021 16:50:44 +0200	[thread overview]
Message-ID: <134920770.HdkG1kHLkd@thomas> (raw)
In-Reply-To: <>

> > From: Pu Xu <>
> > 
> > When fragmenting ipv4 packet, the data offset should be calculated through
> > the ihl field in ip header rather than using sizeof(struct rte_ipv4_hdr).
> > 
> > Fixes: 4c38e5532a07 ("ip_frag: refactor IPv4 fragmentation into a proper library")

+ Cc:

> > Signed-off-by: Pu Xu <>
> Acked-by: Konstantin Ananyev <>

As asked by Aaron, an unit test would be good,
but in this case (after discussion) it won't block the fix to be merged.

Applied, thanks

      parent reply	other threads:[~2021-04-21 14:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-01 16:16 [dpdk-stable] [PATCH] " Pu Xu
     [not found] ` <>
     [not found]   ` <>
2021-04-21 14:50     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=134920770.HdkG1kHLkd@thomas \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).