From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 436F2A0096 for ; Tue, 4 Jun 2019 01:11:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DEA231B9BC; Tue, 4 Jun 2019 01:11:33 +0200 (CEST) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by dpdk.org (Postfix) with ESMTP id 7DCA11B9A4; Tue, 4 Jun 2019 01:11:30 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 0A667DE7; Mon, 3 Jun 2019 19:11:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 03 Jun 2019 19:11:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=eQL+Brv4YtvjMLr3lI46n7DuuQB4K/G/dm2YQTLfE4A=; b=e3tzEiBh5TO+ EP3bgXLFCIzzz7rYNb49xts1AxkPzzLHTZl8imlvSectEJq1fs121+iNvEaSQphh BvS5OqCwmKMNnGJNhreE6SuM/pnH9KKcFlLAzXm6M5CaRcqLypGACCD/jbA8RaZK rw42ZufviNxX1uC1q1BA0QCq2lDEiOY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=eQL+Brv4YtvjMLr3lI46n7DuuQB4K/G/dm2YQTLfE 4A=; b=BiKTDPK37G9Jc0mZJFEhJRmTsCPHxWhr1ewzX5p5dliZ9dN9c1tCKcQVH IfzF5YzY2OsrT6ET0P+ccLMSjsOwefVWZ+rYe7weaO1tu3L0kpgrO+WY5dVDEDxQ N3ISd11mcxwVF3u2DPkJbg01VtkLDEuejSyt1/scVnYH4lz82WXFCak0rCo7iBtc MXTiLsFadKdAFJeJ+Hf+OXgVjA8kBw9ZAqDX3r3rxt/takWE2zoY0Pg0WpG+PyrY GrHcGNw+aWpdSF+WwRYyw2SqcOH+iAxpcPsKper3DIvaycZ5WmdV7/ugaLVy+CF4 Kz+fgaF7CEA0dq7x6w/urB3f8qIIg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudefkedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 63EB2380083; Mon, 3 Jun 2019 19:11:27 -0400 (EDT) From: Thomas Monjalon To: "yskoh@mellanox.com" Cc: dev@dpdk.org, Honnappa Nagarahalli , "jerinj@marvell.com" , "bruce.richardson@intel.com" , "pbhagavatula@marvell.com" , "shahafs@mellanox.com" , "Gavin Hu (Arm Technology China)" , "stable@dpdk.org" , Dharmik Thakkar , nd Date: Tue, 04 Jun 2019 01:11:26 +0200 Message-ID: <14058418.BnuyAWlf4k@xps> In-Reply-To: References: <20190502015806.41497-1-yskoh@mellanox.com> <20190507211140.43569-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3] build: disable armv8 crypto extension X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 13/05/2019 21:26, Honnappa Nagarahalli: > > > > Per armv8 crypto extension support, make build always enable it by default as > > long as compiler supports the feature while meson build only enables it for > > 'default' machine of generic armv8 architecture. > > > > It is known that not all the armv8 platforms have the crypto extension. For > > example, Mellanox BlueField has a variant which doesn't have it. If crypto > > enabled binary runs on such a platform, rte_eal_init() fails. > > > > '+crypto' flag currently implies only '+aes' and '+sha2' and enabling it will > > generate the crypto instructions only when crypto intrinsics are used. > > For the devices supporting 8.2 crypto or newer, compiler could generate such > > instructions beyond intrinsics or asm code. For example, compiler can generate > > 3-way exclusive OR instructions if sha3 is supported. However, it has to be > > enabled by adding '+sha3' as of today. > > > > In DPDK, armv8 cryptodev is the only one which requires the crypto support. > > As it even uses external library of Marvell which is compiled out of DPDK with > > crypto support and there's run-time check for required cpuflags, crypto > > support can be disabled in DPDK. > > > > Cc: stable@dpdk.org > > > > Signed-off-by: Yongseok Koh > > Acked-by: Jerin Jacob > > Tested-by: Dharmik Thakkar > > Reviewed-by: Honnappa Nagarahalli Applied, thanks