The following header files weren't being installed by meson: - rte_vfio.h - rte_function_versioning.h - rte_test.h This patch adds them to the common_headers list so that they are installed. Fixes: 610beca42ea4 ("build: remove library special cases") Cc: bruce.richardson@intel.com Cc: stable@dpdk.org Signed-off-by: Ali Alnubani <alialnu@mellanox.com> Reviewed-by: Thomas Monjalon <thomas@monjalon.net> Acked-by: Bruce Richardson <bruce.richardson@intel.com> --- v2: updated commit title and added a fixes tag. lib/librte_eal/common/meson.build | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build index d6a149bec..71d0c50ce 100644 --- a/lib/librte_eal/common/meson.build +++ b/lib/librte_eal/common/meson.build @@ -64,6 +64,7 @@ common_headers = files( 'include/rte_eal_interrupts.h', 'include/rte_errno.h', 'include/rte_fbarray.h', + 'include/rte_function_versioning.h', 'include/rte_hexdump.h', 'include/rte_hypervisor.h', 'include/rte_interrupts.h', @@ -84,9 +85,11 @@ common_headers = files( 'include/rte_service_component.h', 'include/rte_string_fns.h', 'include/rte_tailq.h', + 'include/rte_test.h', 'include/rte_time.h', 'include/rte_uuid.h', - 'include/rte_version.h') + 'include/rte_version.h', + 'include/rte_vfio.h') # special case install the generic headers, since they go in a subdir generic_headers = files( -- 2.24.0
26/11/2019 11:51, Ali Alnubani: > The following header files weren't being installed by meson: > - rte_vfio.h > - rte_function_versioning.h > - rte_test.h > > This patch adds them to the common_headers list so that > they are installed. > > Fixes: 610beca42ea4 ("build: remove library special cases") I am not sure this is the right root cause. At least for rte_function_versioning.h, it has been added recently. > Cc: bruce.richardson@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Ali Alnubani <alialnu@mellanox.com> > Reviewed-by: Thomas Monjalon <thomas@monjalon.net> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
On Tue, Nov 26, 2019 at 12:17:41PM +0100, Thomas Monjalon wrote: > 26/11/2019 11:51, Ali Alnubani: > > The following header files weren't being installed by meson: > > - rte_vfio.h > > - rte_function_versioning.h > > - rte_test.h > > > > This patch adds them to the common_headers list so that > > they are installed. > > > > Fixes: 610beca42ea4 ("build: remove library special cases") > > I am not sure this is the right root cause. > At least for rte_function_versioning.h, it has been added recently. > Thanks for pointing this out. The rte_function_versioning.h file I deliberately omitted from the meson install since it's really for internal use only. It's not really recommended for external app use, since it relies on some DPDK defines etc. > > Cc: bruce.richardson@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Ali Alnubani <alialnu@mellanox.com> > > Reviewed-by: Thomas Monjalon <thomas@monjalon.net> > > Acked-by: Bruce Richardson <bruce.richardson@intel.com> > > >
The header file 'rte_vfio.h' might be required by some external apps. This patch adds it to the list of common_headers so that it's installed by meson. Fixes: 610beca42ea4 ("build: remove library special cases") Cc: bruce.richardson@intel.com Cc: stable@dpdk.org Signed-off-by: Ali Alnubani <alialnu@mellanox.com> Reviewed-by: Thomas Monjalon <thomas@monjalon.net> Acked-by: Bruce Richardson <bruce.richardson@intel.com> --- v2: updated commit title and added a fixes tag. v3: removed rte_test.h and rte_function_versioning.h. lib/librte_eal/common/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build index d6a149bec..2b97715a2 100644 --- a/lib/librte_eal/common/meson.build +++ b/lib/librte_eal/common/meson.build @@ -86,7 +86,8 @@ common_headers = files( 'include/rte_tailq.h', 'include/rte_time.h', 'include/rte_uuid.h', - 'include/rte_version.h') + 'include/rte_version.h', + 'include/rte_vfio.h') # special case install the generic headers, since they go in a subdir generic_headers = files( -- 2.24.0
26/11/2019 16:38, Ali Alnubani:
> The header file 'rte_vfio.h' might be required by some external apps.
> This patch adds it to the list of common_headers so that it's
> installed by meson.
>
> Fixes: 610beca42ea4 ("build: remove library special cases")
> Cc: bruce.richardson@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks