From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30084.outbound.protection.outlook.com [40.107.3.84]) by dpdk.org (Postfix) with ESMTP id 40D3C1B40C for ; Mon, 5 Feb 2018 17:00:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mj7p5fMD68lfl9UktknwMu8gvtG7JKjT5/mBGunWO0k=; b=LeDNwpGBuAI05MSvLvQyRhPw8Q20VB1IiOneWDrg4o7bTtu6Tx7RqQukVvpgyFuTETPaZxXTgZK/zpQM2wAKq7oSKVx8y09xqKv6tJ3Ne7DGzdMRBqtn9v3v2rA6lskScgU7GHDtw/tG+6XtU/wbAKCRMjWRUZVkJDhdgPWVWXk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ophirmu@mellanox.com; Received: from mellanox.com (37.142.13.130) by AM6PR0502MB3878.eurprd05.prod.outlook.com (2603:10a6:209:b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Mon, 5 Feb 2018 16:00:42 +0000 From: Ophir Munk To: Ophir Munk Cc: stable@dpdk.org Date: Mon, 5 Feb 2018 16:00:34 +0000 Message-Id: <1517846434-568-1-git-send-email-ophirmu@mellanox.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: HE1PR0102CA0053.eurprd01.prod.exchangelabs.com (2603:10a6:7:7d::30) To AM6PR0502MB3878.eurprd05.prod.outlook.com (2603:10a6:209:b::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 7a4a3a86-2de3-436a-ec94-08d56cb19c3e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:AM6PR0502MB3878; X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3878; 3:92ljHirkcECCtK+fS2Ch2+DmsuUM1iaqiEbmC1jmqmrkECKoHAkYvdO1/TNhTxKVR73QnSfSd4bz8Db05NalglOpNeEf07d2J6BYkds9vH/LmbWbzDuOmjdDA3IoAzBNF1Ub5Itgoh/+FFFBbX34eESin4XueYUO3+Gw9CZ7xWz0JGWwrqeBtl4WuwT77/To4wg52O6SAvu/oYsTw2fDGcdwh0PyU5rrwBlWZoV3Wv26t6Msc3ToECuFbx/fnNg2; 25:aWiMYD4R4+J1ZssSnp8F1fgMl0JQzEpHNJVM/VCtXaLm9vdaEJrbBOeIgiXpy/Kl+w+wXtsI7bc+IKPF+5cS364jCwku7xNZ6DBrGHmEWqOS6fy7zi6qXAQB+kMQPF/x+H1WVDxojzHptOCBcwKqLCs4oOiPICONlBUtlE9pozWydKDfMmJ3SnVzlibnt+mC2LRUBu9n+LNtQEL0u0YSqLdP67C83JcakXUomD3B7F/zXAxi1/6Insoyy8ezHliwpCQE8lQvvpeBSbv/1c9NgowUGTzliD4Qij85FtmUJn5ykBqj3GvLt3uupjmQFbLhMKHKoTq5lM5uEa1HUp3nag==; 31:fB53U/u9fTi4ZiXllj2eacmD2u5Q+XfRjGg8rlBPjROQAvYZ7g4BpxmRLCguV4LROYw7b7wLJGVkQh3YdTpSRLq1CHbhQF3X49bMRq3ldmAacZuwan9OIv66lSKGAGgqOllYFnfFm+UNH++frO0rQsg2rBzGdozCkZUfYY5cbX/YIuLyJyw/dn0l5qBfMoeTGTkecQAfyueq/WAgoBoJkXoQQTcqv+P2RHR0AquwJQk= X-MS-TrafficTypeDiagnostic: AM6PR0502MB3878: X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3878; 20:Ck9ZduwSpmqHhxAWXzk9/WtMyq6FqjI65G98+PTOsYdfx4Cv5GvGDDy1pOecuYxagXsG1sWEmrxpql84rqisHeebSvBqi/51yshkbRhKXYuZI4ONy6vT8dqC5r27OX9zjU2eebYa0/U3gqmLT3/pRjUYg8E4UGNpFjosjJxcrxVsEuJni0u4yMJNqnk/Upkcor7KG5n9Yz4BDd0S76X8fGQPxw/xlUAPIXbTx9xntSPeDhymSn+TzAZAs/1SOdFyOjK1ZznqGLu9D+QXvmuZHzWJk0PTnG++JQnkSPUWsUWGYMuWYk2WtkATkPkwlxjejvo5gp89kH0wg48dfxJ+KOca4aqyF93fAZe2WbrpDFbVrc5Jz47D8WrHgDIcXaw7q9tQ2rU9bHIyDl94L6hsKEP5SI7kW4KCL38/p4686Z4mySq9sxtknJG9HWL4w4NnfrQ5GvdkU/PklBhQszr3iB2NGE0aS0n47Aa+ICwyA+5JiBCKNtbUYkZrFH2qVueZ; 4:fPgzHUloiv7oqcKFQDMdjMDh7RuBLLnMIXwLlR0cXgD5HuDFVeJKM7w9Q+fzPfHsA51HZDXjRG8pQC5weOg6HaeYDgit1XnZ0XSOT8P/z33T1Dm10zpXXyTs4SfrCdhRLlrqZfG7fLru1Q2vVYxouvjbJH+Ym6LknXy17WGTsYoYdtNv9kN1sFMG0/sZsm3g39BvN0O3G07JrNWH/MHrkZjamND0WsQ7d7jKOZxrKib09+mg7ZfGwqV1Vww6QLi1FHvRIjN6zEGWY4EOgAL59w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231101)(2400082)(944501161)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(20161123560045)(6072148)(201708071742011); SRVR:AM6PR0502MB3878; BCL:0; PCL:0; RULEID:; SRVR:AM6PR0502MB3878; X-Forefront-PRVS: 0574D4712B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39380400002)(39860400002)(346002)(396003)(376002)(189003)(199004)(52116002)(6862004)(7736002)(36756003)(97736004)(305945005)(5660300001)(105586002)(26005)(86362001)(33026002)(7049001)(478600001)(16526019)(69596002)(47776003)(66066001)(316002)(106356001)(16586007)(50466002)(37006003)(81156014)(8936002)(55016002)(8676002)(2906002)(48376002)(6200100001)(81166006)(3846002)(6116002)(53936002)(25786009)(21086003)(4720700003)(386003)(68736007)(4326008)(51416003)(6666003)(59450400001)(7696005)(50226002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0502MB3878; H:mellanox.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM6PR0502MB3878; 23:LEifu/mMl44DtogHC0IdwZ9QpXs9TY8EptzifYN?= =?us-ascii?Q?Z49mdSfVbPYcYBRUPy+/4hhHbpnUjUSxaGbvJ9YW0L0NQ4BmpoKSdbt8c503?= =?us-ascii?Q?RKtaXY6F1BUK5p7g829IUJXFYzbkRLqqRonsqIXPTwZjJDCtWC5EN7V9Tf7g?= =?us-ascii?Q?2Qmy8ujLwPmEgs9jFYDpDdKx/A+Z9NV8dR6sj7Mz7DXi/0mD5Rea5F0ITNrC?= =?us-ascii?Q?D38F9njRrXc98aEgYsg/qzgdd9BEJHqU1cO7UY05qNwOOh2ydc8dZUlmuY6E?= =?us-ascii?Q?XLgyfEFe2jmrLmr5yH9AtjSILcHl7Py24T5Id9JnNDwcOgP/zkIyT8iEtkqJ?= =?us-ascii?Q?xby2xrtFItkKc6rOo9AhwtAR/pdl+BTBVBnCo2PGjwGE4zWn01pra9X81ny+?= =?us-ascii?Q?WeoQcTFDV3CXP98tL79FTdPJ5eMDIz/MnkUVPMLOwz8SAtI+pSM+ZIbIpNCP?= =?us-ascii?Q?cdl9d3pyuEh8b5f2MvwsdJ3qKhDxVRi+gZMPHsoV00gpPL+Tj9D8qNC/OGQG?= =?us-ascii?Q?FKKQmtuqMsuRFs8tj4YXfeCME40hFch/PNUlqF09re28XiJHV36A+mzqUF01?= =?us-ascii?Q?xEgTY6gqUbdEmafjgk2DVlngFscf9j8n/IrEGHU+aDtFxdmjIfwQl2Hou/2p?= =?us-ascii?Q?MxdUyEUSxKsByqnwxymBR2jYKhKX9LcOggrjp8KwNaCZvQtPd7mbKy/kBUYd?= =?us-ascii?Q?jeEtSg9MM72jTIl8xJMi4IRGioVQLIrLutRSi9rb9Om2n5Gq6TcB/TxIMCun?= =?us-ascii?Q?MI57yVOtjKVD0u2swH57pquC7IquFxlsTd6S3va57Hr09rpuh2DOulgFuocn?= =?us-ascii?Q?bHghDYsuni9Vevtdd9H/UAaz7SE6MVgy5amzoRRrKFGOvwKgM4ux3ZvDvZVn?= =?us-ascii?Q?FXta3Qy4q56C3VhaC0T6S7JZqriCS3MJOa5xaXOB7czJuLK5ZKHRJF7HFaSy?= =?us-ascii?Q?R/AFDyXSfDdX6cJF0xlCdYHUHX5fqLlu0z8P5qxMLUwTG/qVAIgRZWqdA34H?= =?us-ascii?Q?tUK7cWYeO4bWQHBHQIm2QigWP2DLbbB3ZEBornuHEJddArButaXVioJHWLMi?= =?us-ascii?Q?pV8DnaDRm37E5/IVXDpIMAB1PauvSLTOklMyBKn3ObUKUpeuRJ+cr/cNCd3r?= =?us-ascii?Q?TjvipjwqHJpsBE4G5gP6byPqFAnQKQuIQFQucouAvKGSrSXlfwKWvGen8voN?= =?us-ascii?Q?MwQ70GXbylcc/exDBiOGbxdhrxudNX5cZxhhz?= X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3878; 6:L6tNteDg7VaVz2jQ/CZjs9VNdM+r8GjxSgS2azkDdeRYrYl+dpgWmy3EflgeeEk3TpSkWm7/7RSmioBm+/UEjYWonOxJgAZgue+R29TXTXn6nvjR9jo/cq4iRG2jT5+yIp/F9AKKqXlyfVhfOymlbdzdncLGjmbC2my25Y9iW01VsBaqe1Apu8tcoaMVAAO+ld6qwlkd0swwHhO3Fzmsd6RCjyfWRHF6ShKzIyqS+Mdwidxu4k0kcHyrHbunxkihzMIP4ge2evXXlebwxcOLAuN/PwwFOSUsDgm1NiBVOMIuXCcRhYIupfmajxnDWg2e55znTzjxVARxs8E3/NtMYokGGnJDKN4absFqQRuIsZ4=; 5:W+u8tU+/rXD9hCP7a2CIfPIp3NET7lISkccimcbzye4m5JmJ1t8qq4HIIzddIRTa85tBR2uTn1wWFDhTlO0FIqXAYxPjTrwAhitWjvNKghpLMsGIv4zHjrf4LUcV3dP8RxABQESjoXFKAWFGhgOl/vt0EIJsbrjtLIXY6fexT8I=; 24:OGn4SArfmSoqtqprC/JubbZz0qwl8rJe4vUNjJAsouwvpDeD489CnbcTfhIvdiL8Y0PNLeYet1XaogiUYbzi/PgO07dRw0mKNZ9RfkulntQ=; 7:jK+wV2g/Hv2J9fjU9IfNYgfHjI7x8ZxEmMdcr9rADqM12gBtBC5KoDcofHs///GeXLND4hjr4dgEbf6VbokmdgKMIxteHFtBXz+4+/HSBiC6LCoSBvURLJ8WVZkSLGS2/4mCvVajVTbXiN14F+fRbkG7o3hJbTkoE5019qgNZA2UX8FF2wrZN0vx6gmksDvcN4eU5zAmzGKc7mroi9fXBqjsd8zcXwxRjNUb2FuX+OjUII86tes5EdIRTBuJm7mD SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2018 16:00:42.2923 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7a4a3a86-2de3-436a-ec94-08d56cb19c3e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0502MB3878 Subject: [dpdk-stable] [PATCH v1] net/failsafe: fix default Tx offloads capabilities X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 16:00:44 -0000 Failsafe reported Tx offloads capabilities are the AND result of its default capabilities and those of its sub-devices. In the corrupted code failsafe default Tx capabilities were set to 0. As a result when running testpmd with "--tx-offloads=0x8000" parameter (request for multi segments offload) - an error was returned: PMD: net_failsafe: Some Tx offloads are not supported, requested 0x8000 supported 0x0 To fix this, failsafe default Tx offload capabilities are set to DEV_TX_OFFLOAD_MULTI_SEGS | DEV_TX_OFFLOAD_IPV4_CKSUM | DEV_TX_OFFLOAD_UDP_CKSUM | DEV_TX_OFFLOAD_TCP_CKSUM, Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") Cc: stable@dpdk.org Signed-off-by: Ophir Munk --- drivers/net/failsafe/failsafe_ops.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c index e7bb801..7a67e16 100644 --- a/drivers/net/failsafe/failsafe_ops.c +++ b/drivers/net/failsafe/failsafe_ops.c @@ -77,7 +77,11 @@ static struct rte_eth_dev_info default_infos = { DEV_RX_OFFLOAD_SCATTER | DEV_RX_OFFLOAD_TIMESTAMP | DEV_RX_OFFLOAD_SECURITY, - .tx_offload_capa = 0x0, + .tx_offload_capa = + DEV_TX_OFFLOAD_MULTI_SEGS | + DEV_TX_OFFLOAD_IPV4_CKSUM | + DEV_TX_OFFLOAD_UDP_CKSUM | + DEV_TX_OFFLOAD_TCP_CKSUM, .flow_type_rss_offloads = 0x0, }; -- 2.7.4