From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 28FED1B799 for ; Wed, 7 Feb 2018 09:59:55 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D4FF120C94; Wed, 7 Feb 2018 03:59:54 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 07 Feb 2018 03:59:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=GDxAKewdaCjGro/Lj UVLvWRZyZr3f/6kqEKM2C2MnEs=; b=FMhsujQxaXMJW77Rtfmldu3GJs0rk6MeO y+lBOn+FWXJnvy+Td95qJtSGgKYTLBroNwu3sWUj0gPSOnhYB2b8K1EpzaivfYq3 OE5qEeaB3HCv2vmiktWGUNH+QVb0F9zl5x7YRb/z00XD4H3qIkqwtQoouMWwNduc WVl44Z1Fua7bR6U+3H+ua0a7LEs8GhdtUWCk9Vfn10YD1w/lj76zbEv1mUsUV8jQ 9556xWZehjiQ3avRe8YPePMt6mdGpAjsqbbuYEDXzoy1VsIflodW+7jfWPy/mnXT 5dmwOjMaXBlwy8SQi8V/saRpDGafq5vyEtbWjek4wlfR/2PQGfu4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=GDxAKewdaCjGro/LjUVLvWRZyZr3f/6kqEKM2C2MnEs=; b=AEqo2KIU yLPoE/3mJFXLui2Cbjd6MiJxAc+sOm1fbyKJuD20o7UcUrytJfpP6krYA+qdC+1y wkTOOpiYXQth84SazUoGxAUu++7IHj0g3T1gRnhRUf6DuyHnioL2M04XYdhzrMsX KtZsDatQpeIoA+1GY9aPqzYGdhjonGHhG12B+iTT8D2nFYddryZ8TSLSJS1t3O31 CQIgdShfDystoQFp4PAnVT/gUdbhLorYJQldOHgskVig2wXSg2P8xtt0a/edKQJk PjJtXSwv93VhGJ5spj2yezJuPhFr2A9x2K3xdHBGlQHg0IMlAJao/Dg4ISkrRCFa FtqvCbVrn+l0rA== X-ME-Sender: Received: from localhost.localdomain (unknown [182.84.161.100]) by mail.messagingengine.com (Postfix) with ESMTPA id 559C924636; Wed, 7 Feb 2018 03:59:53 -0500 (EST) From: Yuanhan Liu To: Matan Azrad Cc: dpdk stable Date: Wed, 7 Feb 2018 16:57:07 +0800 Message-Id: <1517993838-26692-13-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1517993838-26692-1-git-send-email-yliu@fridaylinux.org> References: <1517993838-26692-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'app/testpmd: fix port index in RSS forward config' has been queued to LTS release 17.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 08:59:55 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/09/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 1e1f3b9152ec37b541bb6c243e2c9f8d5546c5ac Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Mon, 5 Feb 2018 14:09:21 +0000 Subject: [PATCH] app/testpmd: fix port index in RSS forward config [ upstream commit 13cb6fae7991e2213cf8ce39fe3caa1c804511e1 ] When multi-queue ports are configured by the user, the testpmd streams are created by rss_fwd_config_setup() function. This function may configure to the streams either invalid Rx ports or invalid Tx ports. An invalid Tx port is configured when the number of ports is odd. In this case, the last Tx port will be always invalid. An invalid Rx port is configured when NUMA support is configured by the user and the number of forward ports is much smaller than the number of all ports. In this case, also the Tx port is invalid. Change calculations to get valid ports. Fixes: af75078 ("first public release") Signed-off-by: Matan Azrad --- app/test-pmd/config.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 726c737..24451fc 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1983,7 +1983,8 @@ rss_fwd_config_setup(void) * if we are in loopback, simply send stuff out through the * ingress port */ - if (port_topology == PORT_TOPOLOGY_LOOP) + if (port_topology == PORT_TOPOLOGY_LOOP || + txp >= cur_fwd_config.nb_fwd_ports) txp = rxp; fs->rx_port = fwd_ports_ids[rxp]; @@ -2000,11 +2001,7 @@ rss_fwd_config_setup(void) * Restart from RX queue 0 on next RX port */ rxq = 0; - if (numa_support && (nb_fwd_ports <= (nb_ports >> 1))) - rxp = (portid_t) - (rxp + ((nb_ports >> 1) / nb_fwd_ports)); - else - rxp = (portid_t) (rxp + 1); + rxp++; } } -- 2.7.4