From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 6D2011B79A for ; Wed, 7 Feb 2018 09:59:37 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 256B520CAF; Wed, 7 Feb 2018 03:59:37 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 07 Feb 2018 03:59:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux.org; h=cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=HpmrQU/SQDFFjEaML o7n2s7ZjV1Lm6FlkdKn3Wp+Uuw=; b=YxkLkamA14oIo4x5c13SZlq8iOX6SxYsc H8RW9ZZZehUXbPbs/YQ1U5zwdtSSWzIIfV3N7QugVZehhb27j7TftYV2gHi6aIpn TjWXPcho/Qp8H17jZzwReH0icPRyDoZONzmjQiIiNKQEgrr0O6klNeLt4/GbyRfi EDGeXy+vPAc8Qex3+ET0g0LVzhaDivCcq7JyvfAzN0KmqwvI3tlMZdvHiYGAIgKp Zq62x1vZR/tsGUQazo4rgPTj710cCwlAkAuNrHRTp3GMIw01GtqPGRo91tTWwtOg 66+B7KkN8alV6olJ2dAI/AyPATiX+jwUxCBwZEFr+avoQr+eWcPlA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=HpmrQU/SQDFFjEaMLo7n2s7ZjV1Lm6FlkdKn3Wp+Uuw=; b=XIhHo0c9 8l+BU/7CQOyMPE0FyfPBGzayoPhbM+KIOWDYmJE8aicCe6ryNRKBumxrxa4MWpvA xKBC6CUpZcUv5+pvZAE+2i+JpA6ZG5BGrSi8izD0pNqcvEhu+14/Evsy0nPK2SIY gDGVSEHKJJ4h4XKbcDUxIm4aGILCPIWlE4KfCOkKx/7kLQbKzjjQL1kaX/nk8dMa 8ay6lZTYLJKbYv3ql1QHQrEzEsr563Y1rF1Sx4SRfN8x3xjDiRnkfQlhZc/fOzr2 zVWrExA4RQ+g/LkyBWveX0Xb2voXHrc9I+eh/zm79OjzadOlA+xnNAYWD0T4UtSH DIyRir0cc/JGKg== X-ME-Sender: Received: from localhost.localdomain (unknown [182.84.161.100]) by mail.messagingengine.com (Postfix) with ESMTPA id 8F27624636; Wed, 7 Feb 2018 03:59:34 -0500 (EST) From: Yuanhan Liu To: Radu Nicolau Cc: dpdk stable Date: Wed, 7 Feb 2018 16:57:00 +0800 Message-Id: <1517993838-26692-6-git-send-email-yliu@fridaylinux.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1517993838-26692-1-git-send-email-yliu@fridaylinux.org> References: <1517993838-26692-1-git-send-email-yliu@fridaylinux.org> Subject: [dpdk-stable] patch 'net/bonding: check error of MAC address setting' has been queued to LTS release 17.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 08:59:37 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/09/18. So please shout if anyone has objections. Thanks. --yliu --- >>From 47961e7d6117710f9fd5cc682f870ea1b84894fb Mon Sep 17 00:00:00 2001 From: Radu Nicolau Date: Thu, 1 Feb 2018 17:21:26 +0000 Subject: [PATCH] net/bonding: check error of MAC address setting [ upstream commit a508daa1a43491ef347774852fe9ee3ff960182c ] Coverity issue: 260405 Fixes: 2efb58cbab6e ("bond: new link bonding library") Signed-off-by: Radu Nicolau --- drivers/net/bonding/rte_eth_bond_api.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_api.c b/drivers/net/bonding/rte_eth_bond_api.c index 532683b..b834035 100644 --- a/drivers/net/bonding/rte_eth_bond_api.c +++ b/drivers/net/bonding/rte_eth_bond_api.c @@ -291,8 +291,13 @@ __eth_bond_slave_add_lock_free(uint16_t bonded_port_id, uint16_t slave_port_id) if (internals->slave_count < 1) { /* if MAC is not user defined then use MAC of first slave add to * bonded device */ - if (!internals->user_defined_mac) - mac_address_set(bonded_eth_dev, slave_eth_dev->data->mac_addrs); + if (!internals->user_defined_mac) { + if (mac_address_set(bonded_eth_dev, + slave_eth_dev->data->mac_addrs)) { + RTE_BOND_LOG(ERR, "Failed to set MAC address"); + return -1; + } + } /* Inherit eth dev link properties from first slave */ link_properties_set(bonded_eth_dev, -- 2.7.4