From: Luca Boccassi <bluca@debian.org>
To: Rasesh Mody <rasesh.mody@cavium.com>, stable@dpdk.org
Cc: Harish Patil <harish.patil@cavium.com>
Subject: Re: [dpdk-stable] [PATCH 1/2] net/qede: fix MTU set and max Rx pkt len usage
Date: Mon, 26 Feb 2018 11:00:01 +0000 [thread overview]
Message-ID: <1519642801.22753.21.camel@debian.org> (raw)
In-Reply-To: <1519622173-14087-1-git-send-email-rasesh.mody@cavium.com>
On Sun, 2018-02-25 at 21:16 -0800, Rasesh Mody wrote:
> [ backported from upstream commit
> 9e334305178fd3715c17088632544bf58e5836a9 ]
> [ backported from upstream commit
> 1ef4c3a5c1f76b810620b76d82a31ce33a83d3fe ]
> [ backported from upstream commit
> f6033f2497e7d01d8c6f0d691e2f86937597aa35 ]
>
> This patch fixes issues related to MTU set and max_rx_pkt_len usage.
> - Adjust MTU during device configuration when jumbo is enabled
>
> - In qede_set_mtu():
> Return not supported for VF as currently we do not support it.
>
> Add check for RXQ allocation before calculating RX buffer size
> if not allocated defer RX buffer size calculation till RXQ setup.
>
> Add check for before performing device start/stop.
>
> - Use max_rx_pkt_len appropriately
>
> - Change QEDE_ETH_OVERHEAD macro to adjust driver specifics
>
> - The driver can handle dynamic MTU change without needing the port
> to be
> stopped explicitly by the application. However, there is
> currently no
> check to prevent I/Os from happening on a different thread while
> the
> port is going thru' reset internally. This patch fixes this issue
> by
> assigning RX/TX burst functions to a dummy function and also
> reconfigure
> RX bufsize for each rx queue based on the new MTU value.
>
> - Fix minimum RX buffer size to 1024B
>
> - Force enable scatter/gather mode if given RX buf size is lesser
> than MTU
>
> - Adjust RX buffer size to cache-line size with overhead included
>
> Fixes: bec0228816c0 ("net/qede: support scatter gather")
> Fixes: 2ea6f76aff40 ("qede: add core driver")
>
> Signed-off-by: Harish Patil <harish.patil@cavium.com>
> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
> ---
Thanks, series applied and pushed to dpdk-stable/16.11.
--
Kind regards,
Luca Boccassi
prev parent reply other threads:[~2018-02-26 11:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 5:16 Rasesh Mody
2018-02-26 5:16 ` [dpdk-stable] [PATCH 2/2] net/qede: fix clearing of queue stats Rasesh Mody
2018-02-26 5:38 ` [dpdk-stable] [PATCH 1/2] net/qede: fix MTU set and max Rx pkt len usage Yuanhan Liu
2018-02-26 10:53 ` Luca Boccassi
2018-02-26 11:00 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519642801.22753.21.camel@debian.org \
--to=bluca@debian.org \
--cc=harish.patil@cavium.com \
--cc=rasesh.mody@cavium.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).