patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Luca Boccassi <bluca@debian.org>
To: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>,
	Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: stable@dpdk.org, Chao Zhu <chaozhu@linux.vnet.ibm.com>
Subject: Re: [dpdk-stable] [PATCH 0/3] eal: clean up mapping hugepages in secondary process for ppc64le
Date: Thu, 21 Jun 2018 09:50:53 +0100	[thread overview]
Message-ID: <1529571053.6322.44.camel@debian.org> (raw)
In-Reply-To: <cover.1527076172.git.gowrishankar.m@linux.vnet.ibm.com>

On Thu, 2018-06-21 at 10:57 +0530, Gowrishankar wrote:
> From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
> 
> Earlier powerpc arch encountered an issue in secondary process
> to map hugepages in same VA range as mapped by primary process.
> By then, proposed fix was to use nr_overcommit_hugepages from 
> the kernel and mmap using MAP_HUGETLB|MAP_ANONYMOUS flags. Though
> it solved respecting address hints in mmap calls, this fix
> introduced limitation of maximum VA space that, primary process
> in DPDK can create upon hugepages, to physical RAM size (almost).
> 
> This patch cleans up this limitation by
> 
>  1. reverting the previous patch so that, virtual address space
>     range is not a constraint (like other arch).
>         
>  2. reverse-indexing on hugepage files as the secondary
>     process mmap them. Reversed addressing sequence makes 
>     this mandate.
>     
>  3. Move slightly where munmap() is called in zero-mapped VA
>     block, as secondary process would attach them.
>     
> All these changes has also been verified in x86 arch (and request
> other arch maintainers too test this and give feedback).
> 
> Fixes: 284ae3e9ff ("eal/ppc: fix mmap for memory initialization")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.
> ibm.com>
> 
> 
> Gowrishankar Muthukrishnan (3):
>   eal: access hugepage_file in reverse order for powerpc
>   eal: reorder calling munmap on zero-mapped memory
>   eal: reverse powerpc changes done for hugepage overcommit
> 
>  doc/guides/linux_gsg/sys_reqs.rst        |  6 ------
>  lib/librte_eal/linuxapp/eal/eal_memory.c | 22 +++++++++-------------
>  2 files changed, 9 insertions(+), 19 deletions(-)

Hi,

which stable releases are these patches aimed at?

In the future, please consider using git send-email with --subject-
prefix 'PATCH xx.yy' so that it's included in the subject.

-- 
Kind regards,
Luca Boccassi

  parent reply	other threads:[~2018-06-21  8:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-23 12:53 Gowrishankar
2018-06-21  5:27 ` Gowrishankar
2018-06-21  5:27 ` [dpdk-stable] [PATCH 1/3] eal: access hugepage_file in reverse order for powerpc Gowrishankar
2018-06-21  5:27 ` [dpdk-stable] [PATCH 2/3] eal: reorder calling munmap on zero-mapped memory Gowrishankar
2018-06-21  5:27 ` [dpdk-stable] [PATCH 3/3] eal: reverse powerpc changes done for hugepage overcommit Gowrishankar
2018-06-21  8:50 ` Luca Boccassi [this message]
2018-06-21  8:54   ` [dpdk-stable] [PATCH 0/3] eal: clean up mapping hugepages in secondary process for ppc64le gowrishankar muthukrishnan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1529571053.6322.44.camel@debian.org \
    --to=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=chaozhu@linux.vnet.ibm.com \
    --cc=gowrishankar.m@linux.vnet.ibm.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=sergio.gonzalez.monroy@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).