From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 028FF14EC for ; Mon, 23 Jul 2018 19:09:03 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id t6-v6so1438356wrn.7 for ; Mon, 23 Jul 2018 10:09:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=GwseWzClj9mjwA6D1x9x2o/ieB4fa0kopLLGK2RDFKs=; b=Mf198rinEVwhU0yCTJMoKEyd9RsSNZYInGbhBkQcM++UZ6fLXNdL4/CcLHI4RIe7sJ LZUONDyuETrryJiovGSHlK1eZZh4goPaQ/X28z5wvX5JKikMe/tOr+QloP+BkaOnpzxV 8mHt5gnqWQJH3dbkmV/8rT36Tz9ZVJm0cKnBMj4J1yJkq4M3R+kx4TqmPFH90B30vlNS mY6gOa4RbjNnTmSHfLimOR7A6CBifxHZoI7kdsdkNvo793dZTW/bPkwK979jsIQMYf/s P20uYj0JRQVedi8EqeGuxtsuJ/h0OUXUt4kvm0ibb9qvKFKim8lnkN0x6NqMDP1kxmRY MnKg== X-Gm-Message-State: AOUpUlHOerGZm6UQ4NdnZEK2mLd1MCuWVqPOsEeodcDdil7hjiX67O+Y ORlIG4lpjkK4Wrfvf1R2cHI= X-Google-Smtp-Source: AAOMgpfacQxoggXIO++7g/TtJVUNJIApe0RtLG12wW61yy67NiDBvv4gYSAK4h/ipmiddyH1OhPB7A== X-Received: by 2002:a5d:438d:: with SMTP id i13-v6mr9585135wrq.156.1532365743716; Mon, 23 Jul 2018 10:09:03 -0700 (PDT) Received: from localhost ([2a00:23c5:be94:4600:7b12:f8a0:fd52:f87d]) by smtp.gmail.com with ESMTPSA id e7-v6sm16171485wrm.14.2018.07.23.10.09.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jul 2018 10:09:02 -0700 (PDT) Message-ID: <1532365741.7624.10.camel@debian.org> From: Luca Boccassi To: Pablo de Lara , ankur.dwivedi@cavium.com, declan.doherty@intel.com Cc: stable@dpdk.org Date: Mon, 23 Jul 2018 18:09:01 +0100 In-Reply-To: <20180716062551.29742-1-pablo.de.lara.guarch@intel.com> References: <20180716062551.29742-1-pablo.de.lara.guarch@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] examples/l2fwd-crypto: fix digest with AEAD algorithms X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 17:09:04 -0000 On Mon, 2018-07-16 at 07:25 +0100, Pablo de Lara wrote: > When performing authentication verification (both for AEAD > algorithms, > such as AES-GCM, or for authentication algorithms, such as SHA1- > HMAC), > the digest address is calculated based on the packet size and the > algorithm used (substracting digest size and IP header to the packet > size). >=20 > However, for AEAD algorithms, this was not calculated correctly, > since the digest size was not being substracted. >=20 > Bugzilla ID: 44 > Fixes: 2661f4fbe93d ("examples/l2fwd-crypto: add AEAD parameters") > Cc: stable@dpdk.org >=20 > Reported-by: Ankur Dwivedi > Signed-off-by: Pablo de Lara > --- > =C2=A0examples/l2fwd-crypto/main.c | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd- > crypto/main.c > index 9d6bb7857..9ac06a697 100644 > --- a/examples/l2fwd-crypto/main.c > +++ b/examples/l2fwd-crypto/main.c > @@ -408,7 +408,7 @@ l2fwd_simple_crypto_enqueue(struct rte_mbuf *m, > =C2=A0 /* Zero pad data to be crypto'd so it is block aligned */ > =C2=A0 data_len=C2=A0=C2=A0=3D rte_pktmbuf_data_len(m) - ipdata_offset; > =C2=A0 > - if (cparams->do_hash && cparams->hash_verify) > + if ((cparams->do_hash || cparams->do_aead) && cparams- > >hash_verify) > =C2=A0 data_len -=3D cparams->digest_length; > =C2=A0 > =C2=A0 if (cparams->do_cipher) { Hi Pablo, For which stable release branch is this patch intended? Has it (or an equivalent) been merged into mainline? --=20 Kind regards, Luca Boccassi