From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0043.outbound.protection.outlook.com [104.47.37.43]) by dpdk.org (Postfix) with ESMTP id 872C72BF1; Wed, 25 Jul 2018 00:19:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lHc9/Y+0eetZcwDMVDkKJQ23ERfo+qMKVDpDA25NWmA=; b=QLGwEd1XPFQk4APlhGEuK1k8DwWpV41LrxfXE7v87GN3P733/V6OUmK21+P/8QAR10hE7+pSCBr9n/amr9alMIvLil0vlB6ekAwFgAldK8V+0ib+ibqzyPFqIG183U/kuBGTDzGg4BUR7dTr3GhOz6enHOuVv0QuNH5nHDEiyQY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.1.6) by BL0PR07MB4017.namprd07.prod.outlook.com (2603:10b6:207:4b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Tue, 24 Jul 2018 22:19:00 +0000 From: Rasesh Mody To: dev@dpdk.org Cc: Rasesh Mody , ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com, stable@dpdk.org Date: Tue, 24 Jul 2018 15:18:43 -0700 Message-Id: <1532470724-31668-3-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 In-Reply-To: <1532470724-31668-1-git-send-email-rasesh.mody@cavium.com> References: <1532470724-31668-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [198.186.1.6] X-ClientProxiedBy: CO2PR18CA0046.namprd18.prod.outlook.com (2603:10b6:104:2::14) To BL0PR07MB4017.namprd07.prod.outlook.com (2603:10b6:207:4b::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 93f36ccb-eefe-42a8-66d2-08d5f1b3753b X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600073)(711020)(2017052603328)(7153060)(7193020); SRVR:BL0PR07MB4017; X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 3:AEmjcpcHySdHvjOlSaK0/M0umQ/VFscJkMP3QStMjNNFcncbRHERBtM94DQeqEriit1lGT3fBUmbN0Yn8Tm3XtDUiDQ6Dlt81Isl9Ts2gOqZcvS76CcflyR1ghEsa0D8zlsmMk3JjpRwT4+ft57T+wFVD1pwSqquEM8NqryBGKPMOGoSTMi4mKedH2aiGywqttL1KqZh5+ey0NBfjdt8mlSFGyO5CIPCcRIJ4uG1trMJ5XVOv+BUrVFy+9ovXW34; 25:HbfClJuVTy/f+wB2K5EMUt7Hhv6BwxMbblFiQy7KbbiCBzSH/UgUcLeNutJVl3B1NIN9GKbi4HJxTISYn+GX6RMAln1z7THBKqqPZOOkSsb1EK0UUWWojTBRiKx2X5v3aMMEUYr5Ysm9T/hNnF7z2p9idCsYrxJLY8DZwQoXFuygdsgIx4XSLzgxLtsQJIxjG7WjKTxspt4fgmxyTLZ9gHfk+purQMiC8ljrJU08yHF0PUKshxwqHKSG+qjAoXH3PHdwHULS+DZEuLOSrXv1N1vXf53bQ/e/8waQBMdUT2v/baTVBTyymI8IhOiTKGWTveV7L9OjdvGf28frJ7wr8w==; 31:8hpngrP7S9EAcMIy8TK4HlqzyjcnEBhuES9Ge7VFTSlDEaceyX0NnfWchi3pNhK9RgPBh+TtgGL566RguTTkURBOq3ehaafyAzAUjlxGI/rADaMXyo2zTP+0hoWuH6c2BrL2+++qPNn1wELqJdqyoQc2hxEKTJc6hRGb/6/a04wSKSVxsqrBKSoiZ5PStpclDTpzxA+iACz7/CE3/9rOiA9Rlol76qKxe7xtzjPeXPQ= X-MS-TrafficTypeDiagnostic: BL0PR07MB4017: X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 20:9tlFTzSErV/HcewRTjsCDY+FKMP+MJT+TtXJSt/hA7R2Ogirl1n0xe/u9j97tMY4ZsuhJ6uUeApiD099lPtZFXuaRcqU5CEn/gyfizHLapgVYDWUIukcFstvsfrxxn149HK5575uJVhACLiqd5kbmHgQr/6mGKOJ37t9d7kZZ07HPnPx8pNyApQpPNPQcD4hCajY9UZ5lvvUY+3geCNlXy62bZqWoVFe58+WcjhSRsxKBSQnAtzGTQBkusRwC3mwrXTpBye2qhwac5A0IUwiHpXOvweWbvsumwdkMRG9CRaE8Sx+Vbo51H9qWIILGeJBTAbJLq3y4hBq2YwF0eQru4g7SmJGBr/BfvGxzRn+zVIsaYdjWw+BUbBfkjyMHdwIKcp4TT9LtbJamzVOa2w+8ZlbAEZ7JtyOUo0xwYKCO2tWVcKKcyaPipL4paRsuUs39o8uAQUfHIf9w6eLrZP4osavRhAicC6eIdVtRriVZuBvwvnCSztlyYKQczkLKcpM; 4:WEHoDENNWFE0Bu+NkPGKseDKEuvpnBPt6REJBfCu1t3ER21ATYTCgei2YPINSkQdmlUES9RdhvxuMUr4pHNUhtMolaankNP95PVq/2FwZGJYLLRjwegZqIPHYHpnf76tJYpg/FVGXHI/CpeTJaxwbj3wVhlvyx6jclo4FB9LXXEm9LpJhZ+AO6kNSUR9Ql18ZJwpY+xn20hQ6PeRst518RgndsZFF7MnkYfmTmv549S2GOznrgwrYl6yDDdCTEW3gbu5DOZ2gFRU/zkiY+82aA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(10201501046)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:BL0PR07MB4017; BCL:0; PCL:0; RULEID:; SRVR:BL0PR07MB4017; X-Forefront-PRVS: 0743E8D0A6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(136003)(396003)(346002)(39860400002)(366004)(199004)(189003)(76176011)(44832011)(478600001)(25786009)(486006)(72206003)(2361001)(55016002)(53936002)(97736004)(4326008)(47776003)(956004)(2616005)(8936002)(186003)(51416003)(52116002)(386003)(7696005)(16526019)(26005)(106356001)(66066001)(5660300001)(36756003)(105586002)(2906002)(50226002)(7736002)(476003)(68736007)(14444005)(4720700003)(21086003)(69596002)(6116002)(316002)(6916009)(6666003)(446003)(81156014)(81166006)(16586007)(86362001)(50466002)(305945005)(2351001)(3846002)(48376002)(8676002)(11346002); DIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4017; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BL0PR07MB4017; 23:Yt5Nu/MAsIcUkb7Gk080VtkMQDXblu5QRiaB1qV/V?= =?us-ascii?Q?vynstwKdWAuffZ8azhKhwTcgTH+3fUTAUilK9crowf0QF3a5MetwZ0AeO6eJ?= =?us-ascii?Q?x6+BkbyJZIXkJ/T/5x73bZ+xt/69RHyhrhaJdiOfSHBo9s/T7rQ9DTlAqXsb?= =?us-ascii?Q?EdjKQqRP4q1ITKOl98+0xVR0Fv8pSp50STVHTCV7onRCwak+m/bbfy6JPtGY?= =?us-ascii?Q?16BjfbvZ2WBmXwxvQ/EEbTOILHYI3rsnzSjQ1IsfUk1dvQYUkQ4ZDHQ9qOms?= =?us-ascii?Q?Vf0pchWgohBh/PJMSE3XjWW5sihdOx6SHMqvsYdL+yfV+9Kubo0L1Nq08EgI?= =?us-ascii?Q?4JPJWokNq8aFtrW+PVxSKLdxMWg1cAEZ5WdJZ32kNJH9ixHV9lGS6deWBCZ3?= =?us-ascii?Q?mIt/QQjC1isWa7W9bwei9o5jnHMmdTLp/NSLQdMd21EJALk3mR9O7KyJeEyg?= =?us-ascii?Q?ZQMX0ahjAx+rRhizuCYBOyTNX5u6RJBZajwOSyldwNWDTj6/MpFe5et5Azla?= =?us-ascii?Q?p4CbcZ870jyWrrGamcOpUJCOjBqyEaeV2//VHfF4wxgueA43KYQfT32FPthq?= =?us-ascii?Q?AeaSHi3JIar0oKWRa/siwiNKgI2xcJh4l+kfU5LQs9T6BnCQIhTuT3vieaE+?= =?us-ascii?Q?nEm6kpItyya8P39Vo9L6J092gOb0PJtrNb6DF0gqIDL4ZJKgVNSnNcec4gh9?= =?us-ascii?Q?Jlzdrg2SauXhp1NQg4GzIU4rNcX1ZjgBlU2UAdgfNwYfmvIhHt1wv/y+r1nM?= =?us-ascii?Q?iYK6Di7KKkXmcjKgpS7cvq4I5TWBEmJwViBtWFBQnlaB2DVmqp6hPvzEOC7j?= =?us-ascii?Q?ShW5+jLPJkk5KbfrniEl91+L8oGLHFHVy/3mWwktBF9DUDypFbvGIzfH2qUt?= =?us-ascii?Q?ccTOvd0Q7fudsGijKGvDKW+xtkIg4mBFgqpPsupJWdTC1BiozWRWrVAECd2Q?= =?us-ascii?Q?1ibXYfZUoxjBaGgQV/hfzVy6tyb0hmEViPkMENSTNmbHh0BHvggj+2xX5+PB?= =?us-ascii?Q?chAQlTU/1wGpuIaSByp9ceKVJ39PtBYhr8JaVVXqILwIEc28ztse5lmi8avu?= =?us-ascii?Q?jb0BGxcHfQ5fDB6GLgDvtaWz1BIthtafgHldbGmOUqhuygNu3udix1oCA8Xm?= =?us-ascii?Q?8siOnQJTJ3VIzRsqn4WseZVljuGYwqJHVJaABl2AGMtoizXP6qI7j8bk9Tqq?= =?us-ascii?Q?DC9q+govOqdVyvKPDyWLhIcOZ0JsmWLxZG1YE8FDWMDPmkE/oMhRnhGM/QaU?= =?us-ascii?Q?uSJv6MzVdGzlI1ElqC3/LHdX26pz54iZDQh3d399NRXju4OjREsLmpJCv9AW?= =?us-ascii?Q?N0P+U6+dzLoWnLoJVpQj/c=3D?= X-Microsoft-Antispam-Message-Info: QAGhM8qKTyC2e3LwN4ups9sihp/9Dy9Dpes/gqTHJTgRsYPIb4tG6oqlZW7FUWiKZ6wNgG7d8G7YJA2x1vVhN9Oxv7ubYIYhNk1edyYlCe+NxbjCl25LBgiat8p6C3i0qK/XhLSQj59sHlcbFK/xH8sXIv88WMbRpOPpTvF4u5lCVmOMmESlI5ZZXVo7TvcwPlW8noUvN2SYzPctkRzqdZ0QPHrhkScL+FyLdutnCEsEeG3+meBVCltIdCDSiu4Beuv+ayGJc1UAKd5t6zufk9wlQBJLq7IVs8NKmUA+yJgWOkL2xBeD0u4HQ3v4gP75Lqd/68bjJBnRfsmvfhB9e9WaHTkgtYac8mF9vnGlAl8= X-Microsoft-Exchange-Diagnostics: 1; BL0PR07MB4017; 6:taoXRpbGP4PePQ8/QPARioB0ByTTx5FnNUnAy+TICg4l2SvS2yx1aQPVpXvqnsacpHxdpXjeRIoTlDKkl82+X/bhjGRMLwb1FT5X/uJKO5MJ72UN5fG4sXMFyC5L7iJG7MVhMa9R2rFrfWvcYrqR5PFtEl2rMH4nmjpSfUau8z5HRQvTSmddW7qo9WYcHMqMMRpjRoJbC2lOuhMf0yd3kvkiPLc4Z+0Op1yaZGPebsctvAPoLU9Ndoa+SaAl3I0u6KKzHbfOauDAoaRGeLL44oRyYTzn/aAVoDXLACCIRfdae5sZQzO/GwOXrpkh6vCagOCPi9ExXquJ3wbvqMlKpNZInJrhnMAwLAhbP/0c2UxWdAc71SCbNkMf3SK1XRyT4j1MLnUXfMAqgepUGaXDQX0bUQ79iFPOd4HFXtPXFmoUNoWkMYKhr3bQ/6gd9a/tQzohdQEJCutwRo0ZGhGAHg==; 5:ar285tnCL9XKKFLxBAcM7KA0EHhsyTNW5bODkA8w3nH2m0IpyB52fE0k2+CrNNv6B7p5ZztthoAyJFHjFXuyAtdTrtSJoePlU/etwFMcQgUlHMtEKHYJEl4lu20YmZR6xPaAWSDhNT7MSEdmbi+C8qN0ivqQBNmHu7SVjSTdePQ=; 7:UXh5M6xa5edMLdksHfLclpo+fhdvkhuNhXlR51PkWUUSkNH0BSNSkYgz5GXLErxJkJpjMIeKhsIaYv129eq7wg0VEdSfIsu98BBVxOiNiuYUCFJ+SkhmD/eTgzO+5IE8UMDhGhlKcxpN0+aCzdCD9RpDJqApUmLYwzT+IOHWhSRABe6KSLCd5W3TRIgWBeiq1dXlRYkEG4UZ0bG4Bwcks5YOOAtW9tlWBEM5183BRVxVTGH3cqB9uG3GQ1Wazvfa SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2018 22:19:00.3872 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 93f36ccb-eefe-42a8-66d2-08d5f1b3753b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR07MB4017 Subject: [dpdk-stable] [PATCH 3/4] net/qede/base: fix GRC attention callback X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 22:19:03 -0000 Treat any attention which is not for timeout event as invalid and return status accordingly. The HW error handler logs and clears the HW attention. Without this fix we can see flood of GRC attentions. Fixes: e6051bd6b07d ("qede: add interrupt handling support") Cc: stable@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_int.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/qede/base/ecore_int.c b/drivers/net/qede/base/ecore_int.c index ce8fac1..4c271d3 100644 --- a/drivers/net/qede/base/ecore_int.c +++ b/drivers/net/qede/base/ecore_int.c @@ -231,15 +231,19 @@ static const char *grc_timeout_attn_master_to_str(u8 master) static enum _ecore_status_t ecore_grc_attn_cb(struct ecore_hwfn *p_hwfn) { + enum _ecore_status_t rc = ECORE_SUCCESS; u32 tmp, tmp2; /* We've already cleared the timeout interrupt register, so we learn - * of interrupts via the validity register + * of interrupts via the validity register. + * Any attention which is not for a timeout event is treated as fatal. */ tmp = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt, GRC_REG_TIMEOUT_ATTN_ACCESS_VALID); - if (!(tmp & ECORE_GRC_ATTENTION_VALID_BIT)) + if (!(tmp & ECORE_GRC_ATTENTION_VALID_BIT)) { + rc = ECORE_INVAL; goto out; + } /* Read the GRC timeout information */ tmp = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt, @@ -263,11 +267,11 @@ static enum _ecore_status_t ecore_grc_attn_cb(struct ecore_hwfn *p_hwfn) (tmp2 & ECORE_GRC_ATTENTION_VF_MASK) >> ECORE_GRC_ATTENTION_VF_SHIFT); -out: - /* Regardles of anything else, clean the validity bit */ + /* Clean the validity bit */ ecore_wr(p_hwfn, p_hwfn->p_dpc_ptt, GRC_REG_TIMEOUT_ATTN_ACCESS_VALID, 0); - return ECORE_SUCCESS; +out: + return rc; } #define ECORE_PGLUE_ATTENTION_VALID (1 << 29) -- 1.7.10.3