patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH 16.11] net/bnxt: fix close operation
@ 2018-08-10  1:11 Ajit Khaparde
  2018-08-10  9:07 ` Luca Boccassi
  0 siblings, 1 reply; 2+ messages in thread
From: Ajit Khaparde @ 2018-08-10  1:11 UTC (permalink / raw)
  To: stable; +Cc: luca.boccassi

[backported from commit 3c2e87c10b6f2c249a26e419b565bff5589b4637]

We are not cleaning up all the memory and also not unregistering
the driver during device close operation. This patch fixes the issue.

Fixes: 893074951314 ("net/bnxt: free memory in close operation")

Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 86c2a8108..44bf6ba98 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -137,6 +137,7 @@ static struct rte_pci_id bnxt_pci_id_map[] = {
 	ETH_RSS_NONFRAG_IPV6_UDP)
 
 static void bnxt_print_link_info(struct rte_eth_dev *eth_dev);
+static int bnxt_dev_uninit(struct rte_eth_dev *eth_dev);
 
 /***********************/
 
@@ -586,6 +587,8 @@ static void bnxt_dev_close_op(struct rte_eth_dev *eth_dev)
 		rte_free(bp->grp_info);
 		bp->grp_info = NULL;
 	}
+
+	bnxt_dev_uninit(eth_dev);
 }
 
 static void bnxt_mac_addr_remove_op(struct rte_eth_dev *eth_dev,
-- 
2.15.2 (Apple Git-101.1)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [PATCH 16.11] net/bnxt: fix close operation
  2018-08-10  1:11 [dpdk-stable] [PATCH 16.11] net/bnxt: fix close operation Ajit Khaparde
@ 2018-08-10  9:07 ` Luca Boccassi
  0 siblings, 0 replies; 2+ messages in thread
From: Luca Boccassi @ 2018-08-10  9:07 UTC (permalink / raw)
  To: Ajit Khaparde, stable

On Thu, 2018-08-09 at 18:11 -0700, Ajit Khaparde wrote:
> [backported from commit 3c2e87c10b6f2c249a26e419b565bff5589b4637]
> 
> We are not cleaning up all the memory and also not unregistering
> the driver during device close operation. This patch fixes the issue.
> 
> Fixes: 893074951314 ("net/bnxt: free memory in close operation")
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/net/bnxt/bnxt_ethdev.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c
> b/drivers/net/bnxt/bnxt_ethdev.c
> index 86c2a8108..44bf6ba98 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -137,6 +137,7 @@ static struct rte_pci_id bnxt_pci_id_map[] = {
>  	ETH_RSS_NONFRAG_IPV6_UDP)
>  
>  static void bnxt_print_link_info(struct rte_eth_dev *eth_dev);
> +static int bnxt_dev_uninit(struct rte_eth_dev *eth_dev);
>  
>  /***********************/
>  
> @@ -586,6 +587,8 @@ static void bnxt_dev_close_op(struct rte_eth_dev
> *eth_dev)
>  		rte_free(bp->grp_info);
>  		bp->grp_info = NULL;
>  	}
> +
> +	bnxt_dev_uninit(eth_dev);
>  }
>  
>  static void bnxt_mac_addr_remove_op(struct rte_eth_dev *eth_dev,

Thanks, applied and pushed to dpdk-stable/16.11.

-- 
Kind regards,
Luca Boccassi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-08-10  9:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-10  1:11 [dpdk-stable] [PATCH 16.11] net/bnxt: fix close operation Ajit Khaparde
2018-08-10  9:07 ` Luca Boccassi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).