From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700083.outbound.protection.outlook.com [40.107.70.83]) by dpdk.org (Postfix) with ESMTP id 06F933250 for ; Wed, 15 Aug 2018 20:58:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5W7Z+7gHTzjkdmtAAxekKih7vrtXIJ26GL0t64TDZks=; b=LtMTn8R7ryGCL0w8v5G8IXyTAJ3UhALnZO2QYypUpXscovwEGg66QCTgs+1g1lEKZ2KS+eGa7B46FNZ9M7/Xzd0LChhnKFaRHPP9mEq8wzhEiElXVVvd0ZkoG3LiDsPAHwZjUX9tV/P1Ap++R4nWtkgZr1X71ja4oDA7wGylArg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; Received: from cavium.com (198.186.1.5) by SN6PR07MB5374.namprd07.prod.outlook.com (2603:10b6:805:74::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.22; Wed, 15 Aug 2018 18:58:01 +0000 From: Rasesh Mody To: stable@dpdk.org Cc: Rasesh Mody , yskoh@mellanox.com, Dept-EngDPDKDev@cavium.com Date: Wed, 15 Aug 2018 11:57:51 -0700 Message-Id: <1534359471-20234-1-git-send-email-rasesh.mody@cavium.com> X-Mailer: git-send-email 1.7.10.3 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [198.186.1.5] X-ClientProxiedBy: CO1PR15CA0049.namprd15.prod.outlook.com (2603:10b6:101:1f::17) To SN6PR07MB5374.namprd07.prod.outlook.com (2603:10b6:805:74::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 34a95010-72b2-49db-5fc1-08d602e1069f X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB5374; X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5374; 3:z6OzJBWXWiInsfstHUOVnEagAa51iD1etfgXpsvM3sWhVibF+OCfPne9raCO/VI3D/0Dhn2y87Mh/8iEtM9NRgSX52bW0yntRc+tMv1DRcZ6xoXOLO+QdmuXzUVxpxZIh8i8295K0qNX1fQdb+c/YTXmsTYR3WUzogCn6mshLshYmUSrrF+/j8qWI4BHnC82pD8jOAYwyzsdsqVYWZjxasQ1rZ1qMzm6+D2pVx5QBMkTvFZPSNmRBaIcv2cTk4l6; 25:+2phf3ihvnD5yS2rmoGklzU3g/CUaTcNziiPgZoOR5pUzgIbCWXxYyYreNxHJBPpS37i6OloQAZS/pNiCqo1xZY0Y9JwWgiSkZfeYebOB6TD0U0VpHGwulyiHali7kieZu5N828Bpz+33I+xRZe8KetK23ZBFdtQWhlzX2ifCtOmSUoEn1jmkwMDq3mVN42nZqE5yNvxP7Z1KRWyUI8/mtU7agcV8mjqShuElXFfqljllMKqJ1x0w7s8am/TWSeqnn6qbsKb6tNRGk8wSIySDC/M+SEK72V74K/qWC4a/LI+fWnmeQUYFy/QLG6hwaQrOqPTpuEBqwI/Tgq2Xf6dXg==; 31:71jj3hClUjOkhijJgkNsn40jxD3P4H6bXKKVFVanI+og2l5Kmm4PK2ALm0n2YlypJXCRLJzpg6aS/LIug88jky7PJ+zdo3FCEKDNIif18wcU2yAXYMKyd+A+R5S+QcSjDaSHaUGZO+hdlLrUX03ToGmK9rYsqIpBGKK2burIPFUuZcLxCtGUzFg1T8aYB0KVdR88DLT6c4+M9UsClJjY9dqBFzpfOEbiu7DDEsbD1cA= X-MS-TrafficTypeDiagnostic: SN6PR07MB5374: X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5374; 20:Ay5h9N0ew1dsDSMR6ktOt5SjftztixQKjOIIeeYfxdU4d0acSZqhYZm0Jvsg5FOm+r0xbU92FQAB9G8QBU5MTYAHII4bbI35HKB//nndqpaRJyiQGRYvep0OsSdZqq+sxtftrWTDfNcnIBTBW7jprfCIgJNhTJCRQhUjs+XtBMxVvZrYyYy6ZPkJ8B2azljO5tp6Cjsn8Kv/EVDUarIH06iHkc4VzpVlsUIMPCz2skhO4pO4A4WpmPnqNgprV6WP5OfKDWk7FWRez2cPCYKOffrWpgtFhUcFv6xPh1lWMnQgi1CYSsNS/MgsPBmTRdTRPaOnEcHPeSnM8ppuQJxahSF+o+XgTDvWxti1AcDW4UJIZNT0PoegLUjXA7R6BuUdsH29CqWrvKffkPtLmD+mVvPA2kn/45MFGw9dDu8N4g/I11+UfkqVwBmtH6QtEFLf4zaS7B1Kd+fKTcHyEIWuOTB1qtrUcF8ki2jRkW1z45ozlduf1jiNcmjP6Y38nJ+f; 4:wckmpN/ilwub+A+8HeVQ+2tuwNkOKz9iE+ZtoV1N/4GoQUA3W2nrVr/Z0SbQzEfnUoU2jwOIbguYcmb871HTi2Zw3SInP0Vo1yl1lF/6lAHQS37Oi1q0tKAXlIA62SzrbYSYGoG70+AL+3a4PhElXmDbM6zvZmSW1d/K9tx5gf7lcmJKARBEgfMM0TwA6I7HOu4Hzunuk+bYxagsBCm10N0oxI1V0GQjY3o3abWMI4iC/MZOiIGTu41uTAfRv11nkGDK4jr2FgQ04cmrQ3sF4w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231311)(944501410)(52105095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123564045)(20161123560045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:SN6PR07MB5374; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB5374; X-Forefront-PRVS: 07658B8EA3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(346002)(366004)(396003)(136003)(376002)(199004)(189003)(66066001)(476003)(2616005)(956004)(4720700003)(6666003)(21086003)(51416003)(97736004)(6916009)(7736002)(386003)(26005)(2351001)(69596002)(52116002)(68736007)(8676002)(81156014)(186003)(486006)(305945005)(47776003)(7696005)(16526019)(81166006)(50226002)(36756003)(4326008)(16586007)(50466002)(25786009)(55016002)(5660300001)(53936002)(44832011)(478600001)(72206003)(107886003)(86362001)(48376002)(2906002)(105586002)(2361001)(8936002)(316002)(3846002)(106356001)(6116002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB5374; H:cavium.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN6PR07MB5374; 23:O8xdOazibZ8C8t+Vyt0NpD6uO4qiEKtKmbpbqf1bo?= =?us-ascii?Q?03Sip8C2Vl7g2umKo8t90CAs6rNwVkvVO54GFsiklXE2TeI1Hx+ymOCRvDFE?= =?us-ascii?Q?IAiuqBcNk0UzWZn3Xflm1m0Qo2riIjkuoeSKC5VSsAYuUuxDqnB7nohqbcn6?= =?us-ascii?Q?L1BYhECxBKCdozpp88VQjZb1dBp0kWZ3SagOQHAAt76L1yccPERX/bv7CR0Z?= =?us-ascii?Q?E36nl09GgyCoHTyeqfVi0ijnAdC4XGNDBMfyJkdKaGe5kWPNHxMhzo0WHyxN?= =?us-ascii?Q?N+tYIxQACOgdQstuqZtJIrJ3H7nFNHRs3cK0t0Zu9X+z1y8gtnbSzhkw24qS?= =?us-ascii?Q?taRB0WLzXj+UTNYksEr4s9DEoWbk3XA2pw55OAs3Ovquo3ACPuRllM3b52Ah?= =?us-ascii?Q?ko9eKe+Tuyi4nls0NSRQea2C09Z1yrqRYlBoyVxYLv6xocAzus6vD2hWEP17?= =?us-ascii?Q?AFA2FGXibmTJ7kleQBHG4jjhiU/HeMFTZLI88W6tFcVovKJO9wheyJrFG8fL?= =?us-ascii?Q?VBdwg4fvNJEljZAS8qcsTbtF2oOmmWtdULG5YnJ2l4JaJ2XnJN1WQG4MfeKY?= =?us-ascii?Q?ZSu/8hAhQT3Niw1AWr+NavmqUqnHd5edRbTFvp7mzBW9njrdH9tOSNsUogGw?= =?us-ascii?Q?nlrT1A751UY+JXj+ri/pLKVQFvJ5Hb6MnewQxDFpbzhA0N9h031NF67bXHEs?= =?us-ascii?Q?BsjyfhOCtirrDzx/pyvgtBQIqjNIss5w4u4C5geNS1TvQZYG5Ygt8LwtntRT?= =?us-ascii?Q?S9fb3iyfI1ha+K4oqKv+aKKKIcMV5o4mcYT13xELfbMuZNluM8hgcHyZftn5?= =?us-ascii?Q?FYW7M3OpCPHbTrrbR9Wh0Y29gVtPbM/jqYIGox78l1oOJwEx4AX9OfCNsX+X?= =?us-ascii?Q?3Y6tv/pW6K5UM0GLLLODNkbFuwv27uXfxWkAMLDQpb6jp72vsbcXfkfo1764?= =?us-ascii?Q?6/HyFFHFViIw2XRzZm6/IHGWdH0fToTXLHEBVKrO6lAfXzHCZsYGrYaSz9Ua?= =?us-ascii?Q?+KGaQ720OaQI7R0idaZAIiwrttR5n/vqiMZArglKFq4/UkSs5Sh3VbO7bj2s?= =?us-ascii?Q?JxWec2CTktLfXUhxFVfhozRIqTatvr7dIKMCXBMBngVM+oqsfrUdqZGkg8fl?= =?us-ascii?Q?LLXCIk6vsbPDPCipXfuV3ehssbxZI4d86mUudL29ZNv7QAIsCR+HXW6lPuLf?= =?us-ascii?Q?grdpoLrv7pzJSbc3LO+bCtdXxAMr6tyqJpEYcWz3AlpSaahLADvrSxL6XPfP?= =?us-ascii?Q?fJTQdxpmxsrXMgYLmgM4wT9OC/Z7DWIMByvldJM?= X-Microsoft-Antispam-Message-Info: gInjtHvb+5YfPmUl2JqoQUOQWTAc/8s/Vk9D8/QkUZuo8YbkaKGjtVer/tE2nbQx7AyVfMMCnI0aTNFdRcGk/E08jl6UJpSxhU0+H8lte929cEFDpIs8RZSVifXkiWEpk3JfXwwGwqcRj2E3NR2ECgWODZPaLZEhXh6rAZCnf5PKMujHWhj+593QWrDkOST95Wh8uLu/HCQn9rByFu+/XZoVTOT4zPPumfITHLwvZnV9+LH0ecR32cmXUpwD6d1hgYqjGcl9O8ZeKmeBo7U4+DQayMq0HvmaM1JyMrw1KZnZaf5rs4eO9Tn22g1HpgHWbU9bLwbPwJ12iiCE/WFd1bdNDsBxfQYmYk3Hy0XBoqM= X-Microsoft-Exchange-Diagnostics: 1; SN6PR07MB5374; 6:D1MqyPd6WhgQFGqCIcaTT/RI2kUQHUz1iKIm8vWWBn3x0JEUPmkf79nNkMwtk0LIU+q648KjRXPXgvOhGQBn6agLSWQfhEsIIV6L2YvUTM4JHSNYuoFjD60GC/YOxt8L9Kh/bjiXclqWaj0qHPsSJilW5vlpK22158dZAI9oST4iz2Z55zp0q1krES9I6R65kr+hShcWlmYHvo0XZ2n3DvANGwWwqcn1AB2nV+iTWWwEahyF1r8P4z5/G0SoffoFoUzcwP+FvKz4c36XA4pOQ9I1rvMURpAvzuIPSOM95FlvlgGsGS2nkBjZudzmOpEHjpNWWNVNj2vj074eg2QHiHEUM9HxcqJPBS+Vxm6HV8+SMa2ER42c9IMqYjS7A2fIfnxe9+IfenAAAAx4wl5eIjoCEaAbLFCdEg4eRACzLHkrgVpHRDikGrvfFxZipY0g4W2VBPDKw9BBJdIEkK5mEQ==; 5:d6Omb8Djygz91VqqxjulEx1EM85Q+O60cDLrDCG31Juf4tWC/VOwPQ7oP9SDY+uaCVVFKCvcU84JRB5hpWK9R35sHbqYoyIGAiRQPcLKqiJ/StdAxMGJAO9eBQqlQAZVpVTjBgmzD2VP6Ihjqlf548JaCNU+GPeimh1489Q1wq0=; 7:5B7IeNZjcaTjBN2lofc9tkJj38JLo4tsniP2828q4xWsi/+JP6FxFxFRQGqYo1s/gcdqoFonBeKcvEp+2A/KmI4GSEa+Nyrl624fJUMWRpINhnbr+oTdqJDE2WK0f/KFlut0tILZ19FONke8wz4d7bUeRptTggQqzV3nE4cUtfCUQB8U7LxRHe5kbYkrAfjY/gRTrAalRJ7vdFJ2Sz7i0m3gIFp2+32qX/fdu+fdJv+OH/CVPqXMes/ddDSdXkmr SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2018 18:58:01.6915 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 34a95010-72b2-49db-5fc1-08d602e1069f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5374 Subject: [dpdk-stable] [PATCH 17.11] net/qede/base: fix to clear HW indication X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 18:58:04 -0000 [ backported from upstream commit c8dbf6814312f12cd7fef7203ea9b40255ea1f76 ] VDMs may cause the was_error indication to be set after the driver clears it. Clear the indication after the internal FID_enable for the PF is set. Fixes: 60c78a5e258a ("net/qede/base: fix recovery from previous ungraceful exit") Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_dev.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c index 9affcbc..092606b 100644 --- a/drivers/net/qede/base/ecore_dev.c +++ b/drivers/net/qede/base/ecore_dev.c @@ -2423,9 +2423,8 @@ enum _ecore_status_t ecore_hw_init(struct ecore_dev *p_dev, } } - /* Log and clean previous pglue_b errors if such exist */ + /* Log and clear previous pglue_b errors if such exist */ ecore_pglueb_rbc_attn_handler(p_hwfn, p_hwfn->p_main_ptt); - ecore_pglueb_clear_err(p_hwfn, p_hwfn->p_main_ptt); /* Enable the PF's internal FID_enable in the PXP */ rc = ecore_pglueb_set_pfid_enable(p_hwfn, p_hwfn->p_main_ptt, @@ -2433,6 +2432,13 @@ enum _ecore_status_t ecore_hw_init(struct ecore_dev *p_dev, if (rc != ECORE_SUCCESS) goto load_err; + /* Clear the pglue_b was_error indication. + * In E4 it must be done after the BME and the internal + * FID_enable for the PF are set, since VDMs may cause the + * indication to be set again. + */ + ecore_pglueb_clear_err(p_hwfn, p_hwfn->p_main_ptt); + switch (load_code) { case FW_MSG_CODE_DRV_LOAD_ENGINE: rc = ecore_hw_init_common(p_hwfn, p_hwfn->p_main_ptt, -- 1.7.10.3