Re: [dpdk-stable] [PATCH 16.11] net/enic: add devarg to specify ingress VLAN rewrite mode

[Luca Boccassi <bluca@debian.org>]

On Wed, 2018-08-15 at 16:08 -0700, John Daley wrote:
> From: Hyong Youb Kim <hyonkim@cisco.com>
> 
> [ backported from upstream commit
> e39c2756e21ad50d5c7e119bb82732ef49af8ef7 ]
> 
> Add a new devarg "ig-vlan-rewrite" to allow the user to set
> non-default rewrite mode. The UCS VIC may add/remove/modify the VLAN
> header of an ingress packet depending on the ingress VLAN rewrite
> mode.
> 
> By default, the driver sets the pass-through mode, which tells the
> NIC
> "do not touch VLAN header and preserve it as is". This mode is
> usually
> sufficient, but can complicate deployments for certain environments.
> For example, OVS-DPDK in UCS blade environments may want to use
> "untag
> default VLAN mode", which removes the VLAN header from an ingress
> packet if it matches vNIC's default VLAN.
> 
> Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
> Reviewed-by: John Daley <johndale@cisco.com>
> Acked-by: Aaron Conole <aconole@redhat.com>
> ---
> 
> While not a "bug fix" we request this patch be applied to 16.11
> stable
> because it can simplify OVS configurations in UCS blade environments
> and also improve performance by allowing packets to flow through the
> faster no-VLAN path with "untag" specified in the new devarg.
> 
> The patch is completely non-invasive since it requires a devarg to
> enable it.

Hi John,

Thanks for the patch. Given I have already tagged 16.11.8-rc1 and
regression test has already started, is it OK to defer this patch to
the next point release? I can apply it to the branch immediately after
the final 16.11.8 tag is done.

-- 
Kind regards,
Luca Boccassi