From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 990652BA8 for ; Thu, 16 Aug 2018 12:05:44 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id w11-v6so1049465wrc.5 for ; Thu, 16 Aug 2018 03:05:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=HhaA6blZhJF40Hcw777gvRPLBIp9smOjVUJMNZ+WM9M=; b=GLfmCYsAH41sDTatsE8WQww0lLRN0MwgenDvDj061L2K27tSueFYIxhh0M8ZKpWein cUcN4RXqoXjqnPJ+75r3tv6//5d59fyjnLwG/U0LeM4/i5ZaMrKaRNradGFZ+xVQ9CPj MrXfW4W9Vel6WsaJhoOqD+X4Rafodeortz/TvKhEZxVKpP3exRtqPR8yUPnna5cQlzEJ LO1qOFYw49blSDcH5S5lcW2okCDE/Lx5dr+v4ynb+yk8B2uFtzIKGgESOYqMlj8msY/s a63qJqLsn6gYtFh4vkwcr1JcBdihVczVSn8Jd4OJzdTQhITuf5DiiRxgo5WwUm446bta OSHg== X-Gm-Message-State: AOUpUlFTAsOccYSDnyb0vDbSjfJDvxdMxzCc/IdjUQdLwaMw+8825/fV APbXIQ1ukRYULk6rslwidtk= X-Google-Smtp-Source: AA+uWPwnHktkpjY+MboG6ABw0Gf79oEZ3FeglyDDL6Vr/3OyMAcMv+Uj9QBOZGPMjBEtWGA9QP3sSQ== X-Received: by 2002:a5d:4f82:: with SMTP id d2-v6mr18531656wru.261.1534413944351; Thu, 16 Aug 2018 03:05:44 -0700 (PDT) Received: from localhost ([2001:1be0:110d:fcfe:41aa:5bfa:6cf3:7531]) by smtp.gmail.com with ESMTPSA id y206-v6sm825971wmg.45.2018.08.16.03.05.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Aug 2018 03:05:43 -0700 (PDT) Message-ID: <1534413942.5764.38.camel@debian.org> From: Luca Boccassi To: John Daley , stable@dpdk.org Cc: Hyong Youb Kim Date: Thu, 16 Aug 2018 11:05:42 +0100 In-Reply-To: <20180815230836.26042-1-johndale@cisco.com> References: <20180815230836.26042-1-johndale@cisco.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 16.11] net/enic: add devarg to specify ingress VLAN rewrite mode X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Aug 2018 10:05:45 -0000 On Wed, 2018-08-15 at 16:08 -0700, John Daley wrote: > From: Hyong Youb Kim >=20 > [ backported from upstream commit > e39c2756e21ad50d5c7e119bb82732ef49af8ef7 ] >=20 > Add a new devarg "ig-vlan-rewrite" to allow the user to set > non-default rewrite mode. The UCS VIC may add/remove/modify the VLAN > header of an ingress packet depending on the ingress VLAN rewrite > mode. >=20 > By default, the driver sets the pass-through mode, which tells the > NIC > "do not touch VLAN header and preserve it as is". This mode is > usually > sufficient, but can complicate deployments for certain environments. > For example, OVS-DPDK in UCS blade environments may want to use > "untag > default VLAN mode", which removes the VLAN header from an ingress > packet if it matches vNIC's default VLAN. >=20 > Signed-off-by: Hyong Youb Kim > Reviewed-by: John Daley > Acked-by: Aaron Conole > --- >=20 > While not a "bug fix" we request this patch be applied to 16.11 > stable > because it can simplify OVS configurations in UCS blade environments > and also improve performance by allowing packets to flow through the > faster no-VLAN path with "untag" specified in the new devarg. >=20 > The patch is completely non-invasive since it requires a devarg to > enable it. Hi John, Thanks for the patch. Given I have already tagged 16.11.8-rc1 and regression test has already started, is it OK to defer this patch to the next point release? I can apply it to the branch immediately after the final 16.11.8 tag is done. --=20 Kind regards, Luca Boccassi