From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 2C3584C96 for ; Fri, 9 Nov 2018 11:43:41 +0100 (CET) Received: by mail-wm1-f67.google.com with SMTP id t15-v6so1510874wmt.0 for ; Fri, 09 Nov 2018 02:43:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=15LuEG/wf/JuSgVGpZ6hx49ibRTmZUfN8ixBXvXthU8=; b=eCRz/ml15I5wdsMbv9PXOh5oKPe1k/Yg+srrIBu81IiBLisbl/sTU4D03zwm1Je3LF 4TY6Gbf1wVUadLaby/t9yvhTs2iWmLsFC39COy1Ez+G0hgMALAEN+CoZ40+IRFSi2H4t fBTcjoqhs7aasSXf38i8gzp4aysq/NqvU6hV+cbLKVvx2hdtbU/6xnaJeh3k3/bJL07J WoL3qlxkxyVKiYMgzkWnhYZj7f5CuVmIQfhcawafBiGWcp8Is/8406g3gjM/YharFA8Y I1NWqS+XBADpJzgd0RgBC5cbZJaCwy1SqtO2miVyfEbpTVxhwN67+/0RdCSKw04c9nAz dWDA== X-Gm-Message-State: AGRZ1gJYdsoUtbGPogxOrjO+ZsgP+oJDIHwKhMKXIJGb4dCf49HGfBrL 3LqoucemNgsBn12SPMUzpatdKaXrUmQ= X-Google-Smtp-Source: AJdET5dXiLmm6Rnpfw5gyF8vOS3IY0iVecPT48tBPjPc/AzoIB7h+fFsbqY42W8YjKQeUru+iQnamA== X-Received: by 2002:a1c:a4c1:: with SMTP id n184-v6mr4606730wme.106.1541760220532; Fri, 09 Nov 2018 02:43:40 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id w11-v6sm6767942wrr.96.2018.11.09.02.43.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Nov 2018 02:43:39 -0800 (PST) Message-ID: <1541760218.31208.33.camel@debian.org> From: Luca Boccassi To: Shijith Thotton Cc: Jianfeng Tan , Ferruh Yigit , Gregory Etelson , dpdk stable , Jeff Guo Date: Fri, 09 Nov 2018 10:43:38 +0000 In-Reply-To: <5872177c-4a4a-8c95-4f24-da786a36f317@caviumnetworks.com> References: <20181029125329.17729-20-bluca@debian.org> <20181108180111.25873-1-bluca@debian.org> <20181108180111.25873-14-bluca@debian.org> <1541700985.31208.25.camel@debian.org> <5872177c-4a4a-8c95-4f24-da786a36f317@caviumnetworks.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] patch 'igb_uio: issue FLR during open and release of device file' has been queued to LTS release 16.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2018 10:43:41 -0000 On Fri, 2018-11-09 at 09:32 +0000, Shijith Thotton wrote: >=20 > On 11/08/2018 11:46 PM, Luca Boccassi wrote: > > External Email > >=20 > > On Thu, 2018-11-08 at 18:01 +0000, Luca Boccassi wrote: > > > Hi, > > >=20 > > > FYI, your patch has been queued to LTS release 16.11.9 > > >=20 > > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable > > > yet. > > > It will be pushed if I get no objections before 11/10/18. So > > > please > > > shout if anyone has objections. > > >=20 > > > Also note that after the patch there's a diff of the upstream > > > commit > > > vs the patch applied > > > to the branch. If the code is different (ie: not only metadata > > > diffs), due for example to > > > a change in context or macro names, please double check it. > > >=20 > > > Thanks. > > >=20 > > > Luca Boccassi > > >=20 > > > --- > > > =C2=A0From 11bb826270d6feb3e810aec77a9252cf65b559a9 Mon Sep 17 > > > 00:00:00 > > > 2001 > > > From: Shijith Thotton > > > Date: Fri, 7 Jul 2017 16:43:51 +0530 > > > Subject: [PATCH] igb_uio: issue FLR during open and release of > > > device > > > file > > >=20 > > > [ upstream commit b58eedfc7dd57eef6d12e2c654a52c834f36084a ] > > >=20 > > > Set UIO info device file operations open and release. Call pci > > > reset > > > function inside open and release to clear device state at start > > > and > > > end. > > > Copied this behaviour from vfio_pci kernel module code. With this > > > patch, > > > it is not mandatory to issue FLR by PMD's during init and close. > > >=20 > > > Bus master enable and disable are added in open and release > > > respectively > > > to take care of device DMA. > > >=20 > > > Signed-off-by: Shijith Thotton > > m> > > > Reviewed-by: Jianfeng Tan > > > Acked-by: Ferruh Yigit > > > Acked-by: Gregory Etelson > > > --- > > > =C2=A0 lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 33 > > > +++++++++++++++++++++++ > > > =C2=A0 1 file changed, 33 insertions(+) > > >=20 > > > diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > > > b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > > > index 9f00f07ab..4be89ef86 100644 > > > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > > > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > > > @@ -170,6 +170,37 @@ igbuio_pci_irqhandler(int irq, struct > > > uio_info > > > *info) > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return IRQ_HANDLED; > > > =C2=A0 } > > >=20 > > > +/** > > > + * This gets called while opening uio device file. > > > + */ > > > +static int > > > +igbuio_pci_open(struct uio_info *info, struct inode *inode) > > > +{ > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct rte_uio_pci_dev *udev =3D info-= >priv; > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct pci_dev *dev =3D udev->pdev; > > > + > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pci_reset_function(dev); > > > + > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/* set bus master, which was cleared b= y the reset function > > > */ > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pci_set_master(dev); > > > + > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return 0; > > > +} > > > + > > > +static int > > > +igbuio_pci_release(struct uio_info *info, struct inode *inode) > > > +{ > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct rte_uio_pci_dev *udev =3D info-= >priv; > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct pci_dev *dev =3D udev->pdev; > > > + > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/* stop the device from further DMA */ > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pci_clear_master(dev); > > > + > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pci_reset_function(dev); > > > + > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return 0; > > > +} > > > + > > > =C2=A0 #ifdef CONFIG_XEN_DOM0 > > > =C2=A0 static int > > > =C2=A0 igbuio_dom0_mmap_phys(struct uio_info *info, struct > > > vm_area_struct > > > *vma) > > > @@ -370,6 +401,8 @@ igbuio_pci_probe(struct pci_dev *dev, const > > > struct pci_device_id *id) > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0udev->info.version =3D "0.1= "; > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0udev->info.handler =3D igbu= io_pci_irqhandler; > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0udev->info.irqcontrol =3D i= gbuio_pci_irqcontrol; > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0udev->info.open =3D igbuio_pci_open; > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0udev->info.release =3D igbuio_pci_rele= ase; > > > =C2=A0 #ifdef CONFIG_XEN_DOM0 > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/* check if the driver run = on Xen Dom0 */ > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (xen_initial_domain()) > >=20 > > Hi, > >=20 > > I've picked up b58eedfc7dd57eef6d12e2c654a52c834f36084a as it is a > > prerequisite for 70efa4116420b6f7a0734711dd603d3024366c79 as far as > > I > > can see, let me know if I should not or do it differently please. > >=20 >=20 > Hi Luca, >=20 > Above patch was fixed in following two patches. Please pick them as > well. >=20 > 369db3a igb_uio: remove device reset in release > f73b38e igb_uio: remove device reset in open >=20 > Thanks, > Shijith Done, thank you for bringing that up. --=20 Kind regards, Luca Boccassi