From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 2DFC25B32 for ; Wed, 14 Nov 2018 12:07:53 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id i73-v6so9727542wmd.5 for ; Wed, 14 Nov 2018 03:07:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=WdIiqtarr3bHZD2iHCOgVcxjesJsZXzxd7jK92mjmKY=; b=SjbuuIpZGKfD8mVXvZNHsflcwaY1NgwdVYaZTZVGt2GQgo6Sk6+5Ljhpv89KdYoYgv 4QloaR1BS0xX2Ny++eD2Ly3d+AgGRnjcnankiHgrawguN1XL/3t+q3nieeSSoWlk8JY1 t1tfWzWN38TBBFJOZgJFxlNSmlwz95F2o2s5dcCBvoBZg9rmUATWarOrCTqRpppYFAu0 AUQPz2MECnsFxf8kR3mZXmO/wnAPaqo0JCSdHHWKfb2EiBU963uvp9JR0Ue66K9GIVeI 5+ioBPix2CxOpVklnwnCuzOSN4oukAuP4s98eoV86kFnA3NE5s3ZzAKeMRxMoEQeffl7 75eg== X-Gm-Message-State: AGRZ1gKfrff3ItdwHe1Gfp7z/p6IW84BDYp0PhXCqVv/vTKsVozzxg7U yBZ7AGhEMylBljB8hWoMHAM= X-Google-Smtp-Source: AJdET5eFFjuY3edWpDVHKtU+T7eL1yN00bUjewL3ELKqOmnJKcrOi5uI0JzmYWpORQzUj/zKXGAAEQ== X-Received: by 2002:a1c:2d90:: with SMTP id t138-v6mr1779321wmt.0.1542193672527; Wed, 14 Nov 2018 03:07:52 -0800 (PST) Received: from localhost ([2001:1be0:110d:fcfe:70c5:32f6:c5b6:39e6]) by smtp.gmail.com with ESMTPSA id a4-v6sm13590411wrr.71.2018.11.14.03.07.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Nov 2018 03:07:51 -0800 (PST) Message-ID: <1542193670.11515.8.camel@debian.org> From: Luca Boccassi To: Alejandro Lucero Cc: "Burakov, Anatoly" , dpdk stable Date: Wed, 14 Nov 2018 11:07:50 +0000 In-Reply-To: References: <20181029125329.17729-20-bluca@debian.org> <20181108180111.25873-1-bluca@debian.org> <20181108180111.25873-11-bluca@debian.org> <1542047709.11515.6.camel@debian.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] patch 'bus/pci: compare kernel driver instead of interrupt handler' has been queued to LTS release 16.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 11:07:53 -0000 On Wed, 2018-11-14 at 10:02 +0000, Alejandro Lucero wrote: > Hi Luca, >=20 > On Mon, Nov 12, 2018 at 6:35 PM Luca Boccassi > wrote: >=20 > > On Thu, 2018-11-08 at 18:01 +0000, Luca Boccassi wrote: > > > Hi, > > >=20 > > > FYI, your patch has been queued to LTS release 16.11.9 > > >=20 > > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable > > > yet. > > > It will be pushed if I get no objections before 11/10/18. So > > > please > > > shout if anyone has objections. > > >=20 > > > Also note that after the patch there's a diff of the upstream > > > commit > > > vs the patch applied > > > to the branch. If the code is different (ie: not only metadata > > > diffs), due for example to > > > a change in context or macro names, please double check it. > > >=20 > > > Thanks. > > >=20 > > > Luca Boccassi > > >=20 > > > --- > > > From 0df09603d47c1e38140b747baa8b712e70f5df51 Mon Sep 17 00:00:00 > > > 2001 > > > From: Alejandro Lucero > > > Date: Thu, 25 Oct 2018 11:49:28 +0100 > > > Subject: [PATCH] bus/pci: compare kernel driver instead of > > > interrupt > > > handler > > >=20 > > > [ upstream commit 630deed612ca382f48a3ef4b65dfc74b7cd09cf9 ] > > >=20 > > > Invoking the right pci read/write functions is based on interrupt > > > handler type. However, this is not configured for secondary > > > processes > > > precluding to use those functions. > > >=20 > > > This patch fixes the issue using the driver name the device is > > > bound > > > to instead. > > >=20 > > > Fixes: 632b2d1deeed ("eal: provide functions to access PCI > > > config") > > >=20 > > > Signed-off-by: Alejandro Lucero > > > Acked-by: Anatoly Burakov > > > --- > > > =C2=A0lib/librte_eal/linuxapp/eal/eal_pci.c | 33 ++++++++++++--------= - > > > ---- > > > -- > > > =C2=A01 file changed, 15 insertions(+), 18 deletions(-) > > >=20 > > > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c > > > b/lib/librte_eal/linuxapp/eal/eal_pci.c > > > index 02ec24150..85c7b3139 100644 > > > --- a/lib/librte_eal/linuxapp/eal/eal_pci.c > > > +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c > > > @@ -36,6 +36,7 @@ > > >=20 > > > =C2=A0#include > > > =C2=A0#include > > > +#include > >=20 > > Self-facepalm: this cannot work, as ethdev depends on eal. v2 > > inlined > > below. > >=20 > > Alejandro and Anatoly, please have a quick look. Thanks! > >=20 > >=20 >=20 > This patch is only necessary for PMDs which secondary support > requires > these pci read/write accesses. > AFAIK, it is just NFP PMD having this need, and multiprocess support > will > be added in 19.02, so it is not a big problem to not apply this > patch. Hi, So I can drop both this and 939e666bc0796940ae91535002e1a1c9196eae02 ? --=20 Kind regards, Luca Boccassi