From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id BDD524CE4 for ; Thu, 15 Nov 2018 18:34:06 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id u9-v6so22112002wrr.0 for ; Thu, 15 Nov 2018 09:34:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:mime-version; bh=KEr7VnLDzwVlb2n5lXVrK6UNVE8/XKN6r/TUiE0HuCQ=; b=NeYfSuDz+i4z+RcNxYROGr+Reai/GNUp4ZEf67euLLU4hRhXsP4iV1RaIn02OrlXYi lp6sZG+vD09q1b/kJfj0VR+PXUHivdAB569B58jMNZaVQa3Z0fkOehKO0KK+MG/7zjjA /n2eVEE+9bJsjJs7ftjPNZJIVXkkd+lGrVY/KRWwuZjs6ktHtwutVQ98Hmqr6w0uQa7g GO+q6WLVMBaUyeRThbGLHZJtnDq/Tm7Rvzfh0FQyHz24cCTiLgV9oMzMS54K/eYTMtrd SSmB74O2sPa4QI7GN/bHuLV3H4KRjicBB5spd+heZO/hoy2mzrsuAb+yJYwAQ2LXq6Ou ejiQ== X-Gm-Message-State: AGRZ1gK0JFD1GSVGzEcG7UtqERv5ooBrmOYLb/ZgY8qfEHd1/tDpVXEl 6zW+Cc9hDp8JmUJ675vSPSU= X-Google-Smtp-Source: AJdET5cEmqoI3Ez7B8X3sl/JLcpF0nquykcDeTeCVY8XZnrtc573tvLbj1k4vnNGKu2RuyIK7qsOlA== X-Received: by 2002:adf:8141:: with SMTP id 59-v6mr6674307wrm.128.1542303246275; Thu, 15 Nov 2018 09:34:06 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id y19sm8601439wmj.2.2018.11.15.09.34.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Nov 2018 09:34:05 -0800 (PST) Message-ID: <1542303244.11515.22.camel@debian.org> From: Luca Boccassi To: Alejandro Lucero Cc: "Burakov, Anatoly" , dpdk stable Date: Thu, 15 Nov 2018 17:34:04 +0000 In-Reply-To: References: <20181029125329.17729-20-bluca@debian.org> <20181108180111.25873-1-bluca@debian.org> <20181108180111.25873-11-bluca@debian.org> <1542047709.11515.6.camel@debian.org> <1542193670.11515.8.camel@debian.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Subject: Re: [dpdk-stable] patch 'bus/pci: compare kernel driver instead of interrupt handler' has been queued to LTS release 16.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2018 17:34:06 -0000 On Wed, 2018-11-14 at 11:36 +0000, Alejandro Lucero wrote: > On Wed, Nov 14, 2018 at 11:07 AM Luca Boccassi > wrote: >=20 > > On Wed, 2018-11-14 at 10:02 +0000, Alejandro Lucero wrote: > > > Hi Luca, > > >=20 > > > On Mon, Nov 12, 2018 at 6:35 PM Luca Boccassi > > > wrote: > > >=20 > > > > On Thu, 2018-11-08 at 18:01 +0000, Luca Boccassi wrote: > > > > > Hi, > > > > >=20 > > > > > FYI, your patch has been queued to LTS release 16.11.9 > > > > >=20 > > > > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-sta > > > > > ble > > > > > yet. > > > > > It will be pushed if I get no objections before 11/10/18. So > > > > > please > > > > > shout if anyone has objections. > > > > >=20 > > > > > Also note that after the patch there's a diff of the upstream > > > > > commit > > > > > vs the patch applied > > > > > to the branch. If the code is different (ie: not only > > > > > metadata > > > > > diffs), due for example to > > > > > a change in context or macro names, please double check it. > > > > >=20 > > > > > Thanks. > > > > >=20 > > > > > Luca Boccassi > > > > >=20 > > > > > --- > > > > > From 0df09603d47c1e38140b747baa8b712e70f5df51 Mon Sep 17 > > > > > 00:00:00 > > > > > 2001 > > > > > From: Alejandro Lucero > > > > > Date: Thu, 25 Oct 2018 11:49:28 +0100 > > > > > Subject: [PATCH] bus/pci: compare kernel driver instead of > > > > > interrupt > > > > > handler > > > > >=20 > > > > > [ upstream commit 630deed612ca382f48a3ef4b65dfc74b7cd09cf9 ] > > > > >=20 > > > > > Invoking the right pci read/write functions is based on > > > > > interrupt > > > > > handler type. However, this is not configured for secondary > > > > > processes > > > > > precluding to use those functions. > > > > >=20 > > > > > This patch fixes the issue using the driver name the device > > > > > is > > > > > bound > > > > > to instead. > > > > >=20 > > > > > Fixes: 632b2d1deeed ("eal: provide functions to access PCI > > > > > config") > > > > >=20 > > > > > Signed-off-by: Alejandro Lucero > > > > om> > > > > > Acked-by: Anatoly Burakov > > > > > --- > > > > > =C2=A0lib/librte_eal/linuxapp/eal/eal_pci.c | 33 ++++++++++++----= - > > > > > ---- > > > > > ---- > > > > > -- > > > > > =C2=A01 file changed, 15 insertions(+), 18 deletions(-) > > > > >=20 > > > > > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c > > > > > b/lib/librte_eal/linuxapp/eal/eal_pci.c > > > > > index 02ec24150..85c7b3139 100644 > > > > > --- a/lib/librte_eal/linuxapp/eal/eal_pci.c > > > > > +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c > > > > > @@ -36,6 +36,7 @@ > > > > >=20 > > > > > =C2=A0#include > > > > > =C2=A0#include > > > > > +#include > > > >=20 > > > > Self-facepalm: this cannot work, as ethdev depends on eal. v2 > > > > inlined > > > > below. > > > >=20 > > > > Alejandro and Anatoly, please have a quick look. Thanks! > > > >=20 > > > >=20 > > >=20 > > > This patch is only necessary for PMDs which secondary support > > > requires > > > these pci read/write accesses. > > > AFAIK, it is just NFP PMD having this need, and multiprocess > > > support > > > will > > > be added in 19.02, so it is not a big problem to not apply this > > > patch. > >=20 > > Hi, > >=20 > > So I can drop both this and > > 939e666bc0796940ae91535002e1a1c9196eae02 ? > >=20 > >=20 >=20 > I can not find what you refer to. Which commit is that one? Sorry, copy-pasta, I meant: a38eafedda1de14c9fd7219e769e89e4aec92a45 bus/pci: fix config r/w access --=20 Kind regards, Luca Boccassi