From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id A824F1B17F for ; Mon, 10 Dec 2018 16:11:22 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 7B0091000A6; Mon, 10 Dec 2018 15:11:20 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 10 Dec 2018 07:11:17 -0800 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Mon, 10 Dec 2018 07:11:17 -0800 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id wBAFBFnF014774; Mon, 10 Dec 2018 15:11:15 GMT Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id E3BCA1616F0; Mon, 10 Dec 2018 15:11:15 +0000 (GMT) From: Andrew Rybchenko To: CC: Ivan Malov Date: Mon, 10 Dec 2018 15:10:56 +0000 Message-ID: <1544454656-5339-6-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1544454656-5339-1-git-send-email-arybchenko@solarflare.com> References: <1544454656-5339-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24274.006 X-TM-AS-Result: Yes-5.218900-4.000000-11 X-TMASE-MatchedRID: GUpzN83LG3hF/TNFimjSuMAmcZEx8XHJ1KoSW5Ji1XvxxaAXDrCns/G3 99+Ui/td5ClDmDzXYwvy/spf2Nj76EILcl5xUj1WtOGPzYU8VIKBHKTJ+sfXGY1Oeo4wEgnhU8S +/fFbuZOCxS3MiMgVuffJcVgFkoiei2/jyLqyhF0D2WXLXdz+AUqAhuLHn5fEZ0IzKseMTeffPZ 9FevqYPeLzNWBegCW2wgn7iDBesS15zdAzex5xZqmPNVwAE2GbDPUgc41L+55/zuiSfejipsHme Kk+tcbo4G4CbVse5uMXtDTzgL7NoLaVVJfdWh5iknkF0Gwsb/hLJMisUDI/6A== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 11-5.218900-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24274.006 X-MDID: 1544454681-ojA9p5yt2XdD Subject: [dpdk-stable] [PATCH 17.11 6/6] net/sfc: allow to query RSS key and HF when RSS is disabled X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 15:11:23 -0000 From: Ivan Malov [ backported from upstream commit 662e382244fb29d8bf03113524a139541e10123f ] If global RSS is not enabled in the multiqueue mode setting, it will not be possible to change RSS configuration. However, querying default RSS settings should be possible in any case since it may be needed by RTE flow API users to find out what RSS settings will be used by default for a flow rule with RSS action if custom RSS key and hash function choice are not specified. Fixes: 63ab5e0c8fda ("net/sfc: use zero RSS channels as disabled RSS indicator") Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index f4e880d..819177a 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -1229,9 +1229,6 @@ if (sa->rss_support != EFX_RX_SCALE_EXCLUSIVE) return -ENOTSUP; - if (sa->rss_channels == 0) - return -EINVAL; - sfc_adapter_lock(sa); /* -- 1.8.3.1