From: AndyPei <andy.pei@intel.com>
To: andy.pei@intel.com
Cc: David Marchand <david.marchand@redhat.com>, stable@dpdk.org
Subject: [dpdk-stable] [PATCH] devtools: fix symbol check when adding experimental section
Date: Wed, 12 Dec 2018 21:29:24 +0800 [thread overview]
Message-ID: <1544621364-21648-1-git-send-email-andy.pei@intel.com> (raw)
From: David Marchand <david.marchand@redhat.com>
The incriminated commit did relax the condition to catch all sections
but dropped the + removal which can trigger false detection of the
special EXPERIMENTAL section when adding symbols and the section in the
same patch.
Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol section")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
---
devtools/check-symbol-change.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 4b8d9f3..020da7e 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -31,6 +31,7 @@ build_map_changes()
# Triggering this rule sets in_sec to 1, which actives the
# symbol rule below
/^.*{/ {
+ gsub("+", "");
if (in_map == 1) {
sec=$(NF-1); in_sec=1;
}
--
1.8.3.1
next reply other threads:[~2018-12-12 5:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 13:29 AndyPei [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-04-17 10:17 Hemant Agrawal
[not found] <1543978226-23480-1-git-send-email-gfree.wind@vip.163.com>
2018-12-05 2:50 ` gfree.wind
[not found] <1543977934-23205-1-git-send-email-gfree.wind@vip.163.com>
2018-12-05 2:45 ` gfree.wind
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544621364-21648-1-git-send-email-andy.pei@intel.com \
--to=andy.pei@intel.com \
--cc=david.marchand@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).