From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-eopbgr770072.outbound.protection.outlook.com [40.107.77.72]) by dpdk.org (Postfix) with ESMTP id 88D741B61F for ; Wed, 19 Dec 2018 01:42:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ce7Xai/mxp0iXyIkS+YTo3fjY99FVlhN8SRY9/vYHNk=; b=GPjKPtGCsTSzENIsuo42eMDPyrS2rn7BTPuX69PScgZJIL2/2EUrcxD2IHBzxDRyp3deaiJtkAWWLZFFag0wsOJZ08josiBcD9rUl7DYLNyhwhq47xyCsjQxzaI3vhHB1Hdu5MUmTeM8EWkhP8NzkftphgPCFcTbtW3cW0MYh4Y= Received: from BYAPR07MB5365.namprd07.prod.outlook.com (20.177.125.18) by BYAPR07MB4311.namprd07.prod.outlook.com (52.135.223.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1425.22; Wed, 19 Dec 2018 00:42:40 +0000 Received: from BYAPR07MB5365.namprd07.prod.outlook.com ([fe80::514:ce1d:4236:9b9]) by BYAPR07MB5365.namprd07.prod.outlook.com ([fe80::514:ce1d:4236:9b9%3]) with mapi id 15.20.1425.021; Wed, 19 Dec 2018 00:42:40 +0000 From: "Mody, Rasesh" To: "stable@dpdk.org" CC: "Shaikh, Shahed" , "yskoh@mellanox.com" , Dept-Eng DPDK Dev Thread-Topic: [PATCH 17.11 2/5] net/qede: fix flow director for IPv6 filter Thread-Index: AQHUlzO/513erhQLikGJGKZp27FLmQ== Date: Wed, 19 Dec 2018 00:42:40 +0000 Message-ID: <1545180127-3202-2-git-send-email-rasesh.mody@cavium.com> References: <1545180127-3202-1-git-send-email-rasesh.mody@cavium.com> In-Reply-To: <1545180127-3202-1-git-send-email-rasesh.mody@cavium.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: BYAPR05CA0098.namprd05.prod.outlook.com (2603:10b6:a03:e0::39) To BYAPR07MB5365.namprd07.prod.outlook.com (2603:10b6:a03:64::18) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Rasesh.Mody@cavium.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [198.186.1.5] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR07MB4311; 6:zbaPGNvManno8BlqLWc7ZGiXg5tHheHIqteKXQuzc4gNBXHRsYWts1feL4BWcraIqDQx9uHX9gN46/5eUgDDvw7WrUOVZeWfduiCpDRD+RoOnm+1EIFlEBZ4EZoGwzX/hVbkzj3iO3782PBw4ScZIngQyR2+85xIA33r/iyE25km6QC0A3SK9cD7fENFMOwjr2aOLwp+BfzuU5qWfZZBe4NYn9R0X8CYft//x3GJ9m2uhNfb8UJChLTpSXG66xvcszDOW6QleJtwQojjP8zB+fR2X0MbmEuSgxad5IXwtKDbaGeRVMovP+iIh2572z3Pnble1dy7BplWDZqq4miT6yi9WNcyCuOo1sHEA0jkqL9nCF1S8UvHAixajC3jFHU1iQy8Plc6p7Pr7l1xWORPG/B8lOniVVJFJ4/dFSOao0LWeQzjwzI8NQGRWcZykPBusH3ooUsNpd6u3Ra68BH5jg==; 5:qCCDrzb9nFfe+diiRr/AqQBdVwdbAeeiX08yadMA9s9sC/CfnUPWndFp3bPPPUtrZVrYIC1dDDS3gIToz2WfFo8k2oPMO2K1XUxS7qyXoKiNiV59NU+9h1Qi2ZNj/iCuvcmQaBe71Qz8QJMGblI0jw3RxJy0AhxfYRXBeBe//nM=; 7:PJcJPxsQ1p/fhyVIOyNsw2fW9lesdxUjOyCzWM6QOTsYx7WrLLWYP4x2EswWhvYYFockRSOBqfjBBIkletJPNiGUcAHR4RAjueEHCWEfcOHNPG5ga77ZqFvWdwW8fYGh5IIbIlfylTRhmApU1FGdNg== x-ms-office365-filtering-correlation-id: 08c36fb4-f28d-4ea3-5f79-08d6654ae13f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BYAPR07MB4311; x-ms-traffictypediagnostic: BYAPR07MB4311: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(999002)(6040522)(2401047)(5005006)(8121501046)(823302103)(3231475)(944501520)(52105112)(93006095)(93001095)(3002001)(10201501046)(148016)(149066)(150057)(6041310)(20161123562045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:BYAPR07MB4311; BCL:0; PCL:0; RULEID:; SRVR:BYAPR07MB4311; x-forefront-prvs: 0891BC3F3D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(346002)(396003)(366004)(376002)(189003)(199004)(68736007)(6486002)(305945005)(6436002)(36756003)(25786009)(66066001)(72206003)(76176011)(99286004)(102836004)(7736002)(26005)(6506007)(386003)(71200400001)(71190400001)(256004)(86362001)(478600001)(8936002)(316002)(2616005)(11346002)(8676002)(4326008)(476003)(81156014)(1730700003)(81166006)(107886003)(186003)(53936002)(54906003)(5640700003)(2501003)(97736004)(14454004)(6512007)(2351001)(6916009)(52116002)(2906002)(106356001)(105586002)(3846002)(446003)(5660300001)(6116002)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR07MB4311; H:BYAPR07MB5365.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: osq4qMolv98cGkVQLJHBr3/6dB+JFQ3PeISZFhX7gc1IsQABRNwlkGZxC+BFUrsKlSpKP3urBcs849F86K6yypyurFYzGjELmfXPRDDjjAWgtn3KJvOkXYTdVQl2YgEKS7c1KbgDp2It3yOuW/Yt7ZcPtca4eyz1OUayTkcpfwObaDqXCL8BsuzwolYF2kmnQeWBBLcrMZz0Sh/dfdrz6UGI4DlJ6Ocfuz4e69l/CuD4RmzO0dkGyBf64CoaSeN5r5E14K3h2i3BZbCenyIGrmiXHfUfADuWoq1+Cea7MO8Q5sl5n3ubk/X5Ghhp1lo8 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08c36fb4-f28d-4ea3-5f79-08d6654ae13f X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2018 00:42:40.5359 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4311 Subject: [dpdk-stable] [PATCH 17.11 2/5] net/qede: fix flow director for IPv6 filter X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 00:42:43 -0000 From: Shahed Shaikh [ backported from upstream commit 7ffef6292b6d49fabbbc120663e433442146e263 = ] - PMD does not fill vtc_flow field of IPv6 header while constructing a packet for IPv6 filter. Hence filter was not getting applied properly. - IPv6 addresses got swapped while copying src and dst addresses. - Same issue with UDP and TCP port ids. Fixes: 622075356e8f ("net/qede: support ntuple and flow director filter") Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_fdir.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/qede_fdir.c b/drivers/net/qede/qede_fdir.c index 0515256..050b737 100644 --- a/drivers/net/qede/qede_fdir.c +++ b/drivers/net/qede/qede_fdir.c @@ -18,6 +18,7 @@ #define QEDE_FDIR_IP_DEFAULT_VERSION_IHL (IP_VERSION | IP_HDRLEN) #define QEDE_FDIR_TCP_DEFAULT_DATAOFF (0x50) #define QEDE_FDIR_IPV4_DEF_TTL (64) +#define QEDE_FDIR_IPV6_DEFAULT_VTC_FLOW (0x60000000) =20 /* Sum of length of header types of L2, L3, L4. * L2 : ether_hdr + vlan_hdr + vxlan_hdr @@ -340,18 +341,21 @@ void qede_fdir_dealloc_resc(struct rte_eth_dev *eth_d= ev) ip6->proto =3D input->flow.ipv6_flow.proto ? input->flow.ipv6_flow.proto : next_proto[input->flow_type]; - rte_memcpy(&ip6->src_addr, &input->flow.ipv6_flow.dst_ip, + ip6->vtc_flow =3D + rte_cpu_to_be_32(QEDE_FDIR_IPV6_DEFAULT_VTC_FLOW); + rte_memcpy(&ip6->src_addr, &input->flow.ipv6_flow.src_ip, IPV6_ADDR_LEN); - rte_memcpy(&ip6->dst_addr, &input->flow.ipv6_flow.src_ip, + rte_memcpy(&ip6->dst_addr, &input->flow.ipv6_flow.dst_ip, IPV6_ADDR_LEN); len +=3D sizeof(struct ipv6_hdr); + params->ipv6 =3D true; =20 raw_pkt =3D (uint8_t *)buff; /* UDP */ if (input->flow_type =3D=3D RTE_ETH_FLOW_NONFRAG_IPV6_UDP) { udp =3D (struct udp_hdr *)(raw_pkt + len); - udp->src_port =3D input->flow.udp6_flow.dst_port; - udp->dst_port =3D input->flow.udp6_flow.src_port; + udp->src_port =3D input->flow.udp6_flow.src_port; + udp->dst_port =3D input->flow.udp6_flow.dst_port; len +=3D sizeof(struct udp_hdr); params->udp =3D true; } else { /* TCP */ --=20 1.7.10.3