patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] build: fix incorrect variable name in error message
@ 2019-01-10 10:29 Bruce Richardson
  2019-01-10 13:10 ` Luca Boccassi
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2019-01-10 10:29 UTC (permalink / raw)
  To: dev; +Cc: Bruce Richardson, stable

The variable name in the error message had an extra '_' which caused
an actual meson error when the message would otherwise be printed to
give meaningful information about what was going wrong.

Fixes: 203b61dc5e18 ("build: improve error message for missing dependency")
CC: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/meson.build b/lib/meson.build
index a2dd52e17..93d7901d4 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -79,7 +79,7 @@ foreach l:libraries
 			foreach d:deps
 				if not is_variable('shared_rte_' + d)
 					error('Missing dependency ' + d +
-						' for library ' + lib_name)
+						' for library ' + libname)
 				endif
 				shared_deps += [get_variable('shared_rte_' + d)]
 				static_deps += [get_variable('static_rte_' + d)]
-- 
2.20.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] build: fix incorrect variable name in error message
  2019-01-10 10:29 [dpdk-stable] [PATCH] build: fix incorrect variable name in error message Bruce Richardson
@ 2019-01-10 13:10 ` Luca Boccassi
  2019-01-14 11:05   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Luca Boccassi @ 2019-01-10 13:10 UTC (permalink / raw)
  To: Bruce Richardson, dev; +Cc: stable

On Thu, 2019-01-10 at 10:29 +0000, Bruce Richardson wrote:
> The variable name in the error message had an extra '_' which caused
> an actual meson error when the message would otherwise be printed to
> give meaningful information about what was going wrong.
> 
> Fixes: 203b61dc5e18 ("build: improve error message for missing
> dependency")
> CC: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  lib/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/meson.build b/lib/meson.build
> index a2dd52e17..93d7901d4 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -79,7 +79,7 @@ foreach l:libraries
>  			foreach d:deps
>  				if not is_variable('shared_rte_' +
> d)
>  					error('Missing dependency '
> + d +
> -						' for library ' +
> lib_name)
> +						' for library ' +
> libname)
>  				endif
>  				shared_deps +=
> [get_variable('shared_rte_' + d)]
>  				static_deps +=
> [get_variable('static_rte_' + d)]

Acked-by: Luca Boccassi <bluca@debian.org>

-- 
Kind regards,
Luca Boccassi

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] build: fix incorrect variable name in error message
  2019-01-10 13:10 ` Luca Boccassi
@ 2019-01-14 11:05   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2019-01-14 11:05 UTC (permalink / raw)
  To: Bruce Richardson; +Cc: dev, Luca Boccassi, stable

10/01/2019 14:10, Luca Boccassi:
> On Thu, 2019-01-10 at 10:29 +0000, Bruce Richardson wrote:
> > The variable name in the error message had an extra '_' which caused
> > an actual meson error when the message would otherwise be printed to
> > give meaningful information about what was going wrong.
> > 
> > Fixes: 203b61dc5e18 ("build: improve error message for missing
> > dependency")
> > CC: stable@dpdk.org
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Acked-by: Luca Boccassi <bluca@debian.org>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-01-14 11:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-10 10:29 [dpdk-stable] [PATCH] build: fix incorrect variable name in error message Bruce Richardson
2019-01-10 13:10 ` Luca Boccassi
2019-01-14 11:05   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).