From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10058.outbound.protection.outlook.com [40.107.1.58]) by dpdk.org (Postfix) with ESMTP id D90001B450 for ; Sun, 13 Jan 2019 09:42:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R5I9fj22HNewSZXAtQ6Omr0sDbUDquVaSC8ErD3QFDQ=; b=cRC72Utze1m+7RPbgfoRvNbOgJdGXbIrpbQbD1UxeX7T9RWt1KXcFPslr7rs/xbizhA0YAq9Qm9TfxdQgT0G2KrIeyV9JVUgm94QOigV56QCmo53T+KhbMuguGdaYxNGjBB/tTDBB2gr29Nwz2Oi40gccuoTX7gfBn0aPW5qy8o= Received: from AM6PR05MB5926.eurprd05.prod.outlook.com (20.179.2.27) by AM6PR05MB6199.eurprd05.prod.outlook.com (20.178.95.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.18; Sun, 13 Jan 2019 08:42:08 +0000 Received: from AM6PR05MB5926.eurprd05.prod.outlook.com ([fe80::ccd7:b679:e405:93fb]) by AM6PR05MB5926.eurprd05.prod.outlook.com ([fe80::ccd7:b679:e405:93fb%4]) with mapi id 15.20.1516.019; Sun, 13 Jan 2019 08:42:08 +0000 From: Raslan Darawsheh To: Yongseok Koh CC: "stable@dpdk.org" Thread-Topic: [17.11] net/tap: fix reported number of Tx packets Thread-Index: AQHUqxveirlyhoE8LEqDZrXnL6n2Og== Date: Sun, 13 Jan 2019 08:42:08 +0000 Message-ID: <1547368916-22381-1-git-send-email-rasland@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: CWLP265CA0107.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:51::23) To AM6PR05MB5926.eurprd05.prod.outlook.com (2603:10a6:20b:a9::27) authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [37.142.13.130] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR05MB6199; 6:KH6cP5kivw53QyCtGvVimbpbY6ivjqV5TFhBDhO6Q7es223MXNP1ImTwA+beFYyLCFBIkcU4aDo0v67Ak1Uawt7Y+GypKkGuxKCdmnDOHSaZdYVm9KPgo/e25GikHVPwdqgrM0kH0juxthxMYuTZz64khHunv+SaWW1wAFtQGEKi4WjaPVSxk9ymspvOKc/KW4vNLavh0643QDw5Ug1Agk4EWUrigCGTO4dA8x53FASddcZfCWB5RsiCTG6Hqe6MLl7vMAOu4+7LMWBYwrGKuWKG6K+fS6mxzB/puQ5lp5492LRpa/h5FCY8VPG5+pIFmbt41pSPEG8cTBD2/Iq15o/A3K58/ckXdlkppDx+s6pL1kBATVtvY6PuaWWjmwRkzvXQvHGnaSjx11J2SfVs5KT4DmCf7p7GG5XTuGYKnmxcv/4ySVRSDcRMP9Z8sbWWmcobnrGp6VQUUs9ZT/yiSQ==; 5:VJych+zo4u1ubWklZfY6wBkIR6Fu6gYIoS9Avq38T8XzVk6fGUp32QyT2yuoHq99SNjZkVZafCLyHYnZWzLCYMh7uuzHE4R+g9qzz+fuumxY/2+UYBYQHfjb6C+7Hg8Kx1Efguvdf2W0nxrJYp7iR3A6XdfajmnHiF3amXxVnwUS0aRQNVmHQKpSyLjtuTGNZsc6DPJprgFOFrhjw6ygBw==; 7:Sl1pkFkkjUSCpj6RV08tlCiQkEvzv8mZUnDMnTbw+aOomDJBb8CK6v8LakFFu23579nmYRF9bM3NgrgXxaiLs/2AKSAglMsWCAK4xBulfknKGMBtXKFWo2rhjg9OGSOpuUVkDL+mAU982Zj0zcO/AA== x-ms-office365-filtering-correlation-id: 4fb7a05b-f90d-484d-44e6-08d679330093 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR05MB6199; x-ms-traffictypediagnostic: AM6PR05MB6199: x-microsoft-antispam-prvs: x-forefront-prvs: 0916FC3A18 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(396003)(39850400004)(376002)(366004)(136003)(199004)(189003)(6436002)(5660300001)(6486002)(106356001)(316002)(105586002)(8936002)(68736007)(486006)(37006003)(476003)(186003)(26005)(102836004)(50226002)(2906002)(2616005)(81156014)(8676002)(81166006)(6636002)(305945005)(66066001)(7736002)(99286004)(6506007)(3846002)(52116002)(6116002)(36756003)(478600001)(256004)(71200400001)(14444005)(6512007)(53936002)(71190400001)(14454004)(4326008)(6862004)(97736004)(25786009)(386003)(86362001)(575784001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR05MB6199; H:AM6PR05MB5926.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: MtUXQXcBoWXhX+wMIEL0X065cW46UguLj8FD69VZgghIYuDSDnQyVy5aK57O4p7dBT7vGSkdNrLDj1sRz1fG/Wg6y2GTQ5jHVj3JA5vQQ1DmE1i4ftfDa2AIdf1Mwpg/MCreJsYi89BbpjECIVSwJ5mKmQqosUVijqFskS7yjXE7PTWujGWNQeN1uXVX4usDC9x7aNx1OPfombGB3bdAGNbJ2+pS9ljpPPtpnn3Qwx67497FE8b6MVk+9Fe46UoADsDHQ95DgpAvi9LIqsplJibZZsicje6bBD+s+yrunD+opNJVpxIkX4g9R7yUnolR+RWKPfV8SGdA8egaY33+3xbfFx54+isHPCu6AuxYSUF4/fkaFHbSh4HMFtj1dI3oIAIcfnQJsoKsMgH/nWxmP6BKal0sD7h16YT9J6tFUR0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4fb7a05b-f90d-484d-44e6-08d679330093 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2019 08:42:07.6316 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB6199 Subject: [dpdk-stable] [17.11] net/tap: fix reported number of Tx packets X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jan 2019 08:42:10 -0000 When writev fails to send packets it doesn't update the number of Tx packets, but it still num_tx is updated. The value that should be returned is the actual number of sent packets which is num_packets. Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") CC: stable@dpdk.org Signed-off-by: Raslan Darawsheh Acked-by: Keith Wiles --- drivers/net/tap/rte_eth_tap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 466624a..50757ef 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -488,7 +488,7 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint1= 6_t nb_pkts) txq->stats.errs +=3D nb_pkts - num_tx; txq->stats.obytes +=3D num_tx_bytes; =20 - return num_tx; + return num_packets; } =20 static const char * --=20 2.7.4