From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B94C729AC for ; Thu, 17 Jan 2019 06:08:45 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2019 21:08:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,488,1539673200"; d="scan'208";a="108891391" Received: from unknown (HELO broadwell-dev-4.localdomain) ([10.224.122.193]) by orsmga006.jf.intel.com with ESMTP; 16 Jan 2019 21:08:43 -0800 From: Nikhil Rao To: yskoh@mellanox.com Cc: Nikhil Rao , stable@dpdk.org Date: Thu, 17 Jan 2019 10:17:11 +0530 Message-Id: <1547700431-145205-1-git-send-email-nikhil.rao@intel.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-stable] [PATCH 17.11] eventdev: fix unlock in Rx adapter X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 05:08:46 -0000 [ backported from upstream commit e846cfdec34cc58b9a1a2438d313028246b8e986 ] In the eth Rx adapter SW service function, move the return to after the spinlock unlock. Coverity issue: 302857 Fixes: a66a83744667 ("eventdev: fix Rx SW adapter stop") Cc: stable@dpdk.org Signed-off-by: Nikhil Rao Acked-by: Jerin Jacob --- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c index d5c3fd5..de4cf73 100644 --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c @@ -545,8 +545,8 @@ static uint16_t gcd_u16(uint16_t a, uint16_t b) if (rte_spinlock_trylock(&rx_adapter->rx_lock) == 0) return 0; if (!rx_adapter->rxa_started) { - return 0; rte_spinlock_unlock(&rx_adapter->rx_lock); + return 0; } eth_rx_poll(rx_adapter); rte_spinlock_unlock(&rx_adapter->rx_lock); -- 1.8.3.1