patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Andrew Rybchenko <arybchenko@solarflare.com>
To: <stable@dpdk.org>
Cc: Igor Romanov <igor.romanov@oktetlabs.ru>
Subject: [dpdk-stable] [PATCH 17.11] net/sfc/base: fix Tx descriptor max number check
Date: Mon, 11 Mar 2019 08:44:15 +0000	[thread overview]
Message-ID: <1552293856-24222-2-git-send-email-arybchenko@solarflare.com> (raw)
In-Reply-To: <1552293856-24222-1-git-send-email-arybchenko@solarflare.com>

From: Igor Romanov <igor.romanov@oktetlabs.ru>

[ backported from upstream commit 31c2379bad4157ca0beb05c9d2b49395b68f373b ]

Fix check of maximum descriptor number (compare with maximum Tx
descriptor number instead of maximum EVQ events number).

Fixes: f7dc06bf35f2 ("net/sfc/base: import 5xxx/6xxx family support")

Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 drivers/net/sfc/base/efx_tx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/sfc/base/efx_tx.c b/drivers/net/sfc/base/efx_tx.c
index ceb2920..ee0ec9f 100644
--- a/drivers/net/sfc/base/efx_tx.c
+++ b/drivers/net/sfc/base/efx_tx.c
@@ -910,7 +910,8 @@
 	EFSYS_ASSERT(ISP2(encp->enc_txq_max_ndescs));
 	EFX_STATIC_ASSERT(ISP2(EFX_TXQ_MINNDESCS));
 
-	if (!ISP2(n) || (n < EFX_TXQ_MINNDESCS) || (n > EFX_EVQ_MAXNEVS)) {
+	if (!ISP2(n) ||
+	    (n < EFX_TXQ_MINNDESCS) || (n > encp->enc_txq_max_ndescs)) {
 		rc = EINVAL;
 		goto fail1;
 	}
-- 
1.8.3.1

  reply	other threads:[~2019-03-11  8:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-11  8:44 [dpdk-stable] [PATCH 17.11] net/sfc: pass HW Tx queue index on creation Andrew Rybchenko
2019-03-11  8:44 ` Andrew Rybchenko [this message]
2019-03-12 22:15   ` [dpdk-stable] [PATCH 17.11] net/sfc/base: fix Tx descriptor max number check Yongseok Koh
2019-03-11  8:44 ` [dpdk-stable] [PATCH 17.11] net/sfc: fix port ID log Andrew Rybchenko
2019-03-12 22:15   ` Yongseok Koh
2019-03-12 22:15 ` [dpdk-stable] [PATCH 17.11] net/sfc: pass HW Tx queue index on creation Yongseok Koh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1552293856-24222-2-git-send-email-arybchenko@solarflare.com \
    --to=arybchenko@solarflare.com \
    --cc=igor.romanov@oktetlabs.ru \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).