* [dpdk-stable] [PATCH 17.11] net/sfc: pass HW Tx queue index on creation
@ 2019-03-11 8:44 Andrew Rybchenko
2019-03-11 8:44 ` [dpdk-stable] [PATCH 17.11] net/sfc/base: fix Tx descriptor max number check Andrew Rybchenko
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Andrew Rybchenko @ 2019-03-11 8:44 UTC (permalink / raw)
To: stable
[ backported from upstream commit 7928b0fdf8f790b6178ad91cf41ee2f9df10e707 ]
Software indexes are PMD internal and should not be passed outside.
Right now SW and HW indexes of the Tx queue match, so it is just
a cosmetic fix.
Fixes: dbdc82416b72 ("net/sfc: factor out libefx-based Tx datapath")
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/sfc_tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/sfc/sfc_tx.c b/drivers/net/sfc/sfc_tx.c
index 9b1e654..72245cf 100644
--- a/drivers/net/sfc/sfc_tx.c
+++ b/drivers/net/sfc/sfc_tx.c
@@ -449,7 +449,7 @@
flags |= EFX_TXQ_FATSOV2;
}
- rc = efx_tx_qcreate(sa->nic, sw_index, 0, &txq->mem,
+ rc = efx_tx_qcreate(sa->nic, txq->hw_index, 0, &txq->mem,
txq_info->entries, 0 /* not used on EF10 */,
flags, evq->common,
&txq->common, &desc_index);
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-stable] [PATCH 17.11] net/sfc/base: fix Tx descriptor max number check
2019-03-11 8:44 [dpdk-stable] [PATCH 17.11] net/sfc: pass HW Tx queue index on creation Andrew Rybchenko
@ 2019-03-11 8:44 ` Andrew Rybchenko
2019-03-12 22:15 ` Yongseok Koh
2019-03-11 8:44 ` [dpdk-stable] [PATCH 17.11] net/sfc: fix port ID log Andrew Rybchenko
2019-03-12 22:15 ` [dpdk-stable] [PATCH 17.11] net/sfc: pass HW Tx queue index on creation Yongseok Koh
2 siblings, 1 reply; 6+ messages in thread
From: Andrew Rybchenko @ 2019-03-11 8:44 UTC (permalink / raw)
To: stable; +Cc: Igor Romanov
From: Igor Romanov <igor.romanov@oktetlabs.ru>
[ backported from upstream commit 31c2379bad4157ca0beb05c9d2b49395b68f373b ]
Fix check of maximum descriptor number (compare with maximum Tx
descriptor number instead of maximum EVQ events number).
Fixes: f7dc06bf35f2 ("net/sfc/base: import 5xxx/6xxx family support")
Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/base/efx_tx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/sfc/base/efx_tx.c b/drivers/net/sfc/base/efx_tx.c
index ceb2920..ee0ec9f 100644
--- a/drivers/net/sfc/base/efx_tx.c
+++ b/drivers/net/sfc/base/efx_tx.c
@@ -910,7 +910,8 @@
EFSYS_ASSERT(ISP2(encp->enc_txq_max_ndescs));
EFX_STATIC_ASSERT(ISP2(EFX_TXQ_MINNDESCS));
- if (!ISP2(n) || (n < EFX_TXQ_MINNDESCS) || (n > EFX_EVQ_MAXNEVS)) {
+ if (!ISP2(n) ||
+ (n < EFX_TXQ_MINNDESCS) || (n > encp->enc_txq_max_ndescs)) {
rc = EINVAL;
goto fail1;
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-stable] [PATCH 17.11] net/sfc/base: fix Tx descriptor max number check
2019-03-11 8:44 ` [dpdk-stable] [PATCH 17.11] net/sfc/base: fix Tx descriptor max number check Andrew Rybchenko
@ 2019-03-12 22:15 ` Yongseok Koh
0 siblings, 0 replies; 6+ messages in thread
From: Yongseok Koh @ 2019-03-12 22:15 UTC (permalink / raw)
To: Andrew Rybchenko; +Cc: dpdk stable, Igor Romanov
> On Mar 11, 2019, at 1:44 AM, Andrew Rybchenko <arybchenko@solarflare.com> wrote:
>
> From: Igor Romanov <igor.romanov@oktetlabs.ru>
>
> [ backported from upstream commit 31c2379bad4157ca0beb05c9d2b49395b68f373b ]
>
> Fix check of maximum descriptor number (compare with maximum Tx
> descriptor number instead of maximum EVQ events number).
>
> Fixes: f7dc06bf35f2 ("net/sfc/base: import 5xxx/6xxx family support")
>
> Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
applied to stable/17.11
Thanks,
Yongseok
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH 17.11] net/sfc: fix port ID log
2019-03-11 8:44 [dpdk-stable] [PATCH 17.11] net/sfc: pass HW Tx queue index on creation Andrew Rybchenko
2019-03-11 8:44 ` [dpdk-stable] [PATCH 17.11] net/sfc/base: fix Tx descriptor max number check Andrew Rybchenko
@ 2019-03-11 8:44 ` Andrew Rybchenko
2019-03-12 22:15 ` Yongseok Koh
2019-03-12 22:15 ` [dpdk-stable] [PATCH 17.11] net/sfc: pass HW Tx queue index on creation Yongseok Koh
2 siblings, 1 reply; 6+ messages in thread
From: Andrew Rybchenko @ 2019-03-11 8:44 UTC (permalink / raw)
To: stable; +Cc: Ivan Malov
From: Ivan Malov <ivan.malov@oktetlabs.ru>
[ backported from upstream commit 5a88b9b3f0ca0578779c3efad2e362c8770353b4 ]
Log port ID as 16-bit unsigned integer.
Fixes: f8244c6399d9 ("ethdev: increase port id range")
Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/net/sfc/sfc_log.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/sfc/sfc_log.h b/drivers/net/sfc/sfc_log.h
index b1a9df4..0c82b93 100644
--- a/drivers/net/sfc/sfc_log.h
+++ b/drivers/net/sfc/sfc_log.h
@@ -38,7 +38,8 @@
const struct sfc_adapter *__sa = (sa); \
\
RTE_LOG(level, PMD, \
- RTE_FMT("sfc_efx " PCI_PRI_FMT " #%" PRIu8 ": " \
+ RTE_FMT("PMD: sfc_efx " \
+ PCI_PRI_FMT " #%" PRIu16 \
RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
__sa->pci_addr.domain, \
__sa->pci_addr.bus, \
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-stable] [PATCH 17.11] net/sfc: fix port ID log
2019-03-11 8:44 ` [dpdk-stable] [PATCH 17.11] net/sfc: fix port ID log Andrew Rybchenko
@ 2019-03-12 22:15 ` Yongseok Koh
0 siblings, 0 replies; 6+ messages in thread
From: Yongseok Koh @ 2019-03-12 22:15 UTC (permalink / raw)
To: Andrew Rybchenko; +Cc: dpdk stable, Ivan Malov
> On Mar 11, 2019, at 1:44 AM, Andrew Rybchenko <arybchenko@solarflare.com> wrote:
>
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
>
> [ backported from upstream commit 5a88b9b3f0ca0578779c3efad2e362c8770353b4 ]
>
> Log port ID as 16-bit unsigned integer.
>
> Fixes: f8244c6399d9 ("ethdev: increase port id range")
>
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
applied to stable/17.11
Thanks,
Yongseok
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [PATCH 17.11] net/sfc: pass HW Tx queue index on creation
2019-03-11 8:44 [dpdk-stable] [PATCH 17.11] net/sfc: pass HW Tx queue index on creation Andrew Rybchenko
2019-03-11 8:44 ` [dpdk-stable] [PATCH 17.11] net/sfc/base: fix Tx descriptor max number check Andrew Rybchenko
2019-03-11 8:44 ` [dpdk-stable] [PATCH 17.11] net/sfc: fix port ID log Andrew Rybchenko
@ 2019-03-12 22:15 ` Yongseok Koh
2 siblings, 0 replies; 6+ messages in thread
From: Yongseok Koh @ 2019-03-12 22:15 UTC (permalink / raw)
To: Andrew Rybchenko; +Cc: stable
> On Mar 11, 2019, at 1:44 AM, Andrew Rybchenko <arybchenko@solarflare.com> wrote:
>
> [ backported from upstream commit 7928b0fdf8f790b6178ad91cf41ee2f9df10e707 ]
>
> Software indexes are PMD internal and should not be passed outside.
> Right now SW and HW indexes of the Tx queue match, so it is just
> a cosmetic fix.
>
> Fixes: dbdc82416b72 ("net/sfc: factor out libefx-based Tx datapath")
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
applied to stable/17.11
Thanks,
Yongseok
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-12 22:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-11 8:44 [dpdk-stable] [PATCH 17.11] net/sfc: pass HW Tx queue index on creation Andrew Rybchenko
2019-03-11 8:44 ` [dpdk-stable] [PATCH 17.11] net/sfc/base: fix Tx descriptor max number check Andrew Rybchenko
2019-03-12 22:15 ` Yongseok Koh
2019-03-11 8:44 ` [dpdk-stable] [PATCH 17.11] net/sfc: fix port ID log Andrew Rybchenko
2019-03-12 22:15 ` Yongseok Koh
2019-03-12 22:15 ` [dpdk-stable] [PATCH 17.11] net/sfc: pass HW Tx queue index on creation Yongseok Koh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).