* [dpdk-stable] [PATCH] raw/ifpga: modify log output.
@ 2019-03-14 9:47 Andy Pei
2019-03-19 3:09 ` Xu, Rosen
[not found] ` <1553069009-64692-1-git-send-email-andy.pei@intel.com>
0 siblings, 2 replies; 7+ messages in thread
From: Andy Pei @ 2019-03-14 9:47 UTC (permalink / raw)
To: dev; +Cc: andy.pei, rosen.xu, stable
print function name in IFPGA_RAWDEV_PMD_FUNC_TRACE.
The original code just print ">>", no other useful infomation is
printed.
A new line goes after every IFPGA log.
Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
Cc: rosen.xu@intel.com
Cc: andy.pei@intel.com
Cc: stable@dpdk.org
Signed-off-by: Andy Pei <andy.pei@intel.com>
---
drivers/raw/ifpga_rawdev/ifpga_rawdev.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
index c7759b8..52fca63 100644
--- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
+++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h
@@ -8,10 +8,11 @@
extern int ifpga_rawdev_logtype;
#define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \
- rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt, \
+ rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt "\n", \
##args)
-#define IFPGA_RAWDEV_PMD_FUNC_TRACE() IFPGA_RAWDEV_PMD_LOG(DEBUG, ">>")
+#define IFPGA_RAWDEV_PMD_FUNC_TRACE() \
+ IFPGA_RAWDEV_PMD_LOG(DEBUG, "%s()", __func__)
#define IFPGA_RAWDEV_PMD_DEBUG(fmt, args...) \
IFPGA_RAWDEV_PMD_LOG(DEBUG, fmt, ## args)
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-stable] [PATCH] raw/ifpga: modify log output. 2019-03-14 9:47 [dpdk-stable] [PATCH] raw/ifpga: modify log output Andy Pei @ 2019-03-19 3:09 ` Xu, Rosen 2019-03-19 7:56 ` Pei, Andy [not found] ` <1553069009-64692-1-git-send-email-andy.pei@intel.com> 1 sibling, 1 reply; 7+ messages in thread From: Xu, Rosen @ 2019-03-19 3:09 UTC (permalink / raw) To: Pei, Andy, dev; +Cc: stable Hi, This macro IFPGA_RAWDEV_PMD_FUNC_TRACE is very useful for developer. To enable this macro, pls follow these guides: 1. enable gcc debug mode such as options: EXTRA_CFLAGS='-O0 -g' 2. add this option in testpmd startup: --log-level=driver.raw.init,8 > -----Original Message----- > From: Pei, Andy > Sent: Thursday, March 14, 2019 17:48 > To: dev@dpdk.org > Cc: Pei, Andy <andy.pei@intel.com>; Xu, Rosen <rosen.xu@intel.com>; > stable@dpdk.org > Subject: [PATCH] raw/ifpga: modify log output. > > print function name in IFPGA_RAWDEV_PMD_FUNC_TRACE. > The original code just print ">>", no other useful infomation is printed. > A new line goes after every IFPGA log. > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > Cc: rosen.xu@intel.com > Cc: andy.pei@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Andy Pei <andy.pei@intel.com> > --- > drivers/raw/ifpga_rawdev/ifpga_rawdev.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > index c7759b8..52fca63 100644 > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > @@ -8,10 +8,11 @@ > extern int ifpga_rawdev_logtype; > > #define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \ > - rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt, \ > + rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt "\n", > \ > ##args) > > -#define IFPGA_RAWDEV_PMD_FUNC_TRACE() > IFPGA_RAWDEV_PMD_LOG(DEBUG, ">>") > +#define IFPGA_RAWDEV_PMD_FUNC_TRACE() \ > + IFPGA_RAWDEV_PMD_LOG(DEBUG, "%s()", __func__) > > #define IFPGA_RAWDEV_PMD_DEBUG(fmt, args...) \ > IFPGA_RAWDEV_PMD_LOG(DEBUG, fmt, ## args) > -- > 1.8.3.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [PATCH] raw/ifpga: modify log output. 2019-03-19 3:09 ` Xu, Rosen @ 2019-03-19 7:56 ` Pei, Andy 2019-03-19 10:40 ` Xu, Rosen 0 siblings, 1 reply; 7+ messages in thread From: Pei, Andy @ 2019-03-19 7:56 UTC (permalink / raw) To: Xu, Rosen, dev; +Cc: stable Hi, Rosen: Yes. Original code just print "ifpga:>>". After the patch, function name will be printed out ,like "ifpga:XXXX()", and every log info will goes in a new line. -----Original Message----- From: Xu, Rosen Sent: Tuesday, March 19, 2019 11:09 AM To: Pei, Andy <andy.pei@intel.com>; dev@dpdk.org Cc: stable@dpdk.org Subject: RE: [PATCH] raw/ifpga: modify log output. Hi, This macro IFPGA_RAWDEV_PMD_FUNC_TRACE is very useful for developer. To enable this macro, pls follow these guides: 1. enable gcc debug mode such as options: EXTRA_CFLAGS='-O0 -g' 2. add this option in testpmd startup: --log-level=driver.raw.init,8 > -----Original Message----- > From: Pei, Andy > Sent: Thursday, March 14, 2019 17:48 > To: dev@dpdk.org > Cc: Pei, Andy <andy.pei@intel.com>; Xu, Rosen <rosen.xu@intel.com>; > stable@dpdk.org > Subject: [PATCH] raw/ifpga: modify log output. > > print function name in IFPGA_RAWDEV_PMD_FUNC_TRACE. > The original code just print ">>", no other useful infomation is printed. > A new line goes after every IFPGA log. > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > Cc: rosen.xu@intel.com > Cc: andy.pei@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Andy Pei <andy.pei@intel.com> > --- > drivers/raw/ifpga_rawdev/ifpga_rawdev.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > index c7759b8..52fca63 100644 > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > @@ -8,10 +8,11 @@ > extern int ifpga_rawdev_logtype; > > #define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \ > - rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt, \ > + rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt "\n", > \ > ##args) > > -#define IFPGA_RAWDEV_PMD_FUNC_TRACE() IFPGA_RAWDEV_PMD_LOG(DEBUG, > ">>") > +#define IFPGA_RAWDEV_PMD_FUNC_TRACE() \ > + IFPGA_RAWDEV_PMD_LOG(DEBUG, "%s()", __func__) > > #define IFPGA_RAWDEV_PMD_DEBUG(fmt, args...) \ > IFPGA_RAWDEV_PMD_LOG(DEBUG, fmt, ## args) > -- > 1.8.3.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [PATCH] raw/ifpga: modify log output. 2019-03-19 7:56 ` Pei, Andy @ 2019-03-19 10:40 ` Xu, Rosen 2019-03-20 7:36 ` Pei, Andy 0 siblings, 1 reply; 7+ messages in thread From: Xu, Rosen @ 2019-03-19 10:40 UTC (permalink / raw) To: Pei, Andy, dev; +Cc: stable Hi Andy, Get your point, and my reply is online. > -----Original Message----- > From: Pei, Andy > Sent: Tuesday, March 19, 2019 15:56 > To: Xu, Rosen <rosen.xu@intel.com>; dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [PATCH] raw/ifpga: modify log output. > > Hi, Rosen: > > Yes. > Original code just print "ifpga:>>". > After the patch, function name will be printed out ,like "ifpga:XXXX()", and > every log info will goes in a new line. > > -----Original Message----- > From: Xu, Rosen > Sent: Tuesday, March 19, 2019 11:09 AM > To: Pei, Andy <andy.pei@intel.com>; dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [PATCH] raw/ifpga: modify log output. > > Hi, > > This macro IFPGA_RAWDEV_PMD_FUNC_TRACE is very useful for developer. > To enable this macro, pls follow these guides: > 1. enable gcc debug mode such as options: EXTRA_CFLAGS='-O0 -g' > 2. add this option in testpmd startup: --log-level=driver.raw.init,8 > > > -----Original Message----- > > From: Pei, Andy > > Sent: Thursday, March 14, 2019 17:48 > > To: dev@dpdk.org > > Cc: Pei, Andy <andy.pei@intel.com>; Xu, Rosen <rosen.xu@intel.com>; > > stable@dpdk.org > > Subject: [PATCH] raw/ifpga: modify log output. > > > > print function name in IFPGA_RAWDEV_PMD_FUNC_TRACE. > > The original code just print ">>", no other useful infomation is printed. > > A new line goes after every IFPGA log. > > > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > > Cc: rosen.xu@intel.com > > Cc: andy.pei@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Andy Pei <andy.pei@intel.com> > > --- > > drivers/raw/ifpga_rawdev/ifpga_rawdev.h | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > > b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > > index c7759b8..52fca63 100644 > > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > > @@ -8,10 +8,11 @@ > > extern int ifpga_rawdev_logtype; > > > > #define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \ > > - rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt, \ > > + rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt "\n", > > \ > > ##args) What about add '__func__' to macro ' IFPGA_RAWDEV_PMD_LOG'? #define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \ rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "%s(): " fmt "\n", \ __func__, ##args) > > -#define IFPGA_RAWDEV_PMD_FUNC_TRACE() > IFPGA_RAWDEV_PMD_LOG(DEBUG, > > ">>") > > +#define IFPGA_RAWDEV_PMD_FUNC_TRACE() \ > > + IFPGA_RAWDEV_PMD_LOG(DEBUG, "%s()", __func__) > > > > #define IFPGA_RAWDEV_PMD_DEBUG(fmt, args...) \ > > IFPGA_RAWDEV_PMD_LOG(DEBUG, fmt, ## args) > > -- > > 1.8.3.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [PATCH] raw/ifpga: modify log output. 2019-03-19 10:40 ` Xu, Rosen @ 2019-03-20 7:36 ` Pei, Andy 0 siblings, 0 replies; 7+ messages in thread From: Pei, Andy @ 2019-03-20 7:36 UTC (permalink / raw) To: Xu, Rosen, dev; +Cc: stable Yes, I will do this way in v2. -----Original Message----- From: Xu, Rosen Sent: Tuesday, March 19, 2019 6:41 PM To: Pei, Andy <andy.pei@intel.com>; dev@dpdk.org Cc: stable@dpdk.org Subject: RE: [PATCH] raw/ifpga: modify log output. Hi Andy, Get your point, and my reply is online. > -----Original Message----- > From: Pei, Andy > Sent: Tuesday, March 19, 2019 15:56 > To: Xu, Rosen <rosen.xu@intel.com>; dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [PATCH] raw/ifpga: modify log output. > > Hi, Rosen: > > Yes. > Original code just print "ifpga:>>". > After the patch, function name will be printed out ,like > "ifpga:XXXX()", and every log info will goes in a new line. > > -----Original Message----- > From: Xu, Rosen > Sent: Tuesday, March 19, 2019 11:09 AM > To: Pei, Andy <andy.pei@intel.com>; dev@dpdk.org > Cc: stable@dpdk.org > Subject: RE: [PATCH] raw/ifpga: modify log output. > > Hi, > > This macro IFPGA_RAWDEV_PMD_FUNC_TRACE is very useful for developer. > To enable this macro, pls follow these guides: > 1. enable gcc debug mode such as options: EXTRA_CFLAGS='-O0 -g' > 2. add this option in testpmd startup: --log-level=driver.raw.init,8 > > > -----Original Message----- > > From: Pei, Andy > > Sent: Thursday, March 14, 2019 17:48 > > To: dev@dpdk.org > > Cc: Pei, Andy <andy.pei@intel.com>; Xu, Rosen <rosen.xu@intel.com>; > > stable@dpdk.org > > Subject: [PATCH] raw/ifpga: modify log output. > > > > print function name in IFPGA_RAWDEV_PMD_FUNC_TRACE. > > The original code just print ">>", no other useful infomation is printed. > > A new line goes after every IFPGA log. > > > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > > Cc: rosen.xu@intel.com > > Cc: andy.pei@intel.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Andy Pei <andy.pei@intel.com> > > --- > > drivers/raw/ifpga_rawdev/ifpga_rawdev.h | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > > b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > > index c7759b8..52fca63 100644 > > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > > @@ -8,10 +8,11 @@ > > extern int ifpga_rawdev_logtype; > > > > #define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \ > > - rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt, \ > > + rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt > > +"\n", > > \ > > ##args) What about add '__func__' to macro ' IFPGA_RAWDEV_PMD_LOG'? #define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \ rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "%s(): " fmt "\n", \ __func__, ##args) > > -#define IFPGA_RAWDEV_PMD_FUNC_TRACE() > IFPGA_RAWDEV_PMD_LOG(DEBUG, > > ">>") > > +#define IFPGA_RAWDEV_PMD_FUNC_TRACE() \ > > + IFPGA_RAWDEV_PMD_LOG(DEBUG, "%s()", __func__) > > > > #define IFPGA_RAWDEV_PMD_DEBUG(fmt, args...) \ > > IFPGA_RAWDEV_PMD_LOG(DEBUG, fmt, ## args) > > -- > > 1.8.3.1 ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <1553069009-64692-1-git-send-email-andy.pei@intel.com>]
* Re: [dpdk-stable] [PATCH v2] raw/ifpga: modify log output [not found] ` <1553069009-64692-1-git-send-email-andy.pei@intel.com> @ 2019-03-20 8:16 ` Xu, Rosen 2019-03-20 11:11 ` Ferruh Yigit 0 siblings, 1 reply; 7+ messages in thread From: Xu, Rosen @ 2019-03-20 8:16 UTC (permalink / raw) To: Pei, Andy, dev; +Cc: stable > -----Original Message----- > From: Pei, Andy > Sent: Wednesday, March 20, 2019 16:03 > To: dev@dpdk.org > Cc: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com>; > stable@dpdk.org > Subject: [PATCH v2] raw/ifpga: modify log output > > print function name in ifpga log and a new line goes after every IFPGA log. > > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") > Cc: rosen.xu@intel.com > Cc: andy.pei@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Andy Pei <andy.pei@intel.com> > --- > drivers/raw/ifpga_rawdev/ifpga_rawdev.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > index c7759b8..234ce36 100644 > --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h > @@ -8,8 +8,8 @@ > extern int ifpga_rawdev_logtype; > > #define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \ > - rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt, \ > - ##args) > + rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "%s(): " fmt "\n", \ > + __func__, ##args) > > #define IFPGA_RAWDEV_PMD_FUNC_TRACE() > IFPGA_RAWDEV_PMD_LOG(DEBUG, ">>") > > -- > 1.8.3.1 Reviewed-by: Rosen Xu <rosen.xu@intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-stable] [PATCH v2] raw/ifpga: modify log output 2019-03-20 8:16 ` [dpdk-stable] [PATCH v2] " Xu, Rosen @ 2019-03-20 11:11 ` Ferruh Yigit 0 siblings, 0 replies; 7+ messages in thread From: Ferruh Yigit @ 2019-03-20 11:11 UTC (permalink / raw) To: Xu, Rosen, Pei, Andy, dev; +Cc: stable On 3/20/2019 8:16 AM, Xu, Rosen wrote: > > >> -----Original Message----- >> From: Pei, Andy >> Sent: Wednesday, March 20, 2019 16:03 >> To: dev@dpdk.org >> Cc: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com>; >> stable@dpdk.org >> Subject: [PATCH v2] raw/ifpga: modify log output >> >> print function name in ifpga log and a new line goes after every IFPGA log. >> >> Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") >> Cc: rosen.xu@intel.com >> Cc: andy.pei@intel.com >> Cc: stable@dpdk.org >> >> Signed-off-by: Andy Pei <andy.pei@intel.com> >> --- >> drivers/raw/ifpga_rawdev/ifpga_rawdev.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h >> b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h >> index c7759b8..234ce36 100644 >> --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.h >> +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.h >> @@ -8,8 +8,8 @@ >> extern int ifpga_rawdev_logtype; >> >> #define IFPGA_RAWDEV_PMD_LOG(level, fmt, args...) \ >> - rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "ifgpa: " fmt, \ >> - ##args) >> + rte_log(RTE_LOG_ ## level, ifpga_rawdev_logtype, "%s(): " fmt "\n", \ >> + __func__, ##args) >> >> #define IFPGA_RAWDEV_PMD_FUNC_TRACE() >> IFPGA_RAWDEV_PMD_LOG(DEBUG, ">>") >> >> -- >> 1.8.3.1 > > Reviewed-by: Rosen Xu <rosen.xu@intel.com> > Hi Rosen, Andy, I don't see the v2 in dev or stable mail list & patchwork. Can you please re-send it? ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-03-20 11:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-14 9:47 [dpdk-stable] [PATCH] raw/ifpga: modify log output Andy Pei
2019-03-19 3:09 ` Xu, Rosen
2019-03-19 7:56 ` Pei, Andy
2019-03-19 10:40 ` Xu, Rosen
2019-03-20 7:36 ` Pei, Andy
[not found] ` <1553069009-64692-1-git-send-email-andy.pei@intel.com>
2019-03-20 8:16 ` [dpdk-stable] [PATCH v2] " Xu, Rosen
2019-03-20 11:11 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).