From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 61D95A00E6
for <public@inbox.dpdk.org>; Wed, 20 Mar 2019 17:43:12 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id ED2F01B160;
Wed, 20 Mar 2019 17:43:11 +0100 (CET)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
by dpdk.org (Postfix) with ESMTP id 1DAE04D27;
Wed, 20 Mar 2019 17:43:07 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
20 Mar 2019 09:43:06 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,249,1549958400"; d="scan'208";a="124327832"
Received: from silpixa00380299.ir.intel.com ([10.237.223.68])
by orsmga007.jf.intel.com with ESMTP; 20 Mar 2019 09:43:05 -0700
From: Andrius Sirvys <andrius.sirvys@intel.com>
To: dev@dpdk.org,
Kevin Laatz <kevin.laatz@intel.com>
Cc: stable@dpdk.org, Andrius Sirvys <andrius.sirvys@intel.com>,
ciara.power@intel.com
Date: Wed, 20 Mar 2019 16:43:01 +0000
Message-Id: <1553100181-32934-1-git-send-email-andrius.sirvys@intel.com>
X-Mailer: git-send-email 2.7.4
Subject: [dpdk-stable] [PATCH] usertools: replace unsafe input function
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
LGTM static code analysis tool reports that the function 'input' is
unsafe. Changed to use raw_input which then converts it using
ast.literal_eval() which is safe.
Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry")
Cc: ciara.power@intel.com
Signed-off-by: Andrius Sirvys <andrius.sirvys@intel.com>
---
usertools/dpdk-telemetry-client.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
index ce0c7a9..c3ba77d 100755
--- a/usertools/dpdk-telemetry-client.py
+++ b/usertools/dpdk-telemetry-client.py
@@ -72,7 +72,7 @@ def requestMetrics(self): # Requests metrics for given client
def repeatedlyRequestMetrics(self, sleep_time): # Recursively requests metrics for given client
print("\nPlease enter the number of times you'd like to continuously request Metrics:")
- n_requests = int(input("\n:"))
+ n_requests = int(ast.literal_eval(raw_input("\n:")))
print("\033[F") #Removes the user input from screen, cleans it up
print("\033[K")
for i in range(n_requests):
@@ -87,7 +87,7 @@ def interactiveMenu(self, sleep_time): # Creates Interactive menu within the scr
print("[3] Unregister client")
try:
- self.choice = int(input("\n:"))
+ self.choice = int(ast.literal_eval(raw_input("\n:")))
print("\033[F") #Removes the user input for screen, cleans it up
print("\033[K")
if self.choice == 1:
--
2.7.4