From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com,
bernard.iremonger@intel.com, ramirose@gmail.com,
arybchenko@solarflare.com, maxime.coquelin@redhat.com,
ferruh.yigit@intel.com, stable@dpdk.org
Subject: [dpdk-stable] [PATCH v5 3/4] app/testpmd: remove useless casts on statistics
Date: Mon, 25 Mar 2019 09:51:45 +0100 [thread overview]
Message-ID: <1553503906-1508-4-git-send-email-david.marchand@redhat.com> (raw)
In-Reply-To: <1553503906-1508-1-git-send-email-david.marchand@redhat.com>
Caught by code review while investigating the fwd stats display code.
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
Changelog since v2:
- focused on useless casts only
- Cc'd stable
---
app/test-pmd/testpmd.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 05a3dce..c78d524 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -1376,7 +1376,7 @@ struct extmem_param {
printf(" RX-packets: %-14"PRIu64" RX-dropped: %-14"PRIu64"RX-total: "
"%-"PRIu64"\n",
stats->ipackets, stats->imissed,
- (uint64_t) (stats->ipackets + stats->imissed));
+ stats->ipackets + stats->imissed);
if (cur_fwd_eng == &csum_fwd_engine)
printf(" Bad-ipcsum: %-14"PRIu64" Bad-l4csum: %-14"PRIu64"Bad-outer-l4csum: %-14"PRIu64"\n",
@@ -1390,13 +1390,13 @@ struct extmem_param {
printf(" TX-packets: %-14"PRIu64" TX-dropped: %-14"PRIu64"TX-total: "
"%-"PRIu64"\n",
stats->opackets, port->tx_dropped,
- (uint64_t) (stats->opackets + port->tx_dropped));
+ stats->opackets + port->tx_dropped);
}
else {
printf(" RX-packets: %14"PRIu64" RX-dropped:%14"PRIu64" RX-total:"
"%14"PRIu64"\n",
stats->ipackets, stats->imissed,
- (uint64_t) (stats->ipackets + stats->imissed));
+ stats->ipackets + stats->imissed);
if (cur_fwd_eng == &csum_fwd_engine)
printf(" Bad-ipcsum:%14"PRIu64" Bad-l4csum:%14"PRIu64" Bad-outer-l4csum: %-14"PRIu64"\n",
@@ -1411,7 +1411,7 @@ struct extmem_param {
printf(" TX-packets: %14"PRIu64" TX-dropped:%14"PRIu64" TX-total:"
"%14"PRIu64"\n",
stats->opackets, port->tx_dropped,
- (uint64_t) (stats->opackets + port->tx_dropped));
+ stats->opackets + port->tx_dropped);
}
#ifdef RTE_TEST_PMD_RECORD_BURST_STATS
--
1.8.3.1
prev parent reply other threads:[~2019-03-25 8:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1550158972-21895-1-git-send-email-david.marchand@redhat.com>
[not found] ` <1552318522-18777-1-git-send-email-david.marchand@redhat.com>
2019-03-11 15:35 ` [dpdk-stable] [PATCH v2 1/4] app/testpmd: remove unused fwd_ctx field David Marchand
2019-03-19 18:29 ` Ferruh Yigit
[not found] ` <1553076154-3907-1-git-send-email-david.marchand@redhat.com>
2019-03-20 10:02 ` [dpdk-stable] [PATCH v3 1/4] app/testpmd: add missing newline when showing statistics David Marchand
2019-03-20 13:49 ` Andrew Rybchenko
2019-03-20 10:02 ` [dpdk-stable] [PATCH v3 2/4] app/testpmd: extend fwd statistics to 64bits David Marchand
2019-03-20 13:55 ` Andrew Rybchenko
2019-03-20 10:02 ` [dpdk-stable] [PATCH v3 3/4] app/testpmd: remove useless casts on statistics David Marchand
2019-03-20 13:58 ` Andrew Rybchenko
[not found] ` <1553261824-1881-1-git-send-email-david.marchand@redhat.com>
2019-03-22 13:37 ` [dpdk-stable] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics David Marchand
2019-03-22 17:03 ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin
2019-03-22 17:17 ` Maxime Coquelin
2019-03-22 17:23 ` David Marchand
2019-03-22 17:31 ` Andrew Rybchenko
2019-03-22 17:35 ` [dpdk-stable] " Andrew Rybchenko
2019-03-22 17:43 ` David Marchand
2019-03-23 19:12 ` David Marchand
2019-03-25 6:34 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2019-03-22 13:37 ` [dpdk-stable] [PATCH v4 2/4] app/testpmd: extend fwd statistics to 64bits David Marchand
2019-03-22 17:06 ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin
2019-03-22 13:37 ` [dpdk-stable] [PATCH v4 3/4] app/testpmd: remove useless casts on statistics David Marchand
2019-03-22 17:11 ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin
[not found] ` <1553503906-1508-1-git-send-email-david.marchand@redhat.com>
2019-03-25 8:51 ` [dpdk-stable] [PATCH v5 1/4] app/testpmd: add missing newline when showing statistics David Marchand
2019-03-25 8:55 ` Andrew Rybchenko
2019-03-25 8:51 ` [dpdk-stable] [PATCH v5 2/4] app/testpmd: extend fwd statistics to 64bits David Marchand
2019-03-25 8:51 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553503906-1508-4-git-send-email-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=ramirose@gmail.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).