* [dpdk-stable] [PATCH v4 1/8] net/ice: fix Tx function setting
[not found] ` <1553149569-105555-1-git-send-email-wenzhuo.lu@intel.com>
@ 2019-03-21 6:26 ` Wenzhuo Lu
2019-03-22 8:46 ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin
0 siblings, 1 reply; 6+ messages in thread
From: Wenzhuo Lu @ 2019-03-21 6:26 UTC (permalink / raw)
To: dev; +Cc: Wenzhuo Lu, stable
The TX setting functions is not called.
Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
Cc: stable@dpdk.org
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
drivers/net/ice/ice_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index a23c63a..b804be1 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1741,6 +1741,7 @@ static int ice_init_rss(struct ice_pf *pf)
}
ice_set_rx_function(dev);
+ ice_set_tx_function(dev);
mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK |
ETH_VLAN_EXTEND_MASK;
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH v4 1/8] net/ice: fix Tx function setting
2019-03-21 6:26 ` [dpdk-stable] [PATCH v4 1/8] net/ice: fix Tx function setting Wenzhuo Lu
@ 2019-03-22 8:46 ` Maxime Coquelin
2019-03-22 9:01 ` Maxime Coquelin
0 siblings, 1 reply; 6+ messages in thread
From: Maxime Coquelin @ 2019-03-22 8:46 UTC (permalink / raw)
To: Wenzhuo Lu, dev; +Cc: stable
On 3/21/19 7:26 AM, Wenzhuo Lu wrote:
> The TX setting functions is not called.
s/functions/function/
>
> Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> ---
> drivers/net/ice/ice_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index a23c63a..b804be1 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -1741,6 +1741,7 @@ static int ice_init_rss(struct ice_pf *pf)
> }
>
> ice_set_rx_function(dev);
> + ice_set_tx_function(dev);
>
> mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK |
> ETH_VLAN_EXTEND_MASK;
>
Other than that:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH v4 1/8] net/ice: fix Tx function setting
2019-03-22 8:46 ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin
@ 2019-03-22 9:01 ` Maxime Coquelin
0 siblings, 0 replies; 6+ messages in thread
From: Maxime Coquelin @ 2019-03-22 9:01 UTC (permalink / raw)
To: Wenzhuo Lu, dev; +Cc: stable
On 3/22/19 9:46 AM, Maxime Coquelin wrote:
>
>
> On 3/21/19 7:26 AM, Wenzhuo Lu wrote:
>> The TX setting functions is not called.
>
> s/functions/function/
>
>>
>> Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
>> ---
>> drivers/net/ice/ice_ethdev.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
>> index a23c63a..b804be1 100644
>> --- a/drivers/net/ice/ice_ethdev.c
>> +++ b/drivers/net/ice/ice_ethdev.c
>> @@ -1741,6 +1741,7 @@ static int ice_init_rss(struct ice_pf *pf)
>> }
>> ice_set_rx_function(dev);
>> + ice_set_tx_function(dev);
>> mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK |
>> ETH_VLAN_EXTEND_MASK;
>>
>
> Other than that:
>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Sorry, just notice I didn't fetch my mailbox, so I didn't see the v5.
Anyway my comments seem to apply to v5 too.
Maxime
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <1553223516-118453-1-git-send-email-wenzhuo.lu@intel.com>]
* [dpdk-stable] [PATCH v5 1/8] net/ice: fix Tx function setting
[not found] ` <1553223516-118453-1-git-send-email-wenzhuo.lu@intel.com>
@ 2019-03-22 2:58 ` Wenzhuo Lu
0 siblings, 0 replies; 6+ messages in thread
From: Wenzhuo Lu @ 2019-03-22 2:58 UTC (permalink / raw)
To: dev; +Cc: Wenzhuo Lu, stable
The TX setting functions is not called.
Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
Cc: stable@dpdk.org
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
drivers/net/ice/ice_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index a23c63a..b804be1 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1741,6 +1741,7 @@ static int ice_init_rss(struct ice_pf *pf)
}
ice_set_rx_function(dev);
+ ice_set_tx_function(dev);
mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK |
ETH_VLAN_EXTEND_MASK;
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <1553493995-29803-1-git-send-email-wenzhuo.lu@intel.com>]
* [dpdk-stable] [PATCH v6 1/8] net/ice: fix Tx function setting
[not found] ` <1553493995-29803-1-git-send-email-wenzhuo.lu@intel.com>
@ 2019-03-25 6:06 ` Wenzhuo Lu
0 siblings, 0 replies; 6+ messages in thread
From: Wenzhuo Lu @ 2019-03-25 6:06 UTC (permalink / raw)
To: dev; +Cc: Wenzhuo Lu, stable
The TX setting functions is not called.
Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
Cc: stable@dpdk.org
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
drivers/net/ice/ice_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index a23c63a..b804be1 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1741,6 +1741,7 @@ static int ice_init_rss(struct ice_pf *pf)
}
ice_set_rx_function(dev);
+ ice_set_tx_function(dev);
mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK |
ETH_VLAN_EXTEND_MASK;
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <1553581011-94181-1-git-send-email-wenzhuo.lu@intel.com>]
* [dpdk-stable] [PATCH v7 1/8] net/ice: fix Tx function setting
[not found] ` <1553581011-94181-1-git-send-email-wenzhuo.lu@intel.com>
@ 2019-03-26 6:16 ` Wenzhuo Lu
0 siblings, 0 replies; 6+ messages in thread
From: Wenzhuo Lu @ 2019-03-26 6:16 UTC (permalink / raw)
To: dev; +Cc: Wenzhuo Lu, stable
The TX setting functions is not called.
Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
Cc: stable@dpdk.org
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
drivers/net/ice/ice_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index cdb5502..7233c3e 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -1741,6 +1741,7 @@ static int ice_init_rss(struct ice_pf *pf)
}
ice_set_rx_function(dev);
+ ice_set_tx_function(dev);
mask = ETH_VLAN_STRIP_MASK | ETH_VLAN_FILTER_MASK |
ETH_VLAN_EXTEND_MASK;
--
1.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-26 6:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1551340136-83843-1-git-send-email-wenzhuo.lu@intel.com>
[not found] ` <1553149569-105555-1-git-send-email-wenzhuo.lu@intel.com>
2019-03-21 6:26 ` [dpdk-stable] [PATCH v4 1/8] net/ice: fix Tx function setting Wenzhuo Lu
2019-03-22 8:46 ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin
2019-03-22 9:01 ` Maxime Coquelin
[not found] ` <1553223516-118453-1-git-send-email-wenzhuo.lu@intel.com>
2019-03-22 2:58 ` [dpdk-stable] [PATCH v5 " Wenzhuo Lu
[not found] ` <1553493995-29803-1-git-send-email-wenzhuo.lu@intel.com>
2019-03-25 6:06 ` [dpdk-stable] [PATCH v6 " Wenzhuo Lu
[not found] ` <1553581011-94181-1-git-send-email-wenzhuo.lu@intel.com>
2019-03-26 6:16 ` [dpdk-stable] [PATCH v7 " Wenzhuo Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).