From: Wang Ying A <ying.a.wang@intel.com>
To: qabuild@intel.com
Cc: Wang Ying A <ying.a.wang@intel.com>, stable@dpdk.org
Subject: [dpdk-stable] [DPDK 2/2] net/ice: fix promiscuous mode
Date: Fri, 12 Apr 2019 12:57:18 +0800 [thread overview]
Message-ID: <1555045038-135942-2-git-send-email-ying.a.wang@intel.com> (raw)
In-Reply-To: <1555045038-135942-1-git-send-email-ying.a.wang@intel.com>
When device promiscuous mode has already been enabled,
"set promisc all on" in testpmd command line should
give the user a hint not a error print. This patch
fixes the issue.
Fixes: c945e4bf9063 ("net/ice: support promiscuous mode")
Cc: stable@dpdk.org
Signed-off-by: Wang Ying A <ying.a.wang@intel.com>
---
drivers/net/ice/ice_ethdev.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 72831bb..198da86 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -2760,7 +2760,12 @@ static int ice_macaddr_set(struct rte_eth_dev *dev,
status = ice_set_vsi_promisc(hw, vsi->idx, pmask, 0);
if (status != ICE_SUCCESS)
- PMD_DRV_LOG(ERR, "Failed to enable promisc, err=%d", status);
+ {
+ if(status == ICE_ERR_ALREADY_EXISTS)
+ PMD_DRV_LOG(INFO, "Promiscuous mode has already been enabled");
+ else
+ PMD_DRV_LOG(ERR, "Failed to enable promisc, err=%d", status);
+ }
}
static void
--
1.8.3.1
next prev parent reply other threads:[~2019-04-12 5:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 4:57 [dpdk-stable] [DPDK 1/2] net/ice: code clean Wang Ying A
2019-04-12 4:57 ` Wang Ying A [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-04-17 1:13 [dpdk-stable] [DPDK 1/2] net/ice: fix wrong type Wang Ying A
2019-04-17 1:13 ` [dpdk-stable] [DPDK 2/2] net/ice: fix promiscuous mode Wang Ying A
2019-04-16 13:12 [dpdk-stable] [DPDK 1/2] net/ice: fix wrong type Wang Ying A
2019-04-16 13:12 ` [dpdk-stable] [DPDK 2/2] net/ice: fix promiscuous mode Wang Ying A
2019-04-12 8:08 [dpdk-stable] [DPDK 1/2] net/ice: code clean Wang Ying A
2019-04-12 8:08 ` [dpdk-stable] [DPDK 2/2] net/ice: fix promiscuous mode Wang Ying A
2019-04-11 1:38 [dpdk-stable] [DPDK 1/2] net/ice: code clean Wang Ying A
2019-04-11 1:38 ` [dpdk-stable] [DPDK 2/2] net/ice: fix promiscuous mode Wang Ying A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1555045038-135942-2-git-send-email-ying.a.wang@intel.com \
--to=ying.a.wang@intel.com \
--cc=qabuild@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).