From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 15AB8A0096 for ; Fri, 12 Apr 2019 10:49:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 02ECE56A1; Fri, 12 Apr 2019 10:49:22 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 92E4156A1 for ; Fri, 12 Apr 2019 10:49:20 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Apr 2019 01:49:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,340,1549958400"; d="scan'208";a="142160757" Received: from npg_dpdk-cvl_simeisu_116d180.sh.intel.com (HELO npg-dpdk-cvl-simeisu-116d180.sh.intel.com) ([10.67.116.180]) by orsmga003.jf.intel.com with ESMTP; 12 Apr 2019 01:49:19 -0700 From: Wang Ying A To: qabuild@intel.com Cc: Wang Ying A , stable@dpdk.org Date: Fri, 12 Apr 2019 16:08:39 +0800 Message-Id: <1555056519-47052-2-git-send-email-ying.a.wang@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1555056519-47052-1-git-send-email-ying.a.wang@intel.com> References: <1555056519-47052-1-git-send-email-ying.a.wang@intel.com> Subject: [dpdk-stable] [DPDK 2/2] net/ice: fix promiscuous mode X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" When device promiscuous mode has already been enabled, "set promisc all on" in testpmd command line should give the user a hint not a error print. This patch fixes the issue. Fixes: c945e4bf9063 ("net/ice: support promiscuous mode") Cc: stable@dpdk.org Signed-off-by: Wang Ying A --- drivers/net/ice/ice_ethdev.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 72831bb..cb82a6f 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -2759,7 +2759,9 @@ static int ice_macaddr_set(struct rte_eth_dev *dev, ICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX; status = ice_set_vsi_promisc(hw, vsi->idx, pmask, 0); - if (status != ICE_SUCCESS) + if (status == ICE_ERR_ALREADY_EXISTS) + PMD_DRV_LOG(DEBUG, "Promisc mode has already been enabled"); + else if (status != ICE_SUCCESS) PMD_DRV_LOG(ERR, "Failed to enable promisc, err=%d", status); } -- 1.8.3.1