patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] raw/ifpga: fix fd leak in rte fpga do pr
@ 2019-04-17  6:49 Andy Pei
  2019-04-17  7:14 ` Xu, Rosen
  2019-04-17  7:16 ` [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: " Andy Pei
  0 siblings, 2 replies; 10+ messages in thread
From: Andy Pei @ 2019-04-17  6:49 UTC (permalink / raw)
  To: dev; +Cc: andy.pei, rosen.xu, marko.kovacevic, liq3ea, stable

In rte_fpga_do_pr() function, if 'stat' returns error,
rte_fpga_do_pr() returns -EINVAL without closing the
'file_fd' that has been opened.
After this patch, 'file_fd' is closed before rte_fpga_do_pr()
returns -EINVAL when 'stat' returns error

Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver")
Cc: rosen.xu@intel.com
Cc: marko.kovacevic@intel.com
Cc: liq3ea@163.com
Cc: andy.pei@intel.com
Cc: stable@dpdk.org

Signed-off-by: Andy Pei <andy.pei@intel.com>
---
---
 drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
index da772d0..eff001b 100644
--- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
+++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
@@ -244,7 +244,8 @@
 	if (ret) {
 		IFPGA_RAWDEV_PMD_ERR("stat on bitstream file failed: %s\n",
 				file_name);
-		return -EINVAL;
+		ret = -EINVAL;
+		goto close_fd;
 	}
 	buffer_size = file_stat.st_size;
 	IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size);
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-04-24  1:13 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-17  6:49 [dpdk-stable] [PATCH] raw/ifpga: fix fd leak in rte fpga do pr Andy Pei
2019-04-17  7:14 ` Xu, Rosen
2019-04-17  7:17   ` Pei, Andy
2019-04-17  7:16 ` [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: " Andy Pei
2019-04-17  8:03   ` Xu, Rosen
2019-04-22 17:52     ` Thomas Monjalon
2019-04-23  1:19       ` Pei, Andy
2019-04-23  1:36         ` Xu, Rosen
2019-04-23  8:45           ` Thomas Monjalon
2019-04-24  1:13             ` Pei, Andy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).