patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] examples/ipv4_multicast: remove useless mbuf info copy
@ 2018-11-21  9:49 Wei Zhao
  2018-11-21 10:17 ` Zhao1, Wei
  0 siblings, 1 reply; 3+ messages in thread
From: Wei Zhao @ 2018-11-21  9:49 UTC (permalink / raw)
  To: dev; +Cc: stable, konstantin.ananyev, Wei Zhao

There is not need for these useless information and
it had better be removed in oder not to confusing users.

Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
 examples/ipv4_multicast/main.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/main.c
index 428ca46..1eef291 100644
--- a/examples/ipv4_multicast/main.c
+++ b/examples/ipv4_multicast/main.c
@@ -254,18 +254,10 @@ mcast_out_pkt(struct rte_mbuf *pkt, int use_clone)
 	/* prepend new header */
 	hdr->next = pkt;
 
-
 	/* update header's fields */
 	hdr->pkt_len = (uint16_t)(hdr->data_len + pkt->pkt_len);
 	hdr->nb_segs = pkt->nb_segs + 1;
 
-	/* copy metadata from source packet*/
-	hdr->port = pkt->port;
-	hdr->vlan_tci = pkt->vlan_tci;
-	hdr->vlan_tci_outer = pkt->vlan_tci_outer;
-	hdr->tx_offload = pkt->tx_offload;
-	hdr->hash = pkt->hash;
-
 	__rte_mbuf_sanity_check(hdr, 1);
 	return hdr;
 }
-- 
2.7.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] examples/ipv4_multicast: remove useless mbuf info copy
  2018-11-21  9:49 [dpdk-stable] [PATCH] examples/ipv4_multicast: remove useless mbuf info copy Wei Zhao
@ 2018-11-21 10:17 ` Zhao1, Wei
  2018-12-19 21:28   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Zhao1, Wei @ 2018-11-21 10:17 UTC (permalink / raw)
  To: dev; +Cc: stable, Ananyev, Konstantin, Wang, Dong1, Lu, Wenzhuo

Add the background for this patch 
https://mails.dpdk.org/archives/dev/2018-November/119391.html


> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, November 21, 2018 5:49 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Ananyev, Konstantin <konstantin.ananyev@intel.com>;
> Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] examples/ipv4_multicast: remove useless mbuf info copy
> 
> There is not need for these useless information and it had better be
> removed in oder not to confusing users.
> 
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
>  examples/ipv4_multicast/main.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/examples/ipv4_multicast/main.c
> b/examples/ipv4_multicast/main.c index 428ca46..1eef291 100644
> --- a/examples/ipv4_multicast/main.c
> +++ b/examples/ipv4_multicast/main.c
> @@ -254,18 +254,10 @@ mcast_out_pkt(struct rte_mbuf *pkt, int use_clone)
>  	/* prepend new header */
>  	hdr->next = pkt;
> 
> -
>  	/* update header's fields */
>  	hdr->pkt_len = (uint16_t)(hdr->data_len + pkt->pkt_len);
>  	hdr->nb_segs = pkt->nb_segs + 1;
> 
> -	/* copy metadata from source packet*/
> -	hdr->port = pkt->port;
> -	hdr->vlan_tci = pkt->vlan_tci;
> -	hdr->vlan_tci_outer = pkt->vlan_tci_outer;
> -	hdr->tx_offload = pkt->tx_offload;
> -	hdr->hash = pkt->hash;
> -
>  	__rte_mbuf_sanity_check(hdr, 1);
>  	return hdr;
>  }
> --
> 2.7.5

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/ipv4_multicast: remove useless mbuf info copy
  2018-11-21 10:17 ` Zhao1, Wei
@ 2018-12-19 21:28   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-12-19 21:28 UTC (permalink / raw)
  To: Zhao1, Wei; +Cc: dev, stable, Ananyev, Konstantin, Wang, Dong1, Lu, Wenzhuo

21/11/2018 11:17, Zhao1, Wei:
> Add the background for this patch 
> https://mails.dpdk.org/archives/dev/2018-November/119391.html
> 
> > There is not need for these useless information and it had better be
> > removed in oder not to confusing users.
> > 
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-12-19 21:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-21  9:49 [dpdk-stable] [PATCH] examples/ipv4_multicast: remove useless mbuf info copy Wei Zhao
2018-11-21 10:17 ` Zhao1, Wei
2018-12-19 21:28   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).