From: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
To: dev@dpdk.org, fiona.trahe@intel.com, tomaszx.jozwiak@intel.com,
shallyv@marvell.com, stable@dpdk.org
Subject: [dpdk-stable] [PATCH] app/test-compress-perf: fix improper use of negative value
Date: Mon, 20 May 2019 15:26:03 +0200 [thread overview]
Message-ID: <1558358764-32053-1-git-send-email-tomaszx.jozwiak@intel.com> (raw)
This patch fixes coverity issue: Improper use of negative value.
test_data->input_data_sz is passed to a parameter that
cannot be negative.
Coverity issue: 328504
Fixes: b68a82425da4 ("app/compress-perf: add performance measurement")
Cc: stable@dpdk.org
Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
---
app/test-compress-perf/main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/app/test-compress-perf/main.c b/app/test-compress-perf/main.c
index c2a45d1..5a579ea 100644
--- a/app/test-compress-perf/main.c
+++ b/app/test-compress-perf/main.c
@@ -244,7 +244,8 @@ comp_perf_dump_input_data(struct comp_test_data *test_data)
if (test_data->input_data_sz == 0)
test_data->input_data_sz = actual_file_sz;
- if (fseek(f, 0, SEEK_SET) != 0) {
+ if (test_data->input_data_sz <= 0 || actual_file_sz <= 0 ||
+ fseek(f, 0, SEEK_SET) != 0) {
RTE_LOG(ERR, USER1, "Size of input could not be calculated\n");
goto end;
}
--
2.7.4
next reply other threads:[~2019-05-20 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 13:26 Tomasz Jozwiak [this message]
2019-05-20 13:26 ` [dpdk-stable] [PATCH] app/test-compress-perf: fix reliance on integer endianness Tomasz Jozwiak
2019-05-20 14:05 ` Trahe, Fiona
2019-05-20 14:25 ` Jozwiak, TomaszX
2019-05-21 6:47 ` Jozwiak, TomaszX
2019-05-21 8:03 ` Shally Verma
2019-05-21 8:47 ` Jozwiak, TomaszX
2019-05-29 13:46 ` Trahe, Fiona
2019-06-03 13:44 ` Shally Verma
2019-05-20 13:39 ` [dpdk-stable] [PATCH] app/test-compress-perf: fix improper use of negative value Trahe, Fiona
2019-06-19 14:55 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1558358764-32053-1-git-send-email-tomaszx.jozwiak@intel.com \
--to=tomaszx.jozwiak@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=shallyv@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).