* [dpdk-stable] [PATCH 1/2] examples/l3fwd-vf: remove old Rx/Tx configuration defines
[not found] <1559557107-115815-1-git-send-email-longtb5@viettel.com.vn>
@ 2019-06-03 10:06 ` longtb5
2019-06-03 10:06 ` [dpdk-stable] [PATCH 2/2] doc: remove old Rx/Tx configuration info in l2fwd longtb5
1 sibling, 0 replies; 2+ messages in thread
From: longtb5 @ 2019-06-03 10:06 UTC (permalink / raw)
To: bruce.richardson; +Cc: dev, Bao-Long Tran, stable
The RX and TX Prefetch, Host, and Write-back threshold values are
defined but not used anywhere. They are leftovers from a previous
patch.
Fixes: 81f7ecd9 ("examples: use factorized default Rx/Tx configuration")
Cc: stable@dpdk.org
Signed-off-by: Bao-Long Tran <longtb5@viettel.com.vn>
---
examples/l3fwd-vf/main.c | 19 -------------------
1 file changed, 19 deletions(-)
diff --git a/examples/l3fwd-vf/main.c b/examples/l3fwd-vf/main.c
index 0ef469c..5533031 100644
--- a/examples/l3fwd-vf/main.c
+++ b/examples/l3fwd-vf/main.c
@@ -74,25 +74,6 @@
nb_lcores*MEMPOOL_CACHE_SIZE), \
(unsigned)8192)
-/*
- * RX and TX Prefetch, Host, and Write-back threshold values should be
- * carefully set for optimal performance. Consult the network
- * controller's datasheet and supporting DPDK documentation for guidance
- * on how these parameters should be set.
- */
-#define RX_PTHRESH 8 /**< Default values of RX prefetch threshold reg. */
-#define RX_HTHRESH 8 /**< Default values of RX host threshold reg. */
-#define RX_WTHRESH 4 /**< Default values of RX write-back threshold reg. */
-
-/*
- * These default values are optimized for use with the Intel(R) 82599 10 GbE
- * Controller and the DPDK ixgbe PMD. Consider using other values for other
- * network controllers and/or network drivers.
- */
-#define TX_PTHRESH 36 /**< Default values of TX prefetch threshold reg. */
-#define TX_HTHRESH 0 /**< Default values of TX host threshold reg. */
-#define TX_WTHRESH 0 /**< Default values of TX write-back threshold reg. */
-
#define MAX_PKT_BURST 32
#define BURST_TX_DRAIN_US 100 /* TX drain every ~100us */
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* [dpdk-stable] [PATCH 2/2] doc: remove old Rx/Tx configuration info in l2fwd
[not found] <1559557107-115815-1-git-send-email-longtb5@viettel.com.vn>
2019-06-03 10:06 ` [dpdk-stable] [PATCH 1/2] examples/l3fwd-vf: remove old Rx/Tx configuration defines longtb5
@ 2019-06-03 10:06 ` longtb5
1 sibling, 0 replies; 2+ messages in thread
From: longtb5 @ 2019-06-03 10:06 UTC (permalink / raw)
To: bruce.richardson; +Cc: dev, Bao-Long Tran, stable
Update doc the match with code.
Fixes: 81f7ecd9 ("examples: use factorized default Rx/Tx configuration")
Cc: stable@dpdk.org
Signed-off-by: Bao-Long Tran <longtb5@viettel.com.vn>
---
doc/guides/sample_app_ug/l2_forward_real_virtual.rst | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/doc/guides/sample_app_ug/l2_forward_real_virtual.rst b/doc/guides/sample_app_ug/l2_forward_real_virtual.rst
index bede06e..39d6b00 100644
--- a/doc/guides/sample_app_ug/l2_forward_real_virtual.rst
+++ b/doc/guides/sample_app_ug/l2_forward_real_virtual.rst
@@ -281,18 +281,6 @@ The list of queues that must be polled for a given lcore is stored in a private
The values n_rx_port and rx_port_list[] are used in the main packet processing loop
(see :ref:`l2_fwd_app_rx_tx_packets`).
-The global configuration for the RX queues is stored in a static structure:
-
-.. code-block:: c
-
- static const struct rte_eth_rxconf rx_conf = {
- .rx_thresh = {
- .pthresh = RX_PTHRESH,
- .hthresh = RX_HTHRESH,
- .wthresh = RX_WTHRESH,
- },
- };
-
.. _l2_fwd_app_tx_init:
TX Queue Initialization
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-03 10:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1559557107-115815-1-git-send-email-longtb5@viettel.com.vn>
2019-06-03 10:06 ` [dpdk-stable] [PATCH 1/2] examples/l3fwd-vf: remove old Rx/Tx configuration defines longtb5
2019-06-03 10:06 ` [dpdk-stable] [PATCH 2/2] doc: remove old Rx/Tx configuration info in l2fwd longtb5
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).