From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9730AA0471 for ; Fri, 19 Jul 2019 15:07:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3BDB52BA8; Fri, 19 Jul 2019 15:07:55 +0200 (CEST) Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) by dpdk.org (Postfix) with ESMTP id 03E662BA8 for ; Fri, 19 Jul 2019 15:07:53 +0200 (CEST) Received: by mail-qk1-f193.google.com with SMTP id r21so23191262qke.2 for ; Fri, 19 Jul 2019 06:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cR9QUPpObCUIjcTFpLZNZqyhd6vn3fB9n003iGquT/0=; b=WVfVIrfe90vvmOQcJiQ6GusyOV7ySbRNG2aPAA1OqM2KamEiO2Dllsk013f92wlaDD ZBJJ8/14rOUbh6foyv2WtnuuYe4FYQR9KeVvi21Sp9DPLkVLIlQMPdhculUBrzMP/2ie 7tZj3S8CcIP9F1nBE4G+VKUddZVSStver4mS3+PAKN+c1/shhKE2GRBXB+x5ZH4flbXb CPC5iQPjZ/4mifQgdZ7FJyY9ivYKHnTvhF9U+zegFax6vHfkiUy3PTX4613mCnvr15VK LVjUnTFTWKWC8/wmC9KiJKJAd5Py9swow57pZ6QU+OHS3C5hjOgEoSXLvEkDu+6q0BYH gdVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cR9QUPpObCUIjcTFpLZNZqyhd6vn3fB9n003iGquT/0=; b=eGqhwh+j436QF5UmX5nQUK43Dwm3RgVJ016lH7EADVeuTE/V8o8qU0exRwhffKS2Cx S5qqRcHVJ/OqQHx6Gc0lLc0TTL2y0pRXq9kEOnpa3WeDxZhRyw2MYHwh2v4nSRf/oT5G Ws9AOqXAeWQFmix5pG950EOSRmB9xeWvWzLAGkOxFgyzBahXGa51KH1pLeF5vxxhebq5 FLW+sSL/N/EECEDk4obI1F2lyUKirjKxA5lOLtthJFiLq9xRlw+inIFPOAkgdY88R7WY bqAYPm1+qaCQvc3b6I4nOLvUbyjFTvaz/fhz6nl7qK3CST6CEcvnkW+8AWoW64KFYSfr bSgA== X-Gm-Message-State: APjAAAUcVc/ifZlVqzTDjAD8Qp+eUZLABGwwqgb04jSmMLyk6iVmxjvT HWhwXjuw4kCLtYYYpjnXLgQ= X-Google-Smtp-Source: APXvYqwaSsYjWjIsbWf1eRgPL/V4LmneTALkzINPyKBRHZC5a/XbX/P5YgdgDk1YJff9ClZnSJl9cQ== X-Received: by 2002:a37:90c2:: with SMTP id s185mr36824049qkd.161.1563541673339; Fri, 19 Jul 2019 06:07:53 -0700 (PDT) Received: from localhost.localdomain (pool-173-48-129-93.bstnma.fios.verizon.net. [173.48.129.93]) by smtp.gmail.com with ESMTPSA id r26sm13567080qkm.57.2019.07.19.06.07.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 19 Jul 2019 06:07:52 -0700 (PDT) From: Ed Czeck To: dev@dpdk.org, ferruh.yigit@intel.com Cc: shepard.siegel@atomicrules.com, john.miller@atomicrules.com, Ed Czeck , stable@dpdk.org Date: Fri, 19 Jul 2019 09:07:42 -0400 Message-Id: <1563541663-10797-1-git-send-email-ed.czeck@atomicrules.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1563312861-26219-1-git-send-email-ed.czeck@atomicrules.com> References: <1563312861-26219-1-git-send-email-ed.czeck@atomicrules.com> Subject: [dpdk-stable] [PATCH 1/2] net/ark: remove queue offset based on port id X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Queue index was incorrectly incremented with port, which caused swizzling of packet placement among queues. This manifested when the number of configured ports was >1 and < nb_queues. Fixes: c33d45af3633 ("net/ark: add Tx initial version") Cc: stable@dpdk.org Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev_rx.c | 4 +--- drivers/net/ark/ark_ethdev_tx.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c index 7de1a98..6156730 100644 --- a/drivers/net/ark/ark_ethdev_rx.c +++ b/drivers/net/ark/ark_ethdev_rx.c @@ -127,9 +127,7 @@ eth_ark_dev_rx_queue_setup(struct rte_eth_dev *dev, uint32_t i; int status; - /* Future works: divide the Q's evenly with multi-ports */ - int port = dev->data->port_id; - int qidx = port + queue_idx; + int qidx = queue_idx; /* We may already be setup, free memory prior to re-allocation */ if (dev->data->rx_queues[queue_idx] != NULL) { diff --git a/drivers/net/ark/ark_ethdev_tx.c b/drivers/net/ark/ark_ethdev_tx.c index 1967655..08bcf43 100644 --- a/drivers/net/ark/ark_ethdev_tx.c +++ b/drivers/net/ark/ark_ethdev_tx.c @@ -211,9 +211,7 @@ eth_ark_tx_queue_setup(struct rte_eth_dev *dev, struct ark_tx_queue *queue; int status; - /* Future: divide the Q's evenly with multi-ports */ - int port = dev->data->port_id; - int qidx = port + queue_idx; + int qidx = queue_idx; if (!rte_is_power_of_2(nb_desc)) { PMD_DRV_LOG(ERR, -- 2.7.4