In function ixgbe_parse_rss_filter, memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf)) is using memset(aaa, 0, sizeof(struct bbb)) format, maybe it's better to make it consistent with others. Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API") Cc: stable@dpdk.org Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn> --- drivers/net/ixgbe/ixgbe_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c index 92377b8..b2a2bfc 100644 --- a/drivers/net/ixgbe/ixgbe_flow.c +++ b/drivers/net/ixgbe/ixgbe_flow.c @@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[]) /* check if the next not void item is END */ act = next_no_void_action(actions, act); if (act->type != RTE_FLOW_ACTION_TYPE_END) { - memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf)); + memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf)); rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, act, "Not supported action."); -- 1.8.3.1
On 08/08, Congwen Zhang wrote: >In function ixgbe_parse_rss_filter, memset(rss_conf, 0, >sizeof(struct rte_eth_rss_conf)) is using >memset(aaa, 0, sizeof(struct bbb)) format, >maybe it's better to make it consistent with others. Er...These comments are just for the style of memset, putting them in the commit log is not a good idea. Better to describe what issue you have met without this patch. Thanks, Xiaolong > >Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API") >Cc: stable@dpdk.org > >Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn> >--- > drivers/net/ixgbe/ixgbe_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c >index 92377b8..b2a2bfc 100644 >--- a/drivers/net/ixgbe/ixgbe_flow.c >+++ b/drivers/net/ixgbe/ixgbe_flow.c >@@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[]) > /* check if the next not void item is END */ > act = next_no_void_action(actions, act); > if (act->type != RTE_FLOW_ACTION_TYPE_END) { >- memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf)); >+ memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf)); > rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > act, "Not supported action."); >-- >1.8.3.1 >
On 08/08, Congwen Zhang wrote:
>In function ixgbe_parse_rss_filter, memset(rss_conf, 0,
>sizeof(struct rte_eth_rss_conf)) is using
>memset(aaa, 0, sizeof(struct bbb)) format,
>maybe it's better to make it consistent with others.
>
>Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API")
>Cc: stable@dpdk.org
>
>Signed-off-by: Congwen Zhang <zhang.congwen@zte.com.cn>
>---
> drivers/net/ixgbe/ixgbe_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
>index 92377b8..b2a2bfc 100644
>--- a/drivers/net/ixgbe/ixgbe_flow.c
>+++ b/drivers/net/ixgbe/ixgbe_flow.c
>@@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[])
> /* check if the next not void item is END */
> act = next_no_void_action(actions, act);
> if (act->type != RTE_FLOW_ACTION_TYPE_END) {
>- memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf));
>+ memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf));
> rte_flow_error_set(error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ACTION,
> act, "Not supported action.");
>--
>1.8.3.1
>
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel. Thanks.