From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8C61A046B for ; Mon, 19 Aug 2019 15:19:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 636861BEB0; Mon, 19 Aug 2019 15:19:10 +0200 (CEST) Received: from mx08-001f8a01.pphosted.com (mx07-001f8a01.pphosted.com [62.209.51.162]) by dpdk.org (Postfix) with ESMTP id C24821BEB0 for ; Mon, 19 Aug 2019 15:19:08 +0200 (CEST) Received: from pps.filterd (m0091174.ppops.net [127.0.0.1]) by mx07-001f8a01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7JDJ8Bo012961; Mon, 19 Aug 2019 15:19:08 +0200 Received: from ind01-bo1-obe.outbound.protection.outlook.com (mail-bo1ind01lp2055.outbound.protection.outlook.com [104.47.101.55]) by mx07-001f8a01.pphosted.com with ESMTP id 2ufvcqg15e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 19 Aug 2019 15:19:07 +0200 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U9RMcN2+Xljki88i+R3WpQvqtSvNK43TubgNnTLx+n7yc4KkmBjp55jPoe/fH2e2iRM8E4t0xUENY6ueCw/sQ3oFJ4S2m47yi3mv0oTBMC5G+Dkz6hK1WMtIrsSW7F946kE4fbQDxXwVjrekT9VYvt5olpmRJPMLcYa50YFIV8iV183JijvFMdUB/3DwoFLs4JBkntKJOhauV0tfzMDeySoewRP3V1HnlCL4v/XfimahZYgu3HBhWOmqpl0zS+SHQyTzxPuHDl648ExDwb6+3dDf7P/SKJjptibFVb6Uvxll35NtWoE03kA6Q2Ohpf1kmLNGLkETh5t2DVNC/T7lfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lqp+DySEiygtg7t0TNWRLFddU86NeM/EgnJt+VZJZVE=; b=XuwvWKezESiyfOol1J6Pqvu49l0P0g3hLsDs3wwyfpW2Wf1JRFuQKHuck1JNgEaDlEukzM4v3S4zWeK4Y4pvUYRxe0cSaejOQ3HCRSerabx/01RA4aJibq/4oLeZTZzqeLLm9gIELa5sxIp9ka+C5uPugqX30CP+U6dSDQa2Q/43xh3tqyMR7ucMI7bvVH9YMc7AUDITrbqJq6VxJlRwVpCisL0rFYTryvfAufclghA3YWU6glVII9+zhlBzlocwYSG+9qnGCzcyW0DTjd2q5tZo5LMZ8xZzMUBWTcCshHiP2lLub2yPNJY7D9OmLgHotsR7N5dEL6nzh0zSMvwxpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 125.19.57.65) smtp.rcpttodomain=dpdk.org smtp.mailfrom=aricent.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=altran.com; dkim=none (message not signed); arc=none Received: from MA1PR01CA0111.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:1::27) by BMXPR01MB0823.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:12::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.16; Mon, 19 Aug 2019 13:18:47 +0000 Received: from SG2APC01FT009.eop-APC01.prod.protection.outlook.com (2a01:111:f400:7ebe::201) by MA1PR01CA0111.outlook.office365.com (2603:1096:a00:1::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2178.16 via Frontend Transport; Mon, 19 Aug 2019 13:18:46 +0000 Received-SPF: SoftFail (protection.outlook.com: domain of transitioning aricent.com discourages use of 125.19.57.65 as permitted sender) Received: from GURHYBRID01.AD.ARICENT.COM (125.19.57.65) by SG2APC01FT009.mail.protection.outlook.com (10.152.250.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2178.16 via Frontend Transport; Mon, 19 Aug 2019 13:18:46 +0000 Received: from GURHYBRID02.AD.ARICENT.COM (10.203.26.140) by GURHYBRID01.AD.ARICENT.COM (10.203.26.182) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 19 Aug 2019 18:45:00 +0530 Received: from gurux105.gur.aricent.com (10.203.159.187) by GURHYBRID02.AD.ARICENT.COM (10.203.26.100) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 19 Aug 2019 18:45:00 +0530 Received: from gurux118.gur.aricent.com ([10.203.158.20]) by gurux105.gur.aricent.com (8.14.4/8.14.4) with ESMTP id x7JDF0i9025829; Mon, 19 Aug 2019 18:45:00 +0530 Received: from localhost.localdomain ([172.19.57.242]) by gurux118.gur.aricent.com (8.14.4/8.13.8) with ESMTP id x7JDERG6027597; Mon, 19 Aug 2019 18:44:49 +0530 From: To: CC: , abhishek sachan Date: Mon, 19 Aug 2019 18:44:20 +0530 Message-ID: <1566220460-6324-1-git-send-email-abhishek.sachan@altran.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:125.19.57.65; IPV:CAL; SCL:-1; CTRY:IN; EFV:NLI; SFV:NSPM; SFS:(10009020)(396003)(346002)(39860400002)(376002)(136003)(2980300002)(199004)(189003)(126002)(51416003)(2616005)(476003)(6916009)(36756003)(486006)(53936002)(107886003)(186003)(42882007)(336012)(305945005)(26005)(478600001)(26826003)(48376002)(50466002)(356004)(6666004)(2876002)(49486002)(47776003)(5660300002)(70586007)(76130400001)(16586007)(81156014)(70206006)(2351001)(4326008)(81166006)(8936002)(54906003)(316002)(50226002)(8676002)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:BMXPR01MB0823; H:GURHYBRID01.AD.ARICENT.COM; FPR:; SPF:SoftFail; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb039eee-a365-4254-a01d-08d724a7c418 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328); SRVR:BMXPR01MB0823; X-MS-TrafficTypeDiagnostic: BMXPR01MB0823: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:170; X-Forefront-PRVS: 0134AD334F X-MS-Exchange-SenderADCheck: 2 X-Microsoft-Antispam-Message-Info: XRNMX88WIr6agbkZRgJz+IT9tJ9+bAObJUDS9qhV083h9Ic6IAMgPCpBjjF95/P0ZY4VH5STfSdy9GkHF2x9twxqMzGlMzHiSRu1PuoSbDbuXMsYNgfkGWpjjPSm8AWcdVvY+Clb/T3XspE0RMqS3aZXoE8Qd0nWL+dSzoWEtyk1xv3aVSc/SsvlBOci/8dAKVafSSzysxOYoEvKyjSaJkQ11snWE+c63tSUT19cGHCn7u7eYOcxVodXQ1x2pRm6aBg4uVD917gnrvIw+Gd40Ri5MPws3JIVkqp/BglgTUEUCwqyTjPfv/C0pI/zf5UifftYujUc0T8TSNwJUOW5rqE4JEszl7qqa4Rr1GvD3CeWdd2ChaW5uKPhtqU2iuF+BnXc5O4ietl+GNfrl6TAYT/gl0SrOQEsjptamobvO3E= X-OriginatorOrg: Aricent.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2019 13:18:46.2029 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cb039eee-a365-4254-a01d-08d724a7c418 X-MS-Exchange-CrossTenant-Id: dbb4cbbe-57c5-469d-b342-a9814e1d2382 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=dbb4cbbe-57c5-469d-b342-a9814e1d2382; Ip=[125.19.57.65]; Helo=[GURHYBRID01.AD.ARICENT.COM] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BMXPR01MB0823 X-Proofpoint-Spam-Details: rule=outgoing_spam_policy_notspam policy=outgoing_spam_policy score=0 priorityscore=1501 malwarescore=0 suspectscore=3 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=890 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908190152 Subject: [dpdk-stable] [PATCH 18.11] net/af_packet: fix for stale sockets X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" From: abhishek sachan af_packet driver is leaving stale socket after device is removed. Ring buffers are memory mapped when device is added using rte_dev_probe. There is no corresponding munmap call when device is removed/closed. This commit fixes the issue by calling munmap from rte_pmd_af_packet_remove(). Bugzilla ID: 339 Signed-off-by: abhishek sachan Reviewed-by: John W. Linville --- drivers/net/af_packet/rte_eth_af_packet.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index 264cfc0..657ad85 100644 --- a/drivers/net/af_packet/rte_eth_af_packet.c +++ b/drivers/net/af_packet/rte_eth_af_packet.c @@ -972,6 +972,7 @@ rte_pmd_af_packet_remove(struct rte_vdev_device *dev) { struct rte_eth_dev *eth_dev = NULL; struct pmd_internals *internals; + struct tpacket_req *req; unsigned q; PMD_LOG(INFO, "Closing AF_PACKET ethdev on numa socket %u", @@ -992,7 +993,10 @@ rte_pmd_af_packet_remove(struct rte_vdev_device *dev) return rte_eth_dev_release_port(eth_dev); internals = eth_dev->data->dev_private; + req = &internals->req; for (q = 0; q < internals->nb_queues; q++) { + munmap(internals->rx_queue[q].map, + 2 * req->tp_block_size * req->tp_block_nr); rte_free(internals->rx_queue[q].rd); rte_free(internals->tx_queue[q].rd); } -- 2.7.4