From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBB1BA2E1B for ; Thu, 5 Sep 2019 12:55:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9632A1EFAF; Thu, 5 Sep 2019 12:55:46 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id 5A5531EFA8; Thu, 5 Sep 2019 12:55:43 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8F9B91576; Thu, 5 Sep 2019 03:55:42 -0700 (PDT) Received: from phil-VirtualBox.shanghai.arm.com (unknown [10.169.106.163]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 061D53F718; Thu, 5 Sep 2019 03:55:39 -0700 (PDT) From: Phil Yang To: yskoh@mellanox.com, viacheslavo@mellanox.com, matan@mellanox.com, nelio.laranjeiro@6wind.com, dev@dpdk.org Cc: thomas@monjalon.net, jerinj@marvell.com, Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, nd@arm.com, stable@dpdk.org Date: Thu, 5 Sep 2019 18:55:08 +0800 Message-Id: <1567680908-31210-2-git-send-email-phil.yang@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1567680908-31210-1-git-send-email-phil.yang@arm.com> References: <1567680908-31210-1-git-send-email-phil.yang@arm.com> Subject: [dpdk-stable] [PATCH 2/2] net/mlx5: fix Tx CQ doorbell synchronization on aarch64 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" For the weaker memory model processors, the compiler barrier is not sufficient to guarantee the coherent memory update be observed by I/O device. It needs the coherent I/O memory barrier to enforce the ordering of Tx completion queue doorbell operation. Fixes: da1df1ccabad ("net/mlx5: fix completion queue drain loop") Cc: stable@dpdk.org Suggested-by: Gavin Hu Signed-off-by: Phil Yang Reviewed-by: Gavin Hu --- drivers/net/mlx5/mlx5_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 4c01187..c11148b 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -2042,7 +2042,7 @@ mlx5_tx_comp_flush(struct mlx5_txq_data *restrict txq, } else { return; } - rte_compiler_barrier(); + rte_cio_wmb(); *txq->cq_db = rte_cpu_to_be_32(txq->cq_ci); if (likely(tail != txq->elts_tail)) { mlx5_tx_free_elts(txq, tail, olx); -- 2.7.4