From: Matan Azrad <matan@mellanox.com>
To: dev@dpdk.org
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
mukawa@igel.co.jp, stable@dpdk.org
Subject: [dpdk-stable] [PATCH 1/2] bus/pci: fix driver detach clear
Date: Tue, 12 Nov 2019 08:47:38 +0000 [thread overview]
Message-ID: <1573548459-6931-1-git-send-email-matan@mellanox.com> (raw)
When a rte_device is unplugged, the driver should be detached from the
device.
The PCI detach driver operation wrongly didn't clear the driver from the
device structure what remain the device in probe state from the EAL
point of view.
Clear the driver in driver detach successful operation.
Fixes: dbe6b4b61b0e ("pci: probe or close device")
Cc: mukawa@igel.co.jp
Cc: stable@dpdk.org
Signed-off-by: Matan Azrad <matan@mellanox.com>
---
drivers/bus/pci/pci_common.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
index 6b46b4f..3f55420 100644
--- a/drivers/bus/pci/pci_common.c
+++ b/drivers/bus/pci/pci_common.c
@@ -247,6 +247,7 @@ static struct rte_devargs *pci_devargs_lookup(struct rte_pci_device *dev)
/* clear driver structure */
dev->driver = NULL;
+ dev->device.driver = NULL;
if (dr->drv_flags & RTE_PCI_DRV_NEED_MAPPING)
/* unmap resources for devices that use igb_uio */
--
1.8.3.1
next reply other threads:[~2019-11-12 8:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 8:47 Matan Azrad [this message]
2019-11-12 8:47 ` [dpdk-stable] [PATCH 2/2] app/testpmd: fix invalid port detaching Matan Azrad
2019-11-12 11:20 ` Iremonger, Bernard
2019-11-20 22:52 ` David Marchand
2020-01-23 13:19 ` [dpdk-stable] [dpdk-dev] " Yigit, Ferruh
2020-01-23 14:05 ` Matan Azrad
2020-01-23 14:48 ` Ferruh Yigit
2020-01-23 15:29 ` Matan Azrad
2020-01-23 18:14 ` Ferruh Yigit
2020-01-23 19:25 ` Matan Azrad
2020-01-24 16:28 ` Ferruh Yigit
2020-01-25 18:56 ` Matan Azrad
2020-02-03 15:58 ` Ferruh Yigit
2020-02-03 17:10 ` Matan Azrad
2020-02-12 13:49 ` Ferruh Yigit
2019-11-19 22:40 ` [dpdk-stable] [PATCH 1/2] bus/pci: fix driver detach clear Thomas Monjalon
2019-11-20 9:02 ` Matan Azrad
2019-11-20 9:47 ` [dpdk-stable] [PATCH v2] " Matan Azrad
2019-11-20 13:03 ` David Marchand
2019-11-20 13:44 ` Matan Azrad
2019-11-20 13:51 ` Thomas Monjalon
2019-11-20 17:22 ` David Marchand
2019-11-20 22:52 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573548459-6931-1-git-send-email-matan@mellanox.com \
--to=matan@mellanox.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=mukawa@igel.co.jp \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).