From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E30A6A0574 for ; Wed, 4 Mar 2020 16:01:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BFC7A1BFAA; Wed, 4 Mar 2020 16:01:21 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id B8E2F2C02; Wed, 4 Mar 2020 16:01:18 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 926C1B4009D; Wed, 4 Mar 2020 15:01:16 +0000 (UTC) Received: from ukex01.SolarFlarecom.com (10.17.10.4) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 4 Mar 2020 15:01:08 +0000 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 4 Mar 2020 15:01:08 +0000 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 024F1822028780; Wed, 4 Mar 2020 15:01:08 GMT Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 30C721611DB; Wed, 4 Mar 2020 15:01:08 +0000 (GMT) From: Andrew Rybchenko To: CC: Date: Wed, 4 Mar 2020 15:01:04 +0000 Message-ID: <1583334064-15109-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1020-25268.003 X-TM-AS-Result: No-1.843700-8.000000-10 X-TMASE-MatchedRID: 6T/Emh5i8VEHKdtUS/l9oUtBpTx/ZEdyfoqhZTBgEQ+KIo9dsR2z7lsk cYD9GA2rfJhOFGsLLsGmcFuKGELrlinqwKmU0oYzqJSK+HSPY+9LXPA26IG0hN9RlPzeVuQQM6G 9MqUkD9OebdcrhGGaaQPYmg1gPtn8kfRhdidsajMURSScn+QSXt0H8LFZNFG7CKFCmhdu5cWbe+ yUR1Su2xa56ifssDPMJhZOZyl/u3YI5oxR20E/uoG/BcbFoq/9mnwCCTPgomcZBGed1YgkaDr8E G+eMykERP37FvZm/GEPXLxHfxLeXVRHOSKs7RDUXmH0pBaurgG+4xOvsJAknvqy+VVvqH2X X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-1.843700-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1020-25268.003 X-MDID: 1583334077-Q9plnpUqdbn9 Subject: [dpdk-stable] [PATCH] net/sfc: fix promisc or all-multi mode reporting if dropped X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Requested promiscuous or all-multicast mode may be dropped on port start if FW denies to enable it (e.g. because of no permission in the case of VF). Return applied value on get. Fixes: f5258439ee5d ("net/sfc: avoid failure on port start if Rx mode is rejected") Cc: stable@dpdk.org Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_rx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c index 7afd2c8b3..f589ece75 100644 --- a/drivers/net/sfc/sfc_rx.c +++ b/drivers/net/sfc/sfc_rx.c @@ -719,6 +719,7 @@ sfc_rx_default_rxq_set_filter(struct sfc_adapter *sa, struct sfc_rxq *rxq) sfc_warn(sa, "promiscuous mode will be disabled"); port->promisc = B_FALSE; + sa->eth_dev->data->promiscuous = 0; rc = sfc_set_rx_mode(sa); if (rc != 0) return rc; @@ -732,6 +733,7 @@ sfc_rx_default_rxq_set_filter(struct sfc_adapter *sa, struct sfc_rxq *rxq) sfc_warn(sa, "all-multicast mode will be disabled"); port->allmulti = B_FALSE; + sa->eth_dev->data->all_multicast = 0; rc = sfc_set_rx_mode(sa); if (rc != 0) return rc; -- 2.17.1